From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDDEC3DA45 for ; Sat, 13 Jul 2024 03:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E20256B0083; Fri, 12 Jul 2024 23:38:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCFF06B0088; Fri, 12 Jul 2024 23:38:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98596B0089; Fri, 12 Jul 2024 23:38:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A9F736B0083 for ; Fri, 12 Jul 2024 23:38:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 58C741C2262 for ; Sat, 13 Jul 2024 03:38:33 +0000 (UTC) X-FDA: 82333322106.25.77742DB Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 7DA2DC0007 for ; Sat, 13 Jul 2024 03:38:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cj6o8sat; spf=pass (imf22.hostedemail.com: domain of dmitry.torokhov@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=dmitry.torokhov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720841894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FiBsGcQmLRaVsI2yv7YiaCnQue9naqNPK/YXyR7mxPE=; b=R7x/bVsb/d+NG/4SRqCM0SnV/OkSnTKkaY5XIRgmkx9PQl2YgiIHM8x+SlZzqELQKyXL0t mXbji1OAHUp79pZRcIXkteFAlw0RxjhJvFfnFSkKVOY2iR7H/FjHky1Jpf609R6/aUAl+I srnoHIzEkF2qIKK2V7c43K8P6Jel+uA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cj6o8sat; spf=pass (imf22.hostedemail.com: domain of dmitry.torokhov@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=dmitry.torokhov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720841894; a=rsa-sha256; cv=none; b=NnsHmgmTCXM9xAsO3gnOAbNiZdyFttrgZooPLP12WAopnjs0gdwlwqdJvqS7QWzA5oTgrn uwk5SQRvvsQnSs1AYn8cp17cRXaC2k2mi+2Mc+tmfyr1ks7S0nAonprFXkC7QyWDbpiIOH BF2Zi/wbRPtEfW2RJiSfXOCateh4Ssc= Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3d91e390601so1528530b6e.1 for ; Fri, 12 Jul 2024 20:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720841910; x=1721446710; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FiBsGcQmLRaVsI2yv7YiaCnQue9naqNPK/YXyR7mxPE=; b=Cj6o8satzPTuLGottlGFpT+ZWAX+rdQLXHsC8y1HNGIg+z2kxW1+G2k/2cBviuxSbc ijecpig18rnlzIv0ZKri3GQtY4JWvpntNdnQg2KJfBUR8oW907hB4QbN45nLNgBKepqB cR5qy6pJHicPNE3Cq/xqSU+2VWjbBArC85I3LQItSzzQVCJiFOT8hMeuos+Sj0fIgYQh 2ji2TKgCLFL9AIawmUMoNM+YmPTbPCh+rrfUtNcLeMcSDce9BAzrves14nkOM4glpC0x wsZdHVDmSegNWVxSbCFYUnTzbX6QWCNMS8NY4ScTDddUd4BElbkROviD1VBdBf//RLZD CK3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720841910; x=1721446710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FiBsGcQmLRaVsI2yv7YiaCnQue9naqNPK/YXyR7mxPE=; b=VV2uhhubbb8MlLkmszEd+Y83l2Mywzvj/4a31BE7cmgIg9eYAGfwgvOR8GTTjlH1X/ 6qEi9hAH8Z+T09TSofZyJBEpE+VXjnH7hzTAu/cOjYx0u+PmLRYRqeFGoM5ds+EBtzRc hJNraBxOPXK7FQ4NB0I/NehhXvaRUu76NUcFnpWWwBQp8uYMkM+Nq+hpZJj1nyzPzg3f Qv9rLA7g6GH74EgfbcukZti0MVAWP3C8zdjXvJZgzSadvodujmO3Bc4ggruj1psPIBvV +l2o+2LGyFq2oI9qvIRS+z2no06Kh2iQoEsVhRwcw78dJpIMgtRambtJwJGi6Rg7VNTH hlBA== X-Forwarded-Encrypted: i=1; AJvYcCVHf9ygZsV5NlZrTx8fc+8ck/DLxQ6H85NnzCNZiOZc5E6jhYmtXt+3a5xaz+2D8iBSU2FSNFhcXtnEubRKW1LyCRw= X-Gm-Message-State: AOJu0Yw0xgxi0XYWoGMrT9Ra4Hq12SnQWzyylLlekNu5m9buS98gQCVy xNriXbYMH9CtP68LirMV3avNczltoUPgpFUTM2TK+GwBEuNTICSI X-Google-Smtp-Source: AGHT+IHKSLleoWrUikSg/5b6R7jJq5HF+hMXp3QQpWu+LHrOABQrh/dctWcAIiwSM7ohEgQG7zCHKQ== X-Received: by 2002:a05:6808:2384:b0:3da:a5fa:9905 with SMTP id 5614622812f47-3daa5faa07fmr6916088b6e.41.1720841910261; Fri, 12 Jul 2024 20:38:30 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:669e:eb9d:e30c:18b4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7ebc4637sm301622b3a.88.2024.07.12.20.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 20:38:29 -0700 (PDT) Date: Fri, 12 Jul 2024 20:38:27 -0700 From: Dmitry Torokhov To: Arnd Bergmann Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Linus Walleij , kernel test robot Subject: Re: [linux-next:master 11606/12643] arm-linux-gnueabi-ld: arch/arm/mach-pxa/devices.o:undefined reference to `gpio_set_wake' Message-ID: References: <202407112039.cyyIQ3Js-lkp@intel.com> <0de0aeba-da02-4fa6-a1f8-a468dcbfac58@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0de0aeba-da02-4fa6-a1f8-a468dcbfac58@app.fastmail.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7DA2DC0007 X-Stat-Signature: g8dgt71neagyrsi8e9udm3zkg3qwwjms X-HE-Tag: 1720841911-725233 X-HE-Meta: U2FsdGVkX18Jgld0wDLIapDkYp68OSfw+eQ/taxoF9CqBd77Yssg1yFjeq0PovgSMJZCwi3Gj+xywypeFV75N7zEIE+DBvfa7IqETDps61MkBvSEp9B8BaVrXJpaQ4a2TuvpE22b7b2WAMVjAulo0Ub2B6A/Uconm3XbeaeqGi/ON6z4OafWMCISK3B6F02HpNau6DLli1vFMd1I6ibCBOUG5QCl4k9dkv4BEvfyUs5n6I1vWIJGvwOTVtLNE+uXzQHTWA3gvDa3f3HWHOP8RM8DRiby2FVOMZCcoW4PkrvHTSApaF5zxjuYVKOZV2Up5nkgSN2c7a3R2ieaOb1yipPD5ttk37xF4XKVg0UDZr8LNFnHF7d++Z+mNl9fpFdA8mmyNkUKi9gtGfZDoLjdQVeYSdRAq9it4uApDi3k3atqEuRwwqTMKRqcvZBN5SqXx//yWn3wkMA2D9ZR/DNL7nQ09RQzUGaRhmXCV2TyVjEVcNkcX66v8xSdhpHhOnOr3uSb422gpFIcU33WnCh7s4fLJl/yxzHp49A8VRCRsf4vDFIFC8wY57OEPcpKSOMJ+tAuZTSIa3L/F75A1r4yh7pzEOjIY8x8nD3hpnEu4x0bWMRtereXhEiFn4O3RMkcoY5/ehim8JUiLonL3Oxna/Flo+GbgqzK/aNXYcs/OHjuwqbaJO55AravARxn/iHFtWu1QbHUOCK5ay48kou9qtwfZqCOzApVTSX7o4SMJx8OmGH+B/OqGS6aw6CFFu09bhqkXuH2raeff6FEDW2cxkAOUmeVPpQvmks0C+aFgY56r2PWTZoHa1b1POJZaaRRY8YP0UGJQbS3sXfQTQUD1yHCvK1d145E0wOq88tbnC8tM63saSRN+sBpKUbWEac86ZGcC7UCNcU7UwyO4+Yv7uIM5Hvhwl5p/jabxxp1fDo2xApugSCcwvs9h9gFzEUU5xe+FQNkT0FC1FxnR+J pLucHMgw GJgP3lx5MGKp62ZHbArwQoakW7C1MCIaYoQZOQWLtMx7LAUuzeSvvRJt4r5PW+HGD8USApqGe/0TE2UmOwE0WkFCUsUJ8iOb6vmzmcXJn6BNmwR/pDHcAtLZOtbvYMJ00Mud//5AvCm8pTDjDx0FLdU5eqWWwMxzmxblL4Ta+1zFfeKg5Zx7Td9XPC/YbEs/uYdB7n/dYrAE+V1XHRiWreHlE+39xIVKmaECdvDhXhI3zynmhkG7HGGJgeGf1j3ibicsrObrkLtxqB73x2FU6/ayO4QG7T+DY9q8DNWxn7Z4iSk6xaiTex4/LnQFBUX59zO0jYg7yckuGqfGJfkvpeqqhLZ7aL78DBnInfoKMPefYezbJJN1vjZLndYeDnaoihisOYOO4xs9YKhH8swn0rm/ol+oYczbsUzd64uqlSIhrv+bf8hze/FbfhLpeGnldHOrfNONB4sYiEw/7GcewfK57ECGlAvcP2tgZtNQSHjje8AY6aTC1uLNm82W827Kbh5ILEvfTfSAebNzRT9SqAMqtDoOCQIzLBOPCbBoUWG4bjJk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 12, 2024 at 08:41:58AM +0200, Arnd Bergmann wrote: > On Fri, Jul 12, 2024, at 07:31, Dmitry Torokhov wrote: > > @@ -684,6 +685,7 @@ struct platform_device pxa27x_device_gpio = { > > .platform_data = &pxa2xx_gpio_info, > > }, > > }; > > +#endif /* CONFIG_PXA25x || CONFIG_PXA27x */ > > > > static struct resource pxa_dma_resource[] = { > > [0] = { > > > > If you are OK with this I'll submit proper patch. > > Right, that's probably the easiest way. I was trying a more > elaborate change (see below), but there is a good chance I > introduce another regression in that, so let's go with > your patch. Please send it directly to soc@kernel.org > Cc:linux-arm-kernel and I'll pick it up. Done. > > One more thing I noticed: if you are doing more patches > to convert devices in board files to use software nodes, > we should probably try to move them away from static > platform_device definitions towards a dynamic > platform_device_register_simple() or similar interface > at the same time. Sometimes platform_device_register_full() which operates on platform_device_info structure is very handy, but in general what is the issue with statically defined devices (when they are never unregistered)? Thanks. -- Dmitry