From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D5CC3DA49 for ; Tue, 23 Jul 2024 18:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C0956B009F; Tue, 23 Jul 2024 14:53:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 570A66B00A0; Tue, 23 Jul 2024 14:53:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 410C06B00A1; Tue, 23 Jul 2024 14:53:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 20FD16B009F for ; Tue, 23 Jul 2024 14:53:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B4BEA1603A6 for ; Tue, 23 Jul 2024 18:53:11 +0000 (UTC) X-FDA: 82371914982.30.8D5C4D4 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf14.hostedemail.com (Postfix) with ESMTP id A6DF0100018 for ; Tue, 23 Jul 2024 18:53:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="A/nx0SYy"; spf=pass (imf14.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721760767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NVVj/cCy2oiJw2oQFMpyw/dNkqdjUwzvcq4UB4HNEXc=; b=La7XXg/Cg/HHYlIvNSrUKmU+2mSuyFrLqNC42PjQ2WUSKzZtYWDaW+SbaztZqlAsokF+Mh Y5oRZFdCTHpIbMvwV7240TCGiWefn/d1j49uk0ZkuZAnqcdt9ZCRu+uINUwTlqI6E/8rj8 PZtNE5yXIgIFVNY1XGyoBEyVJCCI/NQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="A/nx0SYy"; spf=pass (imf14.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721760767; a=rsa-sha256; cv=none; b=DkO6DDzMMxlmZQXBtt9rQLGz/LRzu4xbpnVOYZsAlimagYeR+QmTyMaN7dWO7AgJTzGlIf cKO0D2IYY923eaxA+X/TJjbM1Rzps4dmvYPshrsp7vbFyRKrgXSnaOU/uKbEgYDhZMWDxH i0BIRvAEIawN2YoZ0XsVzqC2KF0kwQA= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5a1fcb611baso5010315a12.1 for ; Tue, 23 Jul 2024 11:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721760788; x=1722365588; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NVVj/cCy2oiJw2oQFMpyw/dNkqdjUwzvcq4UB4HNEXc=; b=A/nx0SYyXbP0bg4pq9WYhPvM8bXXxmbJUdfaHUI2+dfB8xrPC+2bmUOz1czVWCb8VC nARIdWiorU9ETEK1FVAlVg1amLn8zXEKuI/Poixr0t/bI91JuUNkY6z+jx+bRfj+j5ZL 5g2IZRJp6egxYOqVPTpYHcI/DoY+8YL6XenVGKGBxi6oyxoRQFsuyLR6ESpMfTIwuKSV TBG1qGtFJdEw9M15gePxqhYFdZ89co083rD1wrAxL+afbC+xlj8rTlkpiK+Ccxp1WGrX LsNU7nkkZqpSMHJ1qEAbU84qt7tdH64LAC0f2MQFpB/8dVrEn+5iMRsQHomvIMZkBtPC 3XMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721760788; x=1722365588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NVVj/cCy2oiJw2oQFMpyw/dNkqdjUwzvcq4UB4HNEXc=; b=lYq5Xsyh2sWvB4qI/66EoGFzBOeOo1GCH3vSZ8pWpZlNp2wCzQboeZiM9W/VC8ozsv 1WwAIRclhZEiGyk/qFUPngs4Fyco8NvYToMHFF7RT6J2MomBmGkcM1yMqX05hxHYkkOE qFHtUkGHh34hr31ZkPn0JNakTVxJff4AgSXz6IhyvrXhaC2wodQp1tq1xxmDmlj6NLD4 TpaTrHHUe75GFxPwBEczQlYtoJ4QZyXI19Nv5r8A18jmiOu7yLRDOC/djKgQOCMS2i0s 4/a/SW45+Fa6ebuC2OHgrdqRU3AKkKaIn7nAdLcf8wun49OhwZziTgoVbFKDddKirHrm 9rHQ== X-Forwarded-Encrypted: i=1; AJvYcCU3PZc7dF9+rJmQePDJHvn/lgfUnFQwidGSlBhdci6XzLM2hCC1Z2+37TAObWF2Nafn4XeD/YM+Y+TBH+yFu6HeP+0= X-Gm-Message-State: AOJu0YzF9kAFOn3NnZ0eOjrTdSDSIpeLC/XGrJMHJc7ofecERw/W3vYf nA6m3SR3d2OiAZ7NhjBHzHOKQ4yK+qO0IHzHHy7o5fCIJupJkKff70c5288qWx0= X-Google-Smtp-Source: AGHT+IGU5izBNSNx/9V+PTQTzUGAa2O7y8xkGeR1qCRxtketF1SAQy7A5fxH+5zcMtT/IhDRYbqE6g== X-Received: by 2002:a50:c047:0:b0:5a2:838a:15fa with SMTP id 4fb4d7f45d1cf-5a47a33a349mr6201088a12.15.1721760787929; Tue, 23 Jul 2024 11:53:07 -0700 (PDT) Received: from localhost (109-81-94-157.rct.o2.cz. [109.81.94.157]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30a4d6e67sm7895632a12.17.2024.07.23.11.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 11:53:07 -0700 (PDT) Date: Tue, 23 Jul 2024 20:53:06 +0200 From: Michal Hocko To: Danilo Krummrich Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, urezki@gmail.com, hch@infradead.org, kees@kernel.org, ojeda@kernel.org, wedsonaf@gmail.com, mpe@ellerman.id.au, chandan.babu@oracle.com, christian.koenig@amd.com, maz@kernel.org, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm: kvmalloc: align kvrealloc() with krealloc() Message-ID: References: <20240722163111.4766-1-dakr@kernel.org> <20240722163111.4766-3-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A6DF0100018 X-Stat-Signature: 4nx3sk6ew3fjj7iheuggqscuezucwsmq X-HE-Tag: 1721760789-711 X-HE-Meta: U2FsdGVkX1/cn9gcJWlNsYanGoNwVjA5APcNZal548mzYf8/GpioNJTH0dzfD1dsKKUSmh1DdSNUqfS7iylAsPiUKzP5BsoTN2RrR6MJ7zmL89hGhHEEg7vyBfjhvfS2qcKgLj+LSsfW3Vt9QRdbL3M7MUSIUpFLL80wSV1oWNZJO6BHSMIIoae/58J54tvn9Bp3vIwQKfhDp0kc0xb+I1fJDY7dLA9R4fQzS3x/gR3ZfPteed27RD5qWZDrJRTcMR0R4BSwCUhuvBsxgX2kj1YvWhgnBPPFZEByehP7TqMycHkcaiuaRNe/+/z9ntlKP+c+4W1SPSLvgdtaxCgfAkn91aOcMPVuEfi/gVan5nUa2NoY4rQ4dhOrExY/fv/J9s9I289oS9XFbGXhSgFLokBFsD4VFJ3Wik/wAYVg3qhgA73+Rg+18OXEcS+i5g7jmD+lcdJoHqTTyBjcWHkefOfZv23fLgsIQ1vOjLJwTQz3M1AeC6unnrHESwwQ0Fqw24DDsy0pFn0/iAVHvGQhT2EQCqm7jTwkCkX5/+7do/EL7syuv79YL+i/zJu8vdBb/aNiDrXEs0xYcgylWxGOkn5BWSUcBqyWcgYUeDPAJG7yWMAwgp9dTz4NkXEqw/kEHcUQO4srQbXsCCOgfJ9F3RYLm/eF8gQ7bjdVgJlSbroY3Ce4rI1XVGOJLVa6p/X3MBWKYOBac0Yr+UUjobw7zDZHpvh2OjGMBEUtOjwJwIxwbCo/JXuKbyg6897txx0uap9oNwnw+OFCl+pWk1fTl/OZjnRph5P7lLh7F8tpU35+GPQDkCEGnUej5U5LSKbiLNhAvPaiiDI+Sji51Ngm5O4aJm9UQ8cAm9nzb3Wp9IMEW0Gk1kVo1kDriExHvJJBJchzh1H++/6McOTu+4j0J4z+D10kXWYlWHvR3qMaTXbA6TPudvIcd2w3U4puQvv+meK06y5QwtXgtfoVrb5 YQsybNzd iFch9iFcKysOu69hGLQ4pClALv4hRFYh2wg4QdKKpfpjQjfwwlW6+FDlMnihUPh74KJ/hfbyjVhE+Ds3IgwlgondHIQHhrrffe+e3O27fjk/bRXMwNoqS5EDIc94U3ZsfGIgYF00uuBZ5BUPdKFqPuVpmkaU+xGIPTqzO0zNX+WE+QOXPsUJTD4/tJT0n0V0fGxRgQ4BcdVergd7tqWg/13kRZb03aLSafI3IyQHAyB+aFYiDpJhLfaKNEv8o580pGstMGRgYai0i1TbMKX80tLbADzWCrx920xgDRw5sJookmTGMexhhxwxQ32jAdbX3jqI/I6RuO2sCLzpQr40SwGGqvHNcA9BFiHQbYyHxSrdkB30= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002600, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 23-07-24 15:33:32, Danilo Krummrich wrote: > On Tue, Jul 23, 2024 at 02:12:23PM +0200, Michal Hocko wrote: > > On Tue 23-07-24 13:55:48, Danilo Krummrich wrote: [...] > > void *kvrealloc_noprof(const void *p, size_t size, gfp_t flags) > > { > > void *newp; > > > > if (!size && p) { > > kvfree(p); > > return NULL; > > } > > > > if (!is_vmalloc_addr(p)) > > newp = krealloc_noprof(p, size, kmalloc_gfp_adjust(flags, size)); > > > > if (newp) > > return newp; > > > > return vrealloc_noprof(p, size, flags); > > } > > EXPORT_SYMBOL(kvrealloc_noprof); > > This looks weird. The fact that you're passing p to vrealloc_noprof() if > krealloc_noprof() fails, implies that vrealloc_noprof() must be able to deal > with pointers to kmalloc'd memory. You are right I have oversimplified this. I was hoping to follow kvmalloc model with a clear fallback and that should be possible but it would require more changes. Scratch that. -- Michal Hocko SUSE Labs