From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7008C3DA59 for ; Tue, 16 Jul 2024 15:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C4226B008A; Tue, 16 Jul 2024 11:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573FE6B008C; Tue, 16 Jul 2024 11:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4633C6B0092; Tue, 16 Jul 2024 11:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28DEF6B008A for ; Tue, 16 Jul 2024 11:13:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6B65B1C1139 for ; Tue, 16 Jul 2024 15:13:06 +0000 (UTC) X-FDA: 82345958772.15.A98BF64 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 6BE66A0022 for ; Tue, 16 Jul 2024 15:13:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oAmvVuGw; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721142765; a=rsa-sha256; cv=none; b=VCGKAi/ODFWdpp8+LEVw3oDO0Ve0xZefwna7W2zDfiuH2pOujmgVdkxNAeQblP8c7UBYWd xk6X50Zpx4n3cbX3A1Rfl8GpTt1WZ7FJJ/jNcLXEAb/J7OphRkk5sP1nMamci8b5nZpLRo qMfIDlMEI8Hr7vTprf/ziqvkIuqinVQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oAmvVuGw; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721142765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=+uhxURMK4WL6aKWXU2m8zwddHPQ3ZHVWkTA0h44Enxo=; b=Li2AiJBtyn6SodK+J5pNHzwNIqoZCguqpM/nlruy1Jx9B9fG4IdxrVvSi/gBGkyamQwUjg Jk5F043TpVAIpDtUCQpZZk5EuSa41Hz3mH9dV1Jo7wS+cq673ZDBlEs+pnVErcN+PyfMpT MJa/nsjLFLD4Ttewbuqh3aaibV/FRek= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=+uhxURMK4WL6aKWXU2m8zwddHPQ3ZHVWkTA0h44Enxo=; b=oAmvVuGwDrNYAG8o0vQI0YzxYt yYeR8CEm2sEGdtWsmYU2MbT1WfUN3d9BMx3ETrTrIg9krgZT0C4TKrAo5MO6I8FYFFTDOub6zGCZM EOGYeGcq0mlEVEt0+dTYess00E8Uf4pkO40nnzo1bLlhV379D2fN8tBAC/ljRtMEiMrczKEIe2i2h pFQgoFKo4GaXlYiAZI7lT8Q/EIhClCUkaAYSeVVMY9ndg5fGUqmfTcD6kNS94V/2qzEXubKk56UK0 v7qFYyDCk48quDTl9thktpmTQTH27Z6MjiQfiGXibX6Xj/AE8vGrkC84FK2iYvssnMb8QUtLXwQz4 8Ypv/7Dw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTjrL-0000000HEn7-3FlH; Tue, 16 Jul 2024 15:12:55 +0000 Date: Tue, 16 Jul 2024 16:12:55 +0100 From: Matthew Wilcox To: linux-mm@kvack.org Cc: Miaohe Lin , Naoya Horiguchi , Jane Chu Subject: madvise_inject_error skips pages Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: njaczfyukbkibjer7n8x4y4ryiz49e7o X-Rspamd-Queue-Id: 6BE66A0022 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721142782-253090 X-HE-Meta: U2FsdGVkX1+R5cmac2IXhrXOhncYrzJ/OL393kvfEqCOXWwCJ0igl8nIRrixgT20Hiwia/EURruaSsk3uWEon0ql5FaM+fsKlfCROLuC0A4AS189aqshi3SqYTFaxQ0o/Vjgm3zqjGHnm1qYPlg1jN/bUCta9OLy0OZ05RRv7V52lb+7Pqd16rCfamHaRjq2wOsAEpZPuSCKYNDXoyl/WgjudWd5tJhrkUWnmo2IryhzPv1dMbezBr40a2itlc9rV2vEbWcZSPxP8VQt7c1Fg2gcmyIPmo+pevivdo8iZC2Bxgg1LoHfL8W6WxnHi60KeLZtE8lRZ/MGcSvdSPiMqsb2kqoT8qrC5lb2nLZfJcuJpPV4XPwxNypl7CNWntxHd/HJgcFHi1OK6CC32DRIh6tDDy/839cnj1/4jhfcmBvjswOSXGL3BINGT+JEb+yvkjk/A/kad0O6iFC/JQSnsEaJ7t6U6h4WGvIR2tlFizHaI5QXGz5eKP+YFaxLte1F7K5iUatvbnKdLFn+UGm4RjwP/lMH00IsNo4z45x01O8de6oWEsxt9fth28ToAiTsB56CrY673GHhzxqU8jUrmpv8e82ue8Iv2617SZwTiCqKivBywiYfeuKJ1DYCsYwLtGns58g1BAhRKMdQQ/GbTWEElv0lZckFh/7EUBN1NEajqERy81468YodOuqOBnIkGtSvYolLfn/Vtav5XKpwitvW8QtgB218F59c0ONrM8mJM6T54DB4DiVRB2ksB4Mi8Wc4umApN+PcYfDlwfe5OW2s6nymaaI3ZFB+KYSBGaNxSb6+jaXQVXK5iIqBtPt+9vnGtMjCqN0B1aVU4mWS0xu/fx9IyQDtVxhx4zo0DmoIeGFrFyywjXIrgmy+09Tv4uu2VpLpk9J323ISCGEB+gGpCZvhwS4+3tHP7kDKQ5Wep4HEub5O0zulpk0vA3bwjqND93Kp+EaF1MttseN dBxvHuNR amww2AP/fZ85enqBs+BWcjEzs04dg5FbfgDCN6gp/dgoFrouSx9QDnrF7CMb8EtfJWN0zfMK5zQdc2uEA+/aXL3nAoEZ24u16XdIvL7116YhtppXv3Rj2+BHmFiA9CoWczfwJGrg+f0UV1yXI/i86BDRuI8KGAT0OIR4bDwJPSpgKvCqzIPRbOl2YMtcUjDO5zyoRTjPpYnySLZNzSavLGkTF9XRFgPOhOQn4qo6fh+7bPexnkIUEpzq4V10nB5t2mISedijY3bzz69OmUIQWqAPcrLQNiFtDb1fsISb5EYadgQZ7zf2EsGco47ZdXOwlYyNN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I was going to send this patch: +++ b/mm/madvise.c @@ -1136,9 +1136,10 @@ static int madvise_inject_error(int behavior, /* * When soft offlining hugepages, after migrating the page * we dissolve it, therefore in the second loop "page" will - * no longer be a compound page. + * no longer be part of a large folio. */ - size = page_size(compound_head(page)); + size = folio_size(page_folio(page)); + start = start & ~(size - 1); if (behavior == MADV_SOFT_OFFLINE) { pr_info("Soft offlining pfn %#lx at process virtual address %#lx\n", because right now if you start in the middle of (e.g.) an order-4 folio followed by an order-0 folio, you'll skip the order-0 folio immediately following it. But then I realised that we can come to this path in the middle of a large file-backed folio that's mapped misaligned and has a COW page in the middle, and the whole thing is just misguided. So I gave up. Anyone want to take a crack at fixing & testing this?