From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2CEAC3DA49 for ; Tue, 16 Jul 2024 15:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 498596B0085; Tue, 16 Jul 2024 11:29:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 448866B0088; Tue, 16 Jul 2024 11:29:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 336DC6B0089; Tue, 16 Jul 2024 11:29:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 168FE6B0085 for ; Tue, 16 Jul 2024 11:29:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B948D1617EF for ; Tue, 16 Jul 2024 15:29:13 +0000 (UTC) X-FDA: 82345999386.24.FD3A65E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 0FFB01C000E for ; Tue, 16 Jul 2024 15:29:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wlwvi9e1; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721143733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dDRACH2HHcim9UX3PaS7VDc6SEL6ZuTEADUo9eEcXBU=; b=8B/CKVxl1w6EXNL5Ms54yYdlGNyOf18eaKTeCqpgMwItQzZeyc5K9DBelqaBWpGdCcxxxp VyaiY6s6K2XapVw1kHWbPqbkyr6msFyrAu1yjduQEQ1SYV51z5tvE+H55k5Gl8rLJ8lMjB RebyurEE7TjxLAkXVczBOgNlvXJI8D8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wlwvi9e1; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721143733; a=rsa-sha256; cv=none; b=XW5SNnq62UXdpjDFf+Ux+A3J0nB3/EjgoPrguDr3DnVME7yBtDepRj1Q54o/DNTJMWPE+g UWzWyGRM/XClgQc9Z3SlHKYmonPZ8vssQTtN4Ryml1SwnQpKs9jfB0dT4d8GGbyqVmUX77 cm9d8+AoRZEUxfc7yEE/bU9pJDPGzLI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dDRACH2HHcim9UX3PaS7VDc6SEL6ZuTEADUo9eEcXBU=; b=Wlwvi9e1dHjqquYLnaeF8bHCg1 7oMEeKnsZn5q9sOKHcqJD6DtVV6MLOfKapWL5pbQdKf3Uz43lVqw4z7cCK3sSrSCfdrtTEHcnbsUJ tWYsBSKInnqUP9l1ggBzQWkMmfpNILYOulsy3V3CYowleZNp8c22g99QK/6H8/eLKejFq/GHSt2b7 NpZijnKeJHDMQEcGafV0HxCKSF/hr5hYV18Db26UvBPVLh7fuRCHFNYs6N7gE9FnMO5y2V3xi0wCH LHxe7+ZY/9Q3n3JAdVrhWlR1oN0aQezV+bykYgRJ2gpyxjUb1GR/HG5Ew+bGSfoHmWu8FYLkcxbxd vpsWQclA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTk6z-0000000HFSe-0jAP; Tue, 16 Jul 2024 15:29:05 +0000 Date: Tue, 16 Jul 2024 16:29:05 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, ryan.roberts@arm.com, hch@lst.de, Zi Yan Subject: Re: [PATCH v10 10/10] xfs: enable block size larger than page size support Message-ID: References: <20240715094457.452836-1-kernel@pankajraghav.com> <20240715094457.452836-11-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715094457.452836-11-kernel@pankajraghav.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0FFB01C000E X-Stat-Signature: kpup9uz3pakcgfjhiawsao6zhicwue3n X-HE-Tag: 1721143751-428856 X-HE-Meta: U2FsdGVkX1/Dw9738rQeeTUREmiyGYXuX43XEdivL7uY69GbjVbOST+ybz3MsFmySgxT0RM5yAbIhcAaOeWTZbfVwYb2S871IheqOVmBnq05CHpDaA7ydzPwfYi2zhKmwC5T8v+0iR32oDuyY3I+u61PcPZ+nS2ov83huMU97k6fGk5Phf4wvOCJ7fyxkiJkf1z1lM0opCxA5E85ABGjdjrBdcObN4CxOWlDhg+8jdL2vFatQROFyBibVKDN0MV03TuqOJpweL9DYgzb/PwfN0ICIez5c3yKsrZPhaoDXM66vUelLIFcK9QYHJEuIus7vvyYdj6q1r1t7FnjWuoy+lpn5D5laE51o4BLxry27jU+qEE9land7FRn/HoR22bZpTObOTT+rRc2K0EctJQiDp241MIRs/aPt59nMQQuPQikzholgjrylYhBFeIzokaciFT1v/TXJKASWFvARROkWk9LNoq7nrZwLZK0zqtCZ8in/cvQTVlMGd8m4hGSrxsrMJM6LKTG8qPCBr6Lb8lFNXlGWyWU1JrSHiOQ9v+0Jm6QjjgHyiT4v5ow7lvQaBSBNo/FQ2jLvEiPHu7BCi4FmTqVHaL4C+jUH4OLuPbuW2l9T+cHDsrYYQAP7EQBZEGGNsjpRd2/kADgghz9zFywUZ59kdddgZbEoNFRCo7QPS9pzRXPcDA5AYWSaaYi9llsRK3qCKnJ5ukUnjICggEdLHtBTTMAoEjwO0vht74fcndm+2Cgqk1DayGrYK++ad6DTAyRXckml/69kroAW8vn+wU7I9wqFK6XrI89gH48c/qO012B3uk13cz0GWaNagvQB6J2nkM1Ek0r4WBIP+nsdKlgvXQ2JCtgYwT2rRBFjFSOFPy8eSXcdEqtyWK5jnpdD1solXwPcIGPsbtv8Oh/Ix7lt2W3kCyEUCTmECJAuyo33rzXhb5JtTuizH3JKhhRBdPHgKu9FhvWb0xX2j8 xiPnYt5B TtAcg0yuvYKIkooBYYKKTGihUk8k8cHV87n3JabWao4ZqwpKSDzQ4u7/Eito2vH5hRuwRa7mZjr5dB4w2NDHcM5yGOwTSXHXLc51CkcSLxuUi5/drP8VBpQ2yTvUBGMSSNVPJ4s+GG7lZWCKzxodLWpMZL7EI9Z2AtfwtEBLMdS66PgeNV4LNycJpxv/LHdMyrHfcqRgbDqUHZ1Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 11:44:57AM +0200, Pankaj Raghav (Samsung) wrote: > +++ b/fs/xfs/xfs_super.c > @@ -1638,16 +1638,30 @@ xfs_fs_fill_super( > goto out_free_sb; > } > > - /* > - * Until this is fixed only page-sized or smaller data blocks work. > - */ > if (mp->m_sb.sb_blocksize > PAGE_SIZE) { > - xfs_warn(mp, > - "File system with blocksize %d bytes. " > - "Only pagesize (%ld) or less will currently work.", > + size_t max_folio_size = mapping_max_folio_size_supported(); > + > + if (!xfs_has_crc(mp)) { > + xfs_warn(mp, > +"V4 Filesystem with blocksize %d bytes. Only pagesize (%ld) or less is supported.", > mp->m_sb.sb_blocksize, PAGE_SIZE); > - error = -ENOSYS; > - goto out_free_sb; > + error = -ENOSYS; > + goto out_free_sb; > + } > + > + if (mp->m_sb.sb_blocksize > max_folio_size) { > + xfs_warn(mp, > +"block size (%u bytes) not supported; maximum folio size supported in "\ > +"the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)", > + mp->m_sb.sb_blocksize, max_folio_size, > + MAX_PAGECACHE_ORDER); Again, too much message. Way too much. We shouldn't even allow block devices to be created if their block size is larger than the max supported by the page cache.