From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C7D8C3DA59 for ; Wed, 17 Jul 2024 03:05:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6E926B00A1; Tue, 16 Jul 2024 23:05:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1E686B00A2; Tue, 16 Jul 2024 23:05:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0D646B00A3; Tue, 16 Jul 2024 23:05:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B89586B00A1 for ; Tue, 16 Jul 2024 23:05:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 27E41407E2 for ; Wed, 17 Jul 2024 03:05:39 +0000 (UTC) X-FDA: 82347754398.20.4993F18 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 94B77A0012 for ; Wed, 17 Jul 2024 03:05:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jWqqmeH9; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721185499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uMzoD4TFTPuVMIL7GzZ6jZ93zy8yurvQtWHh5iApbo0=; b=rrA20nnLVaXZkkhHoBKexYiwRo1xMmYfCu+NRCSTI3r6DBQB119mEv+c1RSMkSRC1KFSdm h3C0SOmfGLS18YWk8dNfIuJXRDAS1DZ5ZLxzH/q5eLHc2zDAXopRyK3bIExEpTJ4TamGUT WCB+ltbiYjjMMevLYH7rlgYqtpyC0jw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721185499; a=rsa-sha256; cv=none; b=XLybr+XDOBFNVnTYlzVYslqLbFXtBgNkl6TlV2g5exXO5g0IqPJ8uYXndwdxJbNLN2iYCs Dktf77uh7qBSd2JGUUJBO0fpbCt1f+3leBCGQPp/p85G57irdFlwYhiI3clIdKUqz+EJmu Dz4MoORt/weMC69La12f2f3jZCY4TJQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jWqqmeH9; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uMzoD4TFTPuVMIL7GzZ6jZ93zy8yurvQtWHh5iApbo0=; b=jWqqmeH9qtHzkKjKpEbBDkiTAC MEFxa0Z484Y0iHK2qRKN6qZKKMGBo0sICJj/t3DV19UmjV+EXB8hYZN4TdIyH6evQkFXKoPU/nzsX gMiia23SIvHtw5BnfaL+Y5va21dzXr/LSK97QdpYIV8YEJRS5gfUBomX77AFw5xJAaw/UCj2HXoHs JYYTvIU3jVF5wMmagghNrwMPXyMP4GOUlYbAiIPWsjfJ9Y5coFQ7IXX1eacjHGXUpZQiuq2pb7Uly DtpSWSrHKat9GHoOuK9zLLQ2fnrbtPFqAvwRCdQuq5wT5B5I0AERA8VNT26I1nZgfK7hqKiZMGuow KyQ+YfDQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTuz1-00000000GPk-3HtS; Wed, 17 Jul 2024 03:05:35 +0000 Date: Wed, 17 Jul 2024 04:05:35 +0100 From: Matthew Wilcox To: Wei Yang Cc: Liam.Howlett@oracle.com, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] maple_tree: fix the comment on maple_arange_64 size Message-ID: References: <20240717014142.24263-1-richard.weiyang@gmail.com> <20240717024126.vwxgfnnposadxpsx@master> <20240717030313.olbztunrksqh6azh@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240717030313.olbztunrksqh6azh@master> X-Rspamd-Queue-Id: 94B77A0012 X-Stat-Signature: ux46jhtsafsntu4da5k66k9tcsfpndxd X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721185537-470575 X-HE-Meta: U2FsdGVkX19HaZi1EwVLcNrjXXbarzEFkYEXgURshOjJaxYhvRy7zJz4S6NXHASBmtc1cBwDuRQo+YcKpLZbbSt2pe88kyL1dH9bS5g+QVTAjcPOt3eUE19U6AGvXV1fgqJv+ZQFdJoI/84QXGF/db0OFPod6kEhnF5GoL4rRoZgD7iSt6Z8o5S54Ylo/iwUT7QmgazGz5KHwZdK6fiHxNJoztTckPNW6UjBz8QC5v4qUxdLTOKfxvhV9GrghOrc1EIDdKerycDoVsQk7URrO2WbcCGV5/fgEwG0hNEUR+KzMLySbCET59kV3WTIsI5iLc6vVjjHbfn2X9LQsc5NsF0+zNaJESGRjR2BbvSsQIaD9Y4NsPpblmu4DlW0rV5CsJSjH/68MuVpaEalARXCPGhDNAVLc+DOm28KvFjcj5PgU6dokwGkzEXnRzFY5fFeidr5A1Y1hDANGgDCQ6DovFgCCJ2zEA6e1IznS1kzFAZHvMyDGOkgf1U7PxXbuqU0ct8oineOoc0g3Zkbb9rHB9H5DQdxKpkfV+/GOr8Ta6MjQrS7TIY+n6HOwBCfnk2RptvpWFisCZ+b+Ia4sK2Lem7HF2vT91qD0RUZnFwTxlH9pVqH+ZoPhINpo5T8fwmBQxjXsy2fcbFYezIzU7EgXu2gxmgmwQbKBsbkmDgvw0/Z/86SYSeTgRg/BJRXeum1QN2ljU0MCsrPT0fSMEnYaf21DF0PFcKlB+e3DuQNCMNeJ0Juxm6qk3IdBbZ2pqxm1d5oY1vzBmWwWaaeem3Zhr+RCI4sCL1JkJ2Oz8apP/lROthuq2Qnpplb60fivfwpGC2qdGzsB0GUDNJKb3XhShmeSsvm/j8DaYh59GF38fjXS096I7Vj75KuxvI0hHRq0cy0WKw9EgrSEsAFNHKLnHAtuXQLtyXk1ZaBqasBVyTwrY+uuLGpiYA4itgN8bdc8FfiYW7m7bZiqcEf2IO DlgjOPyQ JDVRoxOGPPBha0U/dlRLyEyeaoGOUEZzD1BPMHObDMmvjCTd0w6X9pOwEqKhb9vGTh4oEFj8zIvlrvHDGIaqrFXGmR/73YQ8el8jS518clB+ULl1w/kcAvDBWTGZL/idWv/pni3yZiWZlEGOgVkO+4mxtdgVRMA+BP8VeUAeiSZQPGKBrmdYi4YVYht2KcmVhdonBoeSyblBzX1FteISbdrlf/ttx1aGs25SpL9GKioj8qGMEjRvvj6HGu2+MBJHLRgRd1yS3ILBqjAPDNyEySds6Xmaq+VlWLnHk9CwqOZqZTJ2CLRf3eGm1zIChTBbYeF3t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 03:03:13AM +0000, Wei Yang wrote: > On Wed, Jul 17, 2024 at 03:45:40AM +0100, Matthew Wilcox wrote: > >On Wed, Jul 17, 2024 at 02:41:26AM +0000, Wei Yang wrote: > >> On Wed, Jul 17, 2024 at 03:06:01AM +0100, Matthew Wilcox wrote: > >> >On Wed, Jul 17, 2024 at 01:41:42AM +0000, Wei Yang wrote: > >> >> The comment here describe the size of struct maple_arange_64. > >> >> > >> >> The value here is not correct. Fix it with the correct value. > >> > > >> >You are wrong. > >> > >> You mean the my value is wrong or my understanding is wrong? > > > >Yes. > > I don't get it. > > Would you mind sharing some light on what 240 bytes stands for? I don't figure > out what size it represents. You first. How did you determine the new value you used?