From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F8DC3DA60 for ; Thu, 18 Jul 2024 07:06:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7967B6B0082; Thu, 18 Jul 2024 03:06:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71F1C6B0088; Thu, 18 Jul 2024 03:06:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 572336B0089; Thu, 18 Jul 2024 03:06:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2FE296B0082 for ; Thu, 18 Jul 2024 03:06:01 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6BA9120DAC for ; Thu, 18 Jul 2024 07:06:00 +0000 (UTC) X-FDA: 82351988880.13.394EC65 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 17C2116001F for ; Thu, 18 Jul 2024 07:05:58 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kUgbLYcY; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721286305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGxGySgqceX8/BJRxeq5Jh3A2B83O0m5InfJDkWEt/Q=; b=OzWWULS+4apvJo6GPOlQ+OAWldM4LsLlXQeQffUpF5RAgM3A7AGelmRgyHOcSKHYNfXDK7 gR5Swd8yDYOgLYlaKeC1KuCHlDpj4HpS88ntAteIc/ef6ob+OnDqC5F0X6l+qXuOi9FdIU 39U4n/qMteAhtlftJx+Msnzk4P57Nmw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kUgbLYcY; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721286305; a=rsa-sha256; cv=none; b=tpcNG4DZr79wrlRsrRm6rIVH28EY6OejjHYmid4xJ1kNWjzGw4mlz8BBwyv5wPmcrRbjxe KFmngWNk3eoxsLyqSGNyOgN5lUXZnvNiGsFrtdDD+jgkmlQqWdiFt9cd1e4uva8aJ6GEnL ypbu8zqy7Klqc2D62KAskSHaduxHicQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0DBCD619FF; Thu, 18 Jul 2024 07:05:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD529C116B1; Thu, 18 Jul 2024 07:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721286357; bh=whHsob4RS5v2GdrWHkkMKcRLrbELb7YOdJDyppVzr6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kUgbLYcYkFi+yM5DNGWYkc6mZnNnUffrZs2ftic6RoJlQJ7E8d8XWB5uF1VxaloMN 2pI7IBqElMjV0qmk4el5sVZlUVx1UwdD/P/sQY2CWDd738D2psQymoIvRySGsgmXuk ZUck602iq5YkHci1Vyu9rFtlsvRJpdSEkMm+v+2VIQWc/AzrdgqrSUiCL4vEDXKVee 8A9PZCK5pqB7fQmK9zQfZYL2C8lRMzESmGfyxSOLFBGVMQZpNwRh+NK+wlWHkdZfdM jaUarx/bIXxsaGX38yt2XwW4s4VTuawsNrk9K8J+JTbrZLoL9aVyqQB8FzZnTP9IQn +gP4pgv5FiIEw== Date: Thu, 18 Jul 2024 10:02:52 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Cameron , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code Message-ID: References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-6-rppt@kernel.org> <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 17C2116001F X-Stat-Signature: 8ncy6ka5psn6twt7749bsc69fd1aomu4 X-Rspam-User: X-HE-Tag: 1721286358-983701 X-HE-Meta: U2FsdGVkX19c0y1G7BOSy4iIBi3ihlETzgdxe10wBAhTbUwl7oddzhLlYzL9JIiZVlwk6Tx4BORo2uif3E6MlxE7+jsyUP80ihSJNGhKRGdtPAfMnPT6JZMzUXg4nkiBdBj6arhDsxXBf5M+ofGvJ9MC5jtD4k0Tl73UX/Ht+YcmWVXTnNs8LzbTGP3ra7THdMrwviB0vmyyh0USSTFwCUZbpR0EiYipu04LUdEngNXQ6kDKT8F9jAzd/ZmtxV01vwFTgYwhI7c0GE2AqnLHdBJ9p3Z69AGgiggq1vrpM0G5gfcS6+H3Qgbp9O0sjhnmvQ+4OoeQ19yfWrYXOysL0pz0qfZu0cNZWRYWCR5SnQn4t9pkZfyacNrA2Dn401fLrpE85tQ44dA1XOBWlBKVQ2os1gO206QMPsVb10vh2y86xIZ8lWxFdFgj8RhBjBwLNkpRreS/2JZKUMRliN+Q/EkkBVX0hYTajoTLOqfwX5xqdqQqU7dlSPD4/Xq4WGqWHpO1ypIsQYyTPCSKQof3LPfOQckDn2Vn+6Z+mGgyv5KG2ZgwYanYtewpm5f+HrfKrVpl54re4JoIRgJawZYDuwCPc3W8FmI9+K7B9PEatq7UXW2H6R7LJkYnbbepeAFn9+oBhlrlHarYf4wVuTQqaMnlB3zNm9CXVa2L0TrPaDJ61Xq5Xacxu7EeKf0IOfOPs7zlewLKYOgquBTvyL855mf9ED53BmxlL8DIv80HQvSLKFJFWCxAggzbw+Aw4mDsN5O2snTKk3x8tWNOIjhoERSRfHE6ERZiVMuN3cHbw+gqYUegB+mvzhlCnnw2OxPjeDkbY3uGSYdKbmBpGdwTSGgIXu2jvFdCDch8jLoemGaPv7dQ4rOiYPn9QwDLt7Af9rg6b5GQwCGzOmckWmtkLoOds1SiIgtEjcMPIE2vNBgV49LqIAK6nC1qkgqUvwo0ug9viu3LbtzBQZJhmkH yvmOe79z fD/tJ8TC335/TV61yLpmNEVJmhp9GkUSHjebgCCHttC7PopC1ky0i7ghK5lw3MFssMWJXhlusXMoLJdlpUH9Fbe8qmjX5zmWvEdeOLhN1Pw+uYwA6byzjzPzFaNASu1AC+tNIiOImTUh8uzQeCpyNcmmPBYfCLsZoUSxhN3S+tYVa42IrwGS3GwnNzWqeVtm/JywYbLZOLUWoI3iXfIvO5hFphKyAz50hSh1QEMOiHUTfKw00eiEa/Vkkar31x14DM9EjBri4usVAP17VOiQFoD2SMaI0zKp5dFLyX7u77nz9s01IOLOwGvbDAI5vtQ6YIr/oMT5qOQqI6pQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 04:42:48PM +0200, David Hildenbrand wrote: > On 16.07.24 13:13, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > Architectures that support NUMA duplicate the code that allocates > > NODE_DATA on the node-local memory with slight variations in reporting > > of the addresses where the memory was allocated. > > > > Use x86 version as the basis for the generic alloc_node_data() function > > and call this function in architecture specific numa initialization. > > > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > [...] > > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > index 9208eaadf690..909f6cec3a26 100644 > > --- a/arch/mips/loongson64/numa.c > > +++ b/arch/mips/loongson64/numa.c > > @@ -81,12 +81,8 @@ static void __init init_topology_matrix(void) > > static void __init node_mem_init(unsigned int node) > > { > > - struct pglist_data *nd; > > unsigned long node_addrspace_offset; > > unsigned long start_pfn, end_pfn; > > - unsigned long nd_pa; > > - int tnid; > > - const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); > > One interesting change is that we now always round up to full pages on > architectures where we previously rounded up to SMP_CACHE_BYTES. On my workstation struct pglist_data take 174400, cachelines: 2725, members: 43 */ > I assume we don't really expect a significant growth in memory consumption > that we care about, especially because most systems with many nodes also > have quite some memory around. With Debian kernel configuration for 6.5 struct pglist data takes 174400 bytes so the increase here is below 1%. For NUMA systems with a lot of nodes that shouldn't be a problem. > > -/* Allocate NODE_DATA for a node on the local memory */ > > -static void __init alloc_node_data(int nid) > > -{ > > - const size_t nd_size = roundup(sizeof(pg_data_t), PAGE_SIZE); > > - u64 nd_pa; > > - void *nd; > > - int tnid; > > - > > - /* > > - * Allocate node data. Try node-local memory and then any node. > > - * Never allocate in DMA zone. > > - */ > > - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > > - if (!nd_pa) { > > - pr_err("Cannot find %zu bytes in any node (initial node: %d)\n", > > - nd_size, nid); > > - return; > > - } > > - nd = __va(nd_pa); > > - > > - /* report and initialize */ > > - printk(KERN_INFO "NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, > > - nd_pa, nd_pa + nd_size - 1); > > - tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); > > - if (tnid != nid) > > - printk(KERN_INFO " NODE_DATA(%d) on node %d\n", nid, tnid); > > - > > - node_data[nid] = nd; > > - memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); > > - > > - node_set_online(nid); > > -} > > - > > /** > > * numa_cleanup_meminfo - Cleanup a numa_meminfo > > * @mi: numa_meminfo to clean up > > @@ -571,6 +538,7 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) > > continue; > > alloc_node_data(nid); > > + node_set_online(nid); > > } > > I can spot that we only remove a single node_set_online() call from x86. > > What about all the other architectures? Will there be any change in behavior > for them? Or do we simply set the nodes online later once more? On x86 node_set_online() was a part of alloc_node_data() and I moved it outside so it's called right after alloc_node_data(). On other architectures the allocation didn't include that call, so there should be no difference there. > -- > Cheers, > > David / dhildenb > > -- Sincerely yours, Mike.