From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9B9C3DA5D for ; Fri, 19 Jul 2024 15:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42C4D6B0082; Fri, 19 Jul 2024 11:38:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 403916B008C; Fri, 19 Jul 2024 11:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CADE6B0095; Fri, 19 Jul 2024 11:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0F25A6B0082 for ; Fri, 19 Jul 2024 11:38:03 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B13AEC07BC for ; Fri, 19 Jul 2024 15:38:02 +0000 (UTC) X-FDA: 82356908004.24.7B93C12 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id DCF6580004 for ; Fri, 19 Jul 2024 15:38:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DlreXkvj; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721403438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rLXFuFSqi4SzoJL76+8x4E4QRjI/lKIK3VAgs8/sngE=; b=yd2fGVoaumAyVUqogsc7eZQ4NvnIfyFmqEaJehhL/xkqQgICmIJBk4swhxWTOtODEkhHgf svos9huS2gJNoRQxVZYl6kN4NhHM12rdWVem1Nl+pIA7Fp+cBXDLeNcGkU57q4AKS6GsDb LJkQ/Jn8Fho+lxEfDd0rgnJ6kBGbhko= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721403438; a=rsa-sha256; cv=none; b=Ws6+XY+y+yyR6tkhtFzD/ZxHKLLKHnHjhrU9Cfd3Jgc4EDYYZym26dRKqvJxBpJEUhjDpE von7NifqLhr0IIR9SrLnm4s41ynckpP+yLlrvcEK1Iv/L7fkrqGS4tpiBkcPMgVoKluP9v HIy3m8vrS47ww0FNyBEKzOqF4V/n7UA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DlreXkvj; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B1D3961C55; Fri, 19 Jul 2024 15:37:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A13C5C32782; Fri, 19 Jul 2024 15:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721403479; bh=tVgNxMmAQWvU1FxBOgdFor7NMUPhhxY2uJhGjcWiisk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DlreXkvjsjdzHII3wrHEJX7xIvJtPh9sNl+PiEO4zziJHXT5L7qnqPt0W8Df87Z3f 68krH52A7kA5g1aa2XJv0roBndIEDg+cY8XsA+iWOIUm0CIjdZSUm1/AIR5wTZqSFF ZPu7x311PvUpqpHwS7LKafCeg27rQek1LBnjCMCamVxdVjcv8NtScBCUdOQzaiCEoR BqTsYabPbb92QT7cEQlh1F4nxwrHD6TrQWmcHk+zGXys8vhSWoRgXRyJExhg3qYStE 9kFSfb2sX7fKVVh0sACIwo3xjKCXDs62FfEmcrj+oNSNOGhNW1e1gj4yvau1AjZlG4 IOqx+qPRg9jcQ== Date: Fri, 19 Jul 2024 18:34:54 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Cameron , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code Message-ID: References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-6-rppt@kernel.org> <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> <96850252-a49f-4d78-a94b-a9a25e3f2bd5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96850252-a49f-4d78-a94b-a9a25e3f2bd5@redhat.com> X-Stat-Signature: tq9p9nmur3u537aswmy9rpn9fht73wb4 X-Rspamd-Queue-Id: DCF6580004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721403480-190166 X-HE-Meta: U2FsdGVkX1+88jaglUYgfRkcF0MhvVOVFGAsi+wVvAoOZiY6xCdHEcjCLVDKnvlMEfbO4Z30eWw+5KdjTJGk9SX+t7sM+xEw87BwyU4WA6gI5sdT+TLn9FPKovNGD5e1jmBuhRGEp6JCwTRk9SouoUNh9eajtglYYjuyFTYvPvbsnxe1xRTUHe8g8DLgOS+E2t90fXv23AWXCgl1ls3esGli8twqUIOp+T5ElsmZyQBL45SE3oF3EgHAfuVQmZKIGa+hXlvZU7lwZDAAsU9hExmRdseXK/Ec1v58m702C1txtibV+QhGJjdPkib8/4wsxKgAOQ0SfKfOy602iFNI/R7wimchSReqkxanptbU9G12Lg+6W1GDhV2EcDuwgmu0lsfTYFdvKY9uQNfxH495X6aCObFTsjy8dSdcBaOsEOq7i8YrCQKfstY6smhMQRbfmSx9U/ERZSGqRZ8GBAqMu+etvuFJnGm59Ub6LWOQIkJy2+dXTB8GQGOt31+pixBN4uVdMnqE3hmKrEONRLgiYH5TX7gcFWDuDVrXUqj+3G0czzBs+hgC4AdcRaHctDBgAjbwe+3zfwev1n9rVlwWLe2Itfbx5mrNQL6gdpgl0h62hgz7xa8k8oonq4DMsbEKWbpy6CgXUhuwTvBNrzVzkN6m0WxPTc2hmp1Qq6pO1sd7GTvhcXpm55nju2NtEujCOo93w10glUqdDVdSfOGRW9FOVGsw5P9J2cMxdhCTdFoP5RGIGcKWox5ji62A4t6+ha7l4dqESHjQAFXqdnvkUpCCj6PrwBHt+Ko3OWgEtolYjprLaxdjAlEXG3uHAg+VmokmJZVAlf1vFy31y0zFn4LgNYndXpvq1Q6tpOzERnDOEDuzjp2UmwJw8jRhp1o0BONZ4wzH1Bnevv/KsFDNlYxqnQfFx+ycSvHaUI7pDPzYNv8JN+QXIfdd0xEQ5GtKb9MPU9boen8dsy+4foy ti2GSi9+ H95MWWCNrNl22nrghvYHGrMAHZACCMqPgDm4Q3GwvSbtHtKrk7P8AA8FMwiSQ17vkn9i5Ej3/W3vZ8M31/GoMY6hfP2qG5kkL+a9e4RDDvtfSfYhvCCdc4kOzDybuNRd9omz9DGpOu0UwJfdfFttlX7lP4InXWi1zXBy4BlgjgvMdQ289YEkEdoiGi83IcxBUDCuQAhVd7g5Wxmnw7T2r3vK5TGkrGG0CT2y1dJ7we0H8egqTkAFdpvuvOtFz2Uead/SffWkGdwCFhPDs1izvwSfk1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 05:07:35PM +0200, David Hildenbrand wrote: > > > > - * Allocate node data. Try node-local memory and then any node. > > > > - * Never allocate in DMA zone. > > > > - */ > > > > - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > > > > - if (!nd_pa) { > > > > - pr_err("Cannot find %zu bytes in any node (initial node: %d)\n", > > > > - nd_size, nid); > > > > - return; > > > > - } > > > > - nd = __va(nd_pa); > > > > - > > > > - /* report and initialize */ > > > > - printk(KERN_INFO "NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, > > > > - nd_pa, nd_pa + nd_size - 1); > > > > - tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); > > > > - if (tnid != nid) > > > > - printk(KERN_INFO " NODE_DATA(%d) on node %d\n", nid, tnid); > > > > - > > > > - node_data[nid] = nd; > > > > - memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); > > > > - > > > > - node_set_online(nid); > > > > -} > > > > - > > > > /** > > > > * numa_cleanup_meminfo - Cleanup a numa_meminfo > > > > * @mi: numa_meminfo to clean up > > > > @@ -571,6 +538,7 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) > > > > continue; > > > > alloc_node_data(nid); > > > > + node_set_online(nid); > > > > } > > > > > > I can spot that we only remove a single node_set_online() call from x86. > > > > > > What about all the other architectures? Will there be any change in behavior > > > for them? Or do we simply set the nodes online later once more? > > > > On x86 node_set_online() was a part of alloc_node_data() and I moved it > > outside so it's called right after alloc_node_data(). On other > > architectures the allocation didn't include that call, so there should be > > no difference there. > > But won't their arch code try setting the nodes online at a later stage? > > And I think, some architectures only set nodes online conditionally > (see most other node_set_online() calls). > > Sorry if I'm confused here, but with now unconditional node_set_online(), won't > we change the behavior of other architectures? The generic alloc_node_data() does not set the node online: +/* Allocate NODE_DATA for a node on the local memory */ +void __init alloc_node_data(int nid) +{ + const size_t nd_size = roundup(sizeof(pg_data_t), PAGE_SIZE); + u64 nd_pa; + void *nd; + int tnid; + + /* Allocate node data. Try node-local memory and then any node. */ + nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); + if (!nd_pa) + panic("Cannot allocate %zu bytes for node %d data\n", + nd_size, nid); + nd = __va(nd_pa); + + /* report and initialize */ + pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, + nd_pa, nd_pa + nd_size - 1); + tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); + if (tnid != nid) + pr_info(" NODE_DATA(%d) on node %d\n", nid, tnid); + + node_data[nid] = nd; + memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); +} I might have missed some architecture except x86 that calls node_set_online() in its alloc_node_data(), but the intention was to leave that call outside the alloc and explicitly add it after the call to alloc_node_data() if needed like in x86. > -- > Cheers, > > David / dhildenb > > -- Sincerely yours, Mike.