From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39DDC3DA5D for ; Fri, 19 Jul 2024 17:14:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 167446B0083; Fri, 19 Jul 2024 13:14:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C9996B0088; Fri, 19 Jul 2024 13:14:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAB916B008C; Fri, 19 Jul 2024 13:14:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CB4136B0083 for ; Fri, 19 Jul 2024 13:14:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3D09740559 for ; Fri, 19 Jul 2024 17:14:27 +0000 (UTC) X-FDA: 82357150974.07.D8A8076 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf18.hostedemail.com (Postfix) with ESMTP id 7CD1B1C001F for ; Fri, 19 Jul 2024 17:14:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xWNjI9oj; spf=pass (imf18.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721409232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=egmwmVsNFFcGbmO5tacperJARE+TcCGVGcK24AEGTAU=; b=eYmla2BhFQDcHQ/ifaFVGVi3jl2Dv10t9G8RMVp+TV3Y4E+GQI4v1XG3WbO/TLRGD26KcO Ah2UNnY6s52N2pq5iX7FF4yqChmUteT2SDVCLpv8rqVoT3pD9HnhF06DPRcd1+q7cu+y0H aRoN+r27wfgxOAf2Pir5+jYVfUhd+jY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xWNjI9oj; spf=pass (imf18.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721409232; a=rsa-sha256; cv=none; b=vK5Lp70w0xa+UaPGX5cr4yN4Rxr942lwWutCcfnnb76b5gfZo1nu6yUtXzthERfMpraejI wXHJ5uIcYboV56bLpKZQ5qyaM4n8jTrtkxsxl5ENqdu1mV8AoHzkTghe0EeVlalflsf2T7 fMN3m5jFwUddQonP2VjjyKTSlKCTwB8= X-Envelope-To: oliver.sang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721409261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=egmwmVsNFFcGbmO5tacperJARE+TcCGVGcK24AEGTAU=; b=xWNjI9ojEHouTgxIsAiA0MEGVrJzRyHPL2fd29qfE7B8duTglwa8hajluUCXqRMVqJRMFy DLZFqH3LWoNchuQFl2Dt5jzV3+JbcZJioVKLPElJ/8YAo3PnFqJUh+JvFUqngGyLcX9rmG rDa0nVogSnkQk7lvNEb8gz1tvcipKDc= X-Envelope-To: oe-lkp@lists.linux.dev X-Envelope-To: lkp@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: ying.huang@intel.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: fengwei.yin@intel.com Date: Fri, 19 Jul 2024 17:14:16 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [mm] 98c9daf5ae: aim7.jobs-per-min -29.4% regression Message-ID: References: <202407121335.31a10cb6-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: ryzkyxt4eezd6g6d6aknqibe5brhqhyr X-Rspam-User: X-Rspamd-Queue-Id: 7CD1B1C001F X-Rspamd-Server: rspam02 X-HE-Tag: 1721409264-367057 X-HE-Meta: U2FsdGVkX1/8Mbhem3qDpwcxxEA48+yQl8FWrUjjodjoA9SvlAPDMHtVh+HY7ywDUkzXgVbKcZjKM6ac3oaggsdWBmls4K/asZHDtbnOPHTRuXWrRHBStiHt6w+o00HlRdc7aD/OCkEAi1aU73ryteZqyCFVEmqD8AW1D76Hh1fPdGEwzBPEoltqEhNSAwM+iV2ve4piyP/+zZ6X8gBzafwuUWWQy2vp19k53/Y4BoaLE5ipRYBBrLHxRRUZYfhD0CbWizFhBCSxKjjdoXvn/vqtpGKryAsX45Vidg2GK+qBhDAO2Y+Dt2r6okpiP6sQFhn5YvH/6QCZxLkghMmTjOU1jMaygV0jhl/uyaay3qaGR1EncV39kDI1z0VP0X2WWKmT2HvzL1b4AlgMWsV4vkM0rgFAFJiul8Zdvo3H/7xUW6I95vJ59/hTFJ4Q/wPbz3VhM1sqz+0dm7IRvUcEk0+YblQiG0ZmEhcfWdFtUUfc9D6jpxTcBxSRHqAiOE3HcthOIIxBkFA5gPlsFVHcVQzO4fjFC926fJR/0HDaxY9rC2W1uiKjBZEQu/4zyTp0qDVzU2sF9ixFQPCwxJM6z4pHTAozSR1TR/fyl5lyqGZJIIsX0SJoGLnqW/YxdycFGGlxdoVfnyAxlsPgRF0ZFkyT+/XNTBznaemRewKpLvrfsJecjoauoDnMJde02f2uNqk7/KPi18wmD/oBWrYlYiA3LYWRRJcHoftEeTdgljnl0CzaDftQ0Wf7GyzKu4JMU9fie8OKPCWcSrFxXURHlJWzVCM9RQl8J8CPQxSHb9gXfJ+UpxpPpRVE3kZDmqza273AjqBCG8Vc4L38o7KVwr1RxpxJyNQMETGo4BkBA4uHNrQdYiO6ko6+vLUVgoShFibXf0lUrDew6rWHZf0lqhroiFD5g5uzfSoy2XEntU59ks1KGBJ3rSMA+4AQOPnRCxnu7JDi3XEzKD9532P jhNn7o9e 3tulK7fCrEKEe9npdRdfKGnKASkQE5/zgvAD4SAvibaPYI2F1iEvXF7+gtCvO7ozYhMU6a6UNnz27FljX34xolG8A8nAo2dyyBxiyuNIEqm74bpkiq5sHGx3qCJeD35xGK/q7EqpzJlMCs8NhTTdIa3N/5gRo7EYY4ZIQVGvZSxZaM7mDZRvHA/VhvB03L0b2Oidw28qD60Kgp9bbMIPQmfr19A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 03:53:25PM +0800, Oliver Sang wrote: > hi, Roman, > > On Mon, Jul 15, 2024 at 10:18:39PM +0000, Roman Gushchin wrote: > > On Mon, Jul 15, 2024 at 10:14:31PM +0800, Oliver Sang wrote: > > > hi, Roman Gushchin, > > > > > > On Fri, Jul 12, 2024 at 07:03:31PM +0000, Roman Gushchin wrote: > > > > On Fri, Jul 12, 2024 at 02:04:48PM +0800, kernel test robot wrote: > > > > > > > > > > > > > > > Hello, > > > > > > > > > > kernel test robot noticed a -29.4% regression of aim7.jobs-per-min on: > > > > > > > > > > > > > > > commit: 98c9daf5ae6be008f78c07b744bcff7bcc6e98da ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node") > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > > > > > Hello, > > > > > > > > thank you for the report! > > > > > > > > I'd expect that the regression should be fixed by the commit > > > > "mm: memcg: add cache line padding to mem_cgroup_per_node". > > > > > > > > Can you, please, confirm that it's not the case? > > > > > > > > Thank you! > > > > > > in our this aim7 test, we found the performance partially recovered by > > > "mm: memcg: add cache line padding to mem_cgroup_per_node" but not fully > > > > Thank you for providing the detailed information! > > > > Can you, please, check if the following patch resolves the regression entirely? > > no. in our tests, the following patch has little impact. > I directly apply it upon 6df13230b6 (if this is not the proper applyment, please > let me know, thanks) Hm, interesting. And thank you for the confirmation, you did everything correct. Because the only thing the original patch did was a removal of few fields from the mem_cgroup_per_node struct, there are not many options left here. Would you mind to try the following patch? Thank you and really appreciate your help! diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 7e2eb091049a..0e5bf25d324f 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -109,6 +109,7 @@ struct mem_cgroup_per_node { /* Fields which get updated often at the end. */ struct lruvec lruvec; + CACHELINE_PADDING(_pad2_); unsigned long lru_zone_size[MAX_NR_ZONES][NR_LRU_LISTS]; struct mem_cgroup_reclaim_iter iter; };