From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F389AC3DA59 for ; Sat, 20 Jul 2024 10:27:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE3ED6B0082; Sat, 20 Jul 2024 06:27:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E93216B0085; Sat, 20 Jul 2024 06:27:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A996B0088; Sat, 20 Jul 2024 06:27:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B65CD6B0082 for ; Sat, 20 Jul 2024 06:27:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EF374A0BED for ; Sat, 20 Jul 2024 10:27:22 +0000 (UTC) X-FDA: 82359753924.06.FC02856 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id B8EF380004 for ; Sat, 20 Jul 2024 10:27:20 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OSOw1h0I; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721471184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6LVNgyUOfntuQ76/+CPVdBaZYC8lKbCrRnUZYEUmg4g=; b=HSMECmGIwunhn3j+4fS26YshKCs1WVsB6c1h3rm/SK0sibJ3KZQS8lpq2EVSfk1hpIPpdw dmDckTA2zA9k+dLx0kQGuqrXOOYo98A8u7tkZrLUQ3T4eI1hRsX50ixHxbYz2qQwF4DtEW w2eHox1F/z8wxeTzIGLjF8IPA7KBkQ4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OSOw1h0I; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721471184; a=rsa-sha256; cv=none; b=W/xsxvRAMSFfBLo+iLF0AXogsE3ly6a9Xmt1IDADba6KQ8n6WPv4RgCO/SQkRVMXlcngC+ ToDK4cMchFPqTeAJX6aRwFbvp1yO7m+jKQiAanhPy13E0LFixR9y5xaMpc8/Xe7+J/KKXH jCLXEUnQOUQLHD8D6BVm1Oe/4c/Nel8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 423DFCE021C; Sat, 20 Jul 2024 10:27:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F39A7C2BD10; Sat, 20 Jul 2024 10:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721471235; bh=dVNVV+LbgZSpehO8np8DsTOCzJGiWq4UJOrsJg2zgCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OSOw1h0Ig/Sxo42NZVxgWqDg7PApDQPKQu7IqHtWulHzO5DZIoZUQKCkyr/Imoxko Lntuo9YYc0lQcsGc+PRntWL+4q6xGqYrJQGqSwrQ2zZ1CtZ6MvlYyVAEJlaBtunrNO F2DuSLx1QB9fjEK101QysRMhcJp+/gGJQsWj4+tgA87UM1Qqi7MiDFaIy33Yfgv/7x VV0gk0bbejGKCDskyj6Yq3aWY4qrq3jL+EZ+nUCUWS3c3DH2vL/WRIeqbcd+hCBosA QTOgUg+IY8NEEcUIVy6GfU3iS+hehOwAyUj7zAH7+pI+6MP+NYXBi6cf1MEyU9Ri4P as0dGwXRHcDEg== Date: Sat, 20 Jul 2024 13:24:06 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Cameron , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code Message-ID: References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-6-rppt@kernel.org> <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B8EF380004 X-Stat-Signature: 58u4istofcipcz4skc6sezh87p7djkng X-Rspam-User: X-HE-Tag: 1721471240-333293 X-HE-Meta: U2FsdGVkX19uGK/OSwkK5e09RD/zf1qtkTxWwZB0LnkmtZX44BwM+LB6VpgLhJ4XMp13kAbOXkb082bHM4FytQzvIBW54AVXGQN/jR9s7s+S2zOPsdC1QWuMqIawsVeow3MJW5da5aEhgjbltNWa0uOt42EHtdnptcA5sG1vj/DL7ZXzEd+6HQvNniNTM1Vn8hm4dQL5EhdC+HOnXJWK/gPOMP+AqerrhNcZzzcyvr0vJ8dG9sArs8rpzzOeAGJRIXS3iV0FL19+HJb9FG49Wi/tj/+Bpnl81EX5m/KJSvkcqjdPQOTwHwz4jdMxfJs2tz+jXY/rnwxPr7SLkTG9cS9FyHNEuNqmdRB7TRQeBe9L2n2PhLipmrtjl1BoLULW/aCjflCRyyplay4AJpnOCe2GtcjeYjbY9Vczmd6kUmYJFBd/rDeOEQf18Av9GB/HHoBEkqXIA8jE300L9iW1LFeQCNpIB2kfC43m6JOXjDRJydJbdegVD1glR55yEsog8yDGdgaLzlVRaQX1vxEvkON/H5/HgoB0jxI6XxB8ikxLQZumQk79/xuq3H8XhLHyItmLwewOyvFGKywBngnmyhv6i9Ij+2fJ8GqamGiiwKtqJu+NAPp3sGCznjPRrn75LustMaiJ8gEY8VcUEt7ZK08AhwwpJStJyq4a0Q3/IUJd06MlHdgnMfpHjSlxsAEEZXQCPXt9jSm4Jk6vRlyp5+0huoZcOZxwh7a1sg+Llg4NSZlT5ciewvjo9JAGe5f3HCpqZyJCzxnn0Ek7JOGN5c/P1K+F3H4U+XAQw36a85qHEHV6v9XTKeUBLfceJbcqfQ4VJ+3f1uRJfIgXmuz6gv2elyzO5CX81pXMYr/q/MYk0NupYqJLehR6oCIdcI0Up/gulP/otF74c6CvxuypQzxoT8rvKoDTYMlvc6v6VJUplV2mVQO/up54FSgYnaHSBCECqq6vqWMll4vLR4x d3Cd3aPx o558tU6xwHoTX8AjgKz3zmNVJUusFtn9bxkcQnWfyPdUI077qlBpMQdoPskCPBtIgsbxIDZlW7kN58uIXmmd7p4Fb//72Cdtkf9D0cgondgeAPmm+t6yButgQNM7hdgg4KhAfSwHKbZ4GHy62oOnIq523WWVrgSUtxR4YeeFj/F16hW61Nk5el2Ar56y7s/l5N8Uaf0vWtbvmQ8fV9S9yzdU+kQKkVnA6GRzsZfDOKkiyaeiLefborA2e2H6ZWFqvgypJYB7P2Vug8DBImIR9rfNloHRaKrM5GfKDeskHfCcYELEnoqiwn7iUdHs2y0nPKwxvJ/FwdhzvhDk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 04:42:48PM +0200, David Hildenbrand wrote: > On 16.07.24 13:13, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > Architectures that support NUMA duplicate the code that allocates > > NODE_DATA on the node-local memory with slight variations in reporting > > of the addresses where the memory was allocated. > > > > Use x86 version as the basis for the generic alloc_node_data() function > > and call this function in architecture specific numa initialization. > > > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > [...] > > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > index 9208eaadf690..909f6cec3a26 100644 > > --- a/arch/mips/loongson64/numa.c > > +++ b/arch/mips/loongson64/numa.c > > @@ -81,12 +81,8 @@ static void __init init_topology_matrix(void) > > static void __init node_mem_init(unsigned int node) > > { > > - struct pglist_data *nd; > > unsigned long node_addrspace_offset; > > unsigned long start_pfn, end_pfn; > > - unsigned long nd_pa; > > - int tnid; > > - const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); > > One interesting change is that we now always round up to full pages on > architectures where we previously rounded up to SMP_CACHE_BYTES. I did some git archaeology and it seems that round up to full pages on x86 backdates to bootmem era when allocation granularity was PAGE_SIZE anyway. I'm going to change that to SMP_CACHE_BYTES in v2. > I assume we don't really expect a significant growth in memory consumption > that we care about, especially because most systems with many nodes also > have quite some memory around. -- Sincerely yours, Mike.