From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8629BC3DA49 for ; Sat, 20 Jul 2024 12:28:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEF356B0082; Sat, 20 Jul 2024 08:28:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D78746B0085; Sat, 20 Jul 2024 08:28:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF3006B0088; Sat, 20 Jul 2024 08:28:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 96DBF6B0082 for ; Sat, 20 Jul 2024 08:28:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1601CA4298 for ; Sat, 20 Jul 2024 12:28:32 +0000 (UTC) X-FDA: 82360059264.15.4FD96CD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 0B5F020010 for ; Sat, 20 Jul 2024 12:28:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KXNTwVKG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721478478; a=rsa-sha256; cv=none; b=Hfb4fAdBRtlazjEcY43jqZzs4kaUyPPYQX+Yx1oJcTykbqQB+8GDhCoETMzB6GMfAAUb7X 4MNwO3AS06UravNtEfVMg/b4Rv0AQf7OntgJQjIL5pR01KYerejSynQA/jFJeg7IihZ70j kBXMOWahoOQ6BQg0TPVbwY9mfQzmJek= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KXNTwVKG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721478478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lWgQgUrOaYIOd2E2ehGQmLE3fEe2UTFsr2RMSIINL94=; b=cIHI1YcP35iQtVA2yKCygRvyXiytrwNaKhSPB05WTf+2dQ+6abIY6ffaOY76iGbyOk94Nt lH9G1E08DO+m1CSxQio17pLhjh2L25Dmn4pxXUuETAWmQRFOFkmhAE+5HHFfBVKW45xuJu /Gou0ZWVt1EYHnomxVqJMz8b+dqPllA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EDFC9CE01C5; Sat, 20 Jul 2024 12:28:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4F9FC2BD10; Sat, 20 Jul 2024 12:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721478503; bh=/mmf7KEQ2fPqMset/cgfJzrTW1VPxx9MyxonZ+AyPQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KXNTwVKG4a4xYLw48OLtatEkRdqIGu8Mf+G1aUXiTTPTpT78IYUQ1/wzw0qcFGQoR EepLZpsfpjbXKbh/xfZLM3pDZgCx3YVNfQ8PYWZH73ncdrVoIJ9MY6uDPyRIVyQIRs +mD0V5quwhKhuRIUn7YWWcUOTpwaW7OpiJS6ob2EzbfT+pcMNhHQp3Wq1wCk5+tueN cPKdYI9XDCq7cwRj9VCCE2OjNxFU7Ln9GS8efdMPhwguntvnlAzgrDRV9PZkgruXop kgltilDaq6nb/4rY0NbgAzNLz0ekUP2swIpCx5HMEf1sL/wDuc2020z2LPpHNdvHa/ VhAS6LNc+rmag== Date: Sat, 20 Jul 2024 15:25:15 +0300 From: Mike Rapoport To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 13/17] mm: move numa_distance and related code from x86 to numa_memblks Message-ID: References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-14-rppt@kernel.org> <20240719184842.000030bc@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719184842.000030bc@Huawei.com> X-Rspamd-Queue-Id: 0B5F020010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: b71ikp9zaazxa8pin33ks8ou6agdsegt X-HE-Tag: 1721478509-125623 X-HE-Meta: U2FsdGVkX18vvJabEDGexnRH1476Dty6nWZOfLZLGtAfHpAz+G3xiyx+OAeKcGTtLAeK6AE4wakFDwqmqmXVQB02xPr6rb0epjVOKe8S3V7xlDsAsNNxOiVLfOYoHNb4Wb0iheVOdBYcIRuyXLr2DbEBaU25wzSIQRbj9zdzIOtFwq6rO7Pn4QvpmqUody6f3/xJmKvkmLqh6ok5eNjHoPlu7M/L6G+bSTCFPJ9NuIfLvUfUFHHjkRnJoUXaMAc+CUea4D3x5dO+p0AI56JXe+upJFAKWzgy2M7Zlf4aRiQxCg0H5lDbyA1hvKH4x3QntLMcid/tANR/ik0XUx2Z0NMIu5xtWgAoGja26unPVRb40mHUam/91bdNpS7L4ABM5LP+skCqXblB9SPDeOGLI1Onpdoc5xTdo1VwZeITj9bk0v+ruGUaPRwV92pRXKqVIGDZzqwXMwHtqZ5F26EM24BtUyhbzvYrlfM/R/PVMekM8XbyLFzmfp/4xiYIdZz5UHSqBOioV9Nhlv9DTIuMH8ybkf+4OIwZv/1yI4b62h6G5xLRMuQb3A6tMgWr0ei/qLsFOiz2PEXdnsYay1wL3n/L4RIrFuPFHFqeflFxLv7xsxVM6FuFBc9VcDmRCj3xcox8h4BmqkW/syRE/v1gYwBCT3hEqSC+REJbFGRKeM6JDpMOaZB6Zn1qrMWJ00CLfk+LkCmStPWT3RPvMHu53A6J9NkepleLxejln3G451GWG2uUxodR3Vcu9b7g719xZyvr8RkXFLkD6dAxNhHoexF9A96GOUYyLdv/fo6NQA6lVwu91BKVLLD08tA5BCBTBcKNYRbVGNiLDRYxiVWYs3JRUNFXgIgA4JN2TXnG+9p4aOg807lMhjJEE+umBZrigDSDHSvVi11YMviTyWJ47AKzLVQwGzfdsDZmHCbWLJKnJhRLtq8y4qe3LrBZZ6U2pC8OmsqGWWH5Y8R1WMO iJZ0OFJy zXX5o2nCsfGsZx2AhXGkwlixQ5KmECX8z8tuokcU9SOw6DU6iRhLNAusyzGdGqoKXN4KCCzU2ox3Kd8r8GSWpktyF8P6/s4iqjQmbRmOuYSRoUC+B19vOsjlIa5RCDzis89Mp5KjYFKAa+x3N+yBYOAsorRTP9as78pLBQE58rd+DznllmTmG+7Ia2YnG/QPszfUg1JtuhJIRwqPmvAbTGZZ9rOrjvJGGIZnwV4P7SKW226HEf52A/FeXhQsBPBzoEUFB/rOnT0wRSAJ3vZ3PxkOWoNBpbIma2mVE2CwOEOEzkeuD5CRfBY7DVbkxSsOMrDk4H4wz7QwG/CA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 06:48:42PM +0100, Jonathan Cameron wrote: > On Tue, 16 Jul 2024 14:13:42 +0300 > Mike Rapoport wrote: > > > From: "Mike Rapoport (Microsoft)" > > > > Move code dealing with numa_distance array from arch/x86 to > > mm/numa_memblks.c > > It's not really numa memblock related. Is this the best place > to put it? There is a dependency of numa_alloc_distance() on numa_nodemask_from_meminfo() that relies on numa_memblk but I agree that they are not really related. However, I'd prefer to keep this code in mm/numa_memblks.c because node_distance() definitions and related code are different between architecures and having this code outside numa_memblks in e.g mm/numa.c would be way more involved. > > This code will be later reused by arch_numa. > > > > No functional changes. > > > > Signed-off-by: Mike Rapoport (Microsoft) > -- Sincerely yours, Mike.