From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A02C3DA7F for ; Sun, 4 Aug 2024 15:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F25C46B007B; Sun, 4 Aug 2024 11:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED5BF6B0082; Sun, 4 Aug 2024 11:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC47D6B0085; Sun, 4 Aug 2024 11:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BE92D6B007B for ; Sun, 4 Aug 2024 11:16:55 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5FA63161985 for ; Sun, 4 Aug 2024 15:16:55 +0000 (UTC) X-FDA: 82414915590.28.75F8689 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 1AC95180018 for ; Sun, 4 Aug 2024 15:16:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=srl0srfE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722784607; a=rsa-sha256; cv=none; b=ZVD5GNsRFMwIndMCONa+P6ooymbGp5d7pttAAANj++iSj1emMSvXuysRiWsRCgKTK+8Na9 XzlKB5GMuyIgHTEtGduPGpyiK+LCMqIxPsouvyfycWKJckh4fvYXDZmC/F6Tqt5gCEdsDu v7PItwIwOju1Kwg4oYGSE4pJbS6dxEg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=srl0srfE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722784607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PnW79RfNAVv79AdpqCfEJ/wyC9BR7r99TNXVSz8Xk8Q=; b=AvhIHVqzhL7GJL90U2+v/KiYGVqsAOBgKuAQ4MkKBl0oHsa7dUx9OXj0FVnx2GnGlPRzIj LsZD2phnQhe9QxCRp1pka+H0zYRLvjaxeT1t/DB5+spVakvUeTy4M9dgds6CPK7C+yEXcK eK0TCEl7XGYRpOJxi0oCkQoRcqOLeKU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9DCFDCE0917; Sun, 4 Aug 2024 15:16:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0708C32786; Sun, 4 Aug 2024 15:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722784609; bh=PbZnK4gedPAzrBqyHpMY0nfx8YVLLtIZRcC5H3Bjs1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=srl0srfEMJcvmRAqdIpwre+Yi3D6o4YrHiWRuL9HMSi+MuiYU3pMzcgeJ7JOyVUPi a7YJ0JVEftlsn46+su5RAYHi1Z0kZxi6vxakb/AjB8x9wBX6dl42AxcdD2mIHmmw7I tMnuHtaKEjP/Yh9n04vsrBbWgdiw3FNUqs+R+RSm8pPEvP2L90NnFnUQKL471ESl6y bWK/2YiidFSbeA05NSl2FQ0qWwOhHk3O5xvh1izP/Br+Nj74JzVYO+aAGsiSlQjdp/ QJSQJOUqV05g+5chIOQZlJL+8Od5tr8k9VrR4SLKkUAS8t8NJsLPKGo/qgaltFB+CU mUi5O0eQVly3A== Date: Sun, 4 Aug 2024 17:16:40 +0200 From: Danilo Krummrich To: Boqun Feng Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH v3 06/25] rust: alloc: implement `Vmalloc` allocator Message-ID: References: <20240801000641.1882-1-dakr@kernel.org> <20240801000641.1882-7-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1AC95180018 X-Rspamd-Server: rspam01 X-Stat-Signature: jqpxtyxgyifp4swu8wmgmgydcc7s7rha X-HE-Tag: 1722784612-208442 X-HE-Meta: U2FsdGVkX19Mr/abHWbZy3Tw1F0muK8sO9pEcTBcDnz2ovHZmTTUfmo7/6lIYqiZwm4xO2VSJhM44CDO64OqFNImmYvHixaUXBgO8ifxwqBxkU1aAmk1ErR8NQDIfrSdwj2z/EGfQJAua0rfqttaIw+zozZ9hmpc+MS8XEPBGQn4k/1Z3z02k/qwkamwYQADILkaHuxGb+VC/nYp21Vfx1O0gYsXgz+fku8CIxaRmqExHRuZVzT7LOQQbZekZN1e0E8xfwyaQrLP1fCNQylL1z+i2o8dUR979HQI8PKA1rFpkVylsdVJwj/hY1sUlBwQZ+W51vmib28oDDoMhiGBztWIiY1/o19gzd+97KyMSsI4fCWmWgyQPsASr8VlQ6v1RUqBJ1re2ZivrjLikMgjddncWJoyJgx489f006Z1CoULGzrfqPZqVnDLRbHsPuZ8ZfPIeMFuEbfA+HqLYdyhBnMV0RocZCTOkseuqvpjJ4cGRLJDYl5PGcyu6DtRrygLqO2qhUm3Tlnqk9aBI1DT5X9yPoyAkYnghWnqO/hlSCV6eJJI2qRzdv3ywLl43An0qxA8+x+VVHjW7T04ZBuCRqki9kbe/wmgczEM5GF97bPzLKLTF98+AlLf8v6slZOpsvUk2XrKsnGexBacmAEmygt1JSmZBycrz8iOxkoj5pAvH/31fjbMtwrcO4fq7FFq14b44GpRAGYj6epNway9h9ybfLZIAA8B/3PEVdOVe59sdoE6bE6pnmJj3iS45Z6kmFbZNt2KjmbSga02LF/ylIwalPEOjZoecblkcJvyq05CKgxWPkDLheT9wjLH0xnE1meCbjZN0RScJrvbPGEDJciiW2hJG6I24obXzosZtHA7TrhDh2NSv7SWph/v5l/KB3UHkl54mtLMJBliVCeI6Cwg0Ee+JXr4tP+HPw5kFE/LqR4PW4KxpHw+m68WH75tmmDu7wCgdedNVB6Jp5j 9kw/adAM rKMcdEKIxwfe+iV2qPL8wRzSVMHBdWWXVfuQRqPBWfZet9+yjl3fmfOH3NxBdQMWT8Eav4uYKlH+PwfjN40uuWZ8XPl8FL7bKM4XGYTAIffFdszpOYs7C86g7HNsQYKkleUC3ZAyZmPzVKC57huDHe21SWS0sn7obb7s8JB2eiHWweCy1LuPhlyPWU24l4Ftp8Q+XPKtz3rLCIWnzJTqzRuJPkVRbe0ejtMNukGd9IVPSYLwHMupFyl873tVbh0oMTpeFQAptsy/jY/RXNJmstIlNPb69QKNx5anSFF86T9MoVKnxZdVKAxxY3GHqqEt1gAmHPVNXzBW9ZPfeIT9jsmNrVmBoa7EIR7Ub X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 04, 2024 at 02:41:26PM +0200, Danilo Krummrich wrote: > On Sat, Aug 03, 2024 at 11:44:58PM -0700, Boqun Feng wrote: > > On Thu, Aug 01, 2024 at 02:02:05AM +0200, Danilo Krummrich wrote: > > > Implement `Allocator` for `Vmalloc`, the kernel's virtually contiguous > > > allocator, typically used for larger objects, (much) larger than page > > > size. > > > > > > All memory allocations made with `Vmalloc` end up in `vrealloc()`. > > > > > > Signed-off-by: Danilo Krummrich > > > --- > > > rust/helpers.c | 8 ++++++++ > > > rust/kernel/alloc/allocator.rs | 24 ++++++++++++++++++++++++ > > > rust/kernel/alloc/allocator_test.rs | 1 + > > > 3 files changed, 33 insertions(+) > > > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > > index 92d3c03ae1bd..4c628986f0c9 100644 > > > --- a/rust/helpers.c > > > +++ b/rust/helpers.c > > > @@ -33,6 +33,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > > > > @@ -200,6 +201,13 @@ rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > > } > > > EXPORT_SYMBOL_GPL(rust_helper_krealloc); > > > > > > +void * __must_check __realloc_size(2) > > > +rust_helper_vrealloc(const void *p, size_t size, gfp_t flags) > > > +{ > > > + return vrealloc(p, size, flags); > > > +} > > > +EXPORT_SYMBOL_GPL(rust_helper_vrealloc); > > > + > > > /* > > > * `bindgen` binds the C `size_t` type as the Rust `usize` type, so we can > > > * use it in contexts where Rust expects a `usize` like slice (array) indices. > > > diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator.rs > > > index 397ae5bcc043..e9a3d0694f41 100644 > > > --- a/rust/kernel/alloc/allocator.rs > > > +++ b/rust/kernel/alloc/allocator.rs > > > @@ -16,6 +16,12 @@ > > > /// `bindings::krealloc`. > > > pub struct Kmalloc; > > > > > > +/// The virtually contiguous kernel allocator. > > > +/// > > > +/// The vmalloc allocator allocates pages from the page level allocator and maps them into the > > > +/// contiguous kernel virtual space. > > > +pub struct Vmalloc; > > > + > > > /// Returns a proper size to alloc a new object aligned to `new_layout`'s alignment. > > > fn aligned_size(new_layout: Layout) -> usize { > > > // Customized layouts from `Layout::from_size_align()` can have size < align, so pad first. > > > @@ -58,6 +64,10 @@ fn krealloc() -> Self { > > > Self(bindings::krealloc) > > > } > > > > > > + fn vrealloc() -> Self { > > > + Self(bindings::vrealloc) > > > + } > > > + > > > // SAFETY: `call` has the exact same safety requirements as `Allocator::realloc`. > > > unsafe fn call( > > > &self, > > > @@ -136,6 +146,20 @@ unsafe fn alloc_zeroed(&self, layout: Layout) -> *mut u8 { > > > } > > > } > > > > > > +unsafe impl Allocator for Vmalloc { > > > + unsafe fn realloc( > > > + ptr: Option>, > > > + layout: Layout, > > > + flags: Flags, > > > + ) -> Result, AllocError> { > > > + let realloc = ReallocFunc::vrealloc(); > > > + > > > > IIUC, vrealloc() calls __vmalloc_noprof() in allocation case, that is > > calling __vmalloc_node_noprof() with align=1. In such a case, how would > > vmalloc() guarantee the allocated memory is aligned to layout.align()? > > True, good catch. I thought of this a while ago and then forgot to fix it. Just for clarification, we're always PAGE_SIZE aligned (guaranteed by __alloc_vmap_area()), which probably would always be sufficient. That's why I didn't gave it too much attention in the first place and then forgot about it. However, we indeed do not honor layout.align() if it's larger than PAGE_SIZE. > > > > > [Cc Vlastimil] > > > > Regards, > > Boqun > > > > > + // SAFETY: If not `None`, `ptr` is guaranteed to point to valid memory, which was previously > > > + // allocated with this `Allocator`. > > > + unsafe { realloc.call(ptr, layout, flags) } > > > + } > > > +} > > > + > > > #[global_allocator] > > > static ALLOCATOR: Kmalloc = Kmalloc; > > > > > > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs > > > index 4785efc474a7..e7bf2982f68f 100644 > > > --- a/rust/kernel/alloc/allocator_test.rs > > > +++ b/rust/kernel/alloc/allocator_test.rs > > > @@ -7,6 +7,7 @@ > > > use core::ptr::NonNull; > > > > > > pub struct Kmalloc; > > > +pub type Vmalloc = Kmalloc; > > > > > > unsafe impl Allocator for Kmalloc { > > > unsafe fn realloc( > > > -- > > > 2.45.2 > > > > >