From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C2DC3DA64 for ; Sun, 4 Aug 2024 12:41:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44D1C6B007B; Sun, 4 Aug 2024 08:41:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FC366B0082; Sun, 4 Aug 2024 08:41:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EB5B6B0085; Sun, 4 Aug 2024 08:41:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 12DEF6B007B for ; Sun, 4 Aug 2024 08:41:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7CCB7A83AD for ; Sun, 4 Aug 2024 12:41:31 +0000 (UTC) X-FDA: 82414523982.03.6EA8864 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id BD14DA001A for ; Sun, 4 Aug 2024 12:41:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dmMd/l8I"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722775222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1HcoA9dF4Ai9WP2A5HsZFjRnhv200gd7diTAGg/9ICU=; b=xcPly1HHVlMlbqHXqAIh7hGRh7de6nelaQ4lN/26VBVv9/q0DPmcBUPcPuGI54BHutpWKj mJuWAIiZB1SkxtNG5c/Nt+2PSK4+WR2cg+z1MQKAVlwEBYt8VfoOHiCky5ewFQfLmxjNgE Qpx68cmMPRG/iskryXw2hccQLZoxkQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722775222; a=rsa-sha256; cv=none; b=Vgl2PGKPPjWhB68ekamFkIoVajIr08J/kCmwvqIU7HBUTqK6EKmxPRqJHx2AkR3Y2+gUyU 5HdT/BRF6TyHlY/g/k8mf6sQPeIXXzY6sUG1jp54QpPpNSlA0qUor88oPHCPnl7nXbdSEx mOyfO8aB4b3UYh/Fv64tRB3JW+CqNjE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dmMd/l8I"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 180A460A7C; Sun, 4 Aug 2024 12:41:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2F91C32786; Sun, 4 Aug 2024 12:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722775286; bh=hkFT8J4L9Om4+1HcbHi/qiwu8V1ZSM/CvwWOwoQr0e8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmMd/l8It6O1W9JfjmfFDGfYINuZODnSID4KpxkP0NtekvoU6YrUG6NYN4ZH/9pHI xKxZvIrMwrj8q4i7KrWJT39S04ic5s9qQq7iFy/UELIirE1HrUGviqhr7huOBefZDx /yU+RSogpIaiWwH7soxSXz7rXVLSDE4WwG/KUA0PPvIT2IjS/g3PnZO8JlZGwNYmMr sZeSuD9DO2pZ3clQWq/zqoF59jPhJFhfEnz3zu0JG6Fmz93XkNcfySbnV8BdDEb+0r 1vvYtJq4IXoyO9u8xoCthfh9FBWYztH89C1NqUAEVzHIV34jE+2xwOqGTJh82rYVfD Jifkz6piRomIg== Date: Sun, 4 Aug 2024 14:41:18 +0200 From: Danilo Krummrich To: Boqun Feng Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH v3 06/25] rust: alloc: implement `Vmalloc` allocator Message-ID: References: <20240801000641.1882-1-dakr@kernel.org> <20240801000641.1882-7-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BD14DA001A X-Stat-Signature: c7yf9eqgws4rosx5i3ms9hhdnfjf8ei1 X-Rspam-User: X-HE-Tag: 1722775289-214892 X-HE-Meta: U2FsdGVkX1+FAZuVZ+S3WaxStO5Q+qDXniJ4fNyQfvR2l+ssOjCu/UnguR34JfjmZtNC8ghZRPxijRJsGp+XHFjoeTdNPthFBmNy5w1AQx2sTr4jOgi1qOCi8bpP10kmbBYjxqMlT1X2Xr6myePG3VDfPeTVQGApFvVluSZ+EEt6W4bYEWYnCOM4GNdKgrjPPRawhJdFzNAmmKCUlbGh0XBA2wjY/94NVXB/QiKWoDnfW3ublEtDmLXZoAJJqdmJbVksMe9YNMjFHsoYp7cEeqTSpsTioqzzdN082M946OTmvZmXsbiyU1uh/ABJxTSMROzM5Up/ErXeCyWnb8OzSom9f1HNWt2ZDBKPFAd5OXwkxuoiIxNtiwYxJWQYIdYjjE/Z0rQMzxwayxWY1wolQ8CVINSXEFK90QJgy3yy6s2/sDqRn/i5JVNi5KLLDufv6iZLvdym7Pcv1gxT0QLJPabZjTPAMPPaUGVsXk53wQ0KLQXAfVNTsjnlumVjzorrVDT6zWT7QK8dbd6AuH9rWlDvCYWR6EFC5GJRiZ7CpQsK8IPHEM/zewEMH1xXAA25y2WFpHn8tsIaOx4D9hNBW2gnlH5yEVi49CaXB5wd/rKAz0QTQ3uGvS8jEdACuA1DqA9ts49nCAzsoq2HfK/YD3lIvNJAmpWMQVX1IH05Z5HfdmGBdljgThi/l9AXotC27SdGxduO8BiMY23mVK0YlqKQs39/HU5p218OJiLLq8/A57hiX0XbcLvz/7EwPiEfG9+pRXx6K+mIKGZu2KhcsfSsX2JKg8pU/vtWqMEhpvWUY06fd3qXHIlt5MfLfnodsdHseIxXTMP8k52wdfZPxxchyATSwdN6mZYk3lR/bYa3jIw2D7+6yrG8VT/4OZLEzREE21AA0AOKvrhlHtvm/PysezhamzCOO9L+58nxj6olZJZ9L268zxNwwMjoKyNL5Kw2QkAveAcUleKbRA4 DogjLrEE 41hceO9prIdqtMJ4fv0kd1k+P8nssdUWRaPV4llUQ+H88o9d9OLf99N7uBHZUyh9pv33v7J76a/TfpzSH5CVSzNpqR44XSTrdovrwxjQ7e1MNCynNmridmtH87t7AYXgDJsKR7UZWo8RHC3EmZokXduDxvuv/48rGeURAJ01p8A5XsaxjZ2v8JRoKdM/Vjp29IBW11Ogrpl0RPLehbN3BJKu7cu/sRrcgPC4m5CWMVO/BpE6p3F4QTSzvB+OhdddhSCgyktG3EOe3T8lsKRNbdapQlLoHkiEBECB7984dFpPyUUm+AWkM9VohqXA3i2cd1HU9LHhkjmlY0HNNs+9nZgDz2zsJYA+gksVc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Aug 03, 2024 at 11:44:58PM -0700, Boqun Feng wrote: > On Thu, Aug 01, 2024 at 02:02:05AM +0200, Danilo Krummrich wrote: > > Implement `Allocator` for `Vmalloc`, the kernel's virtually contiguous > > allocator, typically used for larger objects, (much) larger than page > > size. > > > > All memory allocations made with `Vmalloc` end up in `vrealloc()`. > > > > Signed-off-by: Danilo Krummrich > > --- > > rust/helpers.c | 8 ++++++++ > > rust/kernel/alloc/allocator.rs | 24 ++++++++++++++++++++++++ > > rust/kernel/alloc/allocator_test.rs | 1 + > > 3 files changed, 33 insertions(+) > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > index 92d3c03ae1bd..4c628986f0c9 100644 > > --- a/rust/helpers.c > > +++ b/rust/helpers.c > > @@ -33,6 +33,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -200,6 +201,13 @@ rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > } > > EXPORT_SYMBOL_GPL(rust_helper_krealloc); > > > > +void * __must_check __realloc_size(2) > > +rust_helper_vrealloc(const void *p, size_t size, gfp_t flags) > > +{ > > + return vrealloc(p, size, flags); > > +} > > +EXPORT_SYMBOL_GPL(rust_helper_vrealloc); > > + > > /* > > * `bindgen` binds the C `size_t` type as the Rust `usize` type, so we can > > * use it in contexts where Rust expects a `usize` like slice (array) indices. > > diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator.rs > > index 397ae5bcc043..e9a3d0694f41 100644 > > --- a/rust/kernel/alloc/allocator.rs > > +++ b/rust/kernel/alloc/allocator.rs > > @@ -16,6 +16,12 @@ > > /// `bindings::krealloc`. > > pub struct Kmalloc; > > > > +/// The virtually contiguous kernel allocator. > > +/// > > +/// The vmalloc allocator allocates pages from the page level allocator and maps them into the > > +/// contiguous kernel virtual space. > > +pub struct Vmalloc; > > + > > /// Returns a proper size to alloc a new object aligned to `new_layout`'s alignment. > > fn aligned_size(new_layout: Layout) -> usize { > > // Customized layouts from `Layout::from_size_align()` can have size < align, so pad first. > > @@ -58,6 +64,10 @@ fn krealloc() -> Self { > > Self(bindings::krealloc) > > } > > > > + fn vrealloc() -> Self { > > + Self(bindings::vrealloc) > > + } > > + > > // SAFETY: `call` has the exact same safety requirements as `Allocator::realloc`. > > unsafe fn call( > > &self, > > @@ -136,6 +146,20 @@ unsafe fn alloc_zeroed(&self, layout: Layout) -> *mut u8 { > > } > > } > > > > +unsafe impl Allocator for Vmalloc { > > + unsafe fn realloc( > > + ptr: Option>, > > + layout: Layout, > > + flags: Flags, > > + ) -> Result, AllocError> { > > + let realloc = ReallocFunc::vrealloc(); > > + > > IIUC, vrealloc() calls __vmalloc_noprof() in allocation case, that is > calling __vmalloc_node_noprof() with align=1. In such a case, how would > vmalloc() guarantee the allocated memory is aligned to layout.align()? True, good catch. I thought of this a while ago and then forgot to fix it. > > [Cc Vlastimil] > > Regards, > Boqun > > > + // SAFETY: If not `None`, `ptr` is guaranteed to point to valid memory, which was previously > > + // allocated with this `Allocator`. > > + unsafe { realloc.call(ptr, layout, flags) } > > + } > > +} > > + > > #[global_allocator] > > static ALLOCATOR: Kmalloc = Kmalloc; > > > > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs > > index 4785efc474a7..e7bf2982f68f 100644 > > --- a/rust/kernel/alloc/allocator_test.rs > > +++ b/rust/kernel/alloc/allocator_test.rs > > @@ -7,6 +7,7 @@ > > use core::ptr::NonNull; > > > > pub struct Kmalloc; > > +pub type Vmalloc = Kmalloc; > > > > unsafe impl Allocator for Kmalloc { > > unsafe fn realloc( > > -- > > 2.45.2 > > >