From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD997C3DA63 for ; Wed, 24 Jul 2024 14:32:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42DD46B008C; Wed, 24 Jul 2024 10:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DC1B6B0092; Wed, 24 Jul 2024 10:32:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27D086B0093; Wed, 24 Jul 2024 10:32:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B7086B008C for ; Wed, 24 Jul 2024 10:32:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A4BA5C0A5F for ; Wed, 24 Jul 2024 14:32:44 +0000 (UTC) X-FDA: 82374887448.16.B205E2E Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf19.hostedemail.com (Postfix) with ESMTP id A29641A0015 for ; Wed, 24 Jul 2024 14:32:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UmH+sse+; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721831539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vRIG3jZWW6+gmzeQGbVpeigOtDWbcHntB8qUrQnqXaI=; b=n4iIVlpkR+VVp6802rW3OrsceBTJXGv0Li7wWW25elOamVx4VFnnbpktBRTP6YGL50BgWZ n87uYZ2nsazeLDbL6kwdc9h4kRllCsCNl1Yups1+iL2GcUH2DgJnAqUyJQH/ZvVkB8BboJ VlVJ/2bFmc+ba0W1euRhlCiP+TvUgis= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UmH+sse+; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721831539; a=rsa-sha256; cv=none; b=agFMjO7Zw9BPfwg3a+yLy7oJPuQn1hkQfNUd2vBF81Oul3wwVvahtEe5e6ZABfxD1wMn2O nuPcsNN78tGRRntZ/4TuRwNiU3df8ZL539V6IephdrjBU6wvSNdY4Iq9imfV4liZEjqUiy 7BA2TxasXbZ8qw1YirdyYPds2qkMm48= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ef2ed592f6so41795631fa.0 for ; Wed, 24 Jul 2024 07:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721831561; x=1722436361; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=vRIG3jZWW6+gmzeQGbVpeigOtDWbcHntB8qUrQnqXaI=; b=UmH+sse+md0OWqh0jWlGZzwF1Pd0CVzqaiqoLmNMgx7iZc+jhh1xfukpImCPvdxDBH mYGpVp8SgPRbjtQAUWomPftF0sT18AS7vWAJ11jZWADLI23ZzS2nADBoK8/qbR7pYqEC ypyZ2ZTHfz4g0K0CTKnBJY6xGA7IjMjPP4djkqfu4u2d8WmmJuSQNG9fEJgVjnIaFX+f uLUKciHJGbp96R0xvnNhLOhQBWYBNW8cim7MpQ3AkdgPsYWIm5nQUcARNCQ4bFFlourO 0X7FBDku+7ZvH91BjT7C6PmLH6AaisxchATgixXq6fH/rkXPbw43xaZSAqztcm2uAtUR umLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721831561; x=1722436361; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vRIG3jZWW6+gmzeQGbVpeigOtDWbcHntB8qUrQnqXaI=; b=ZCOHeL2Pua4v2aDlUib+5ogeuiDOTBShTbzyEZEFc42tl3Vxn6sj5YMNeDb8I8DTUP tEzlgjBoyvo9vvjaFbBdWqXt0okKt5H2bgXIR6+OYv5MbAA8jePkizkyvZE6KWWNA0IB dXkHe2iaH+p7Qh4JyjunUIMKmmU41fi5BSFDk9XE76yPKeCSbsveLFfenuK7ru2/ju9q MJGhmcrkad5hYRwqaZUCHsItQDLBmrvELtB98bKFuJy69M6CPo2Yu9npbKfjaiJnQU25 n+Ptb0Oz/fS6SSv1kwc8D7i0+7YR5w8ys0a/HQOiJ2RFE3yhOK5QccLqhx7QYpXJyTj+ epvQ== X-Forwarded-Encrypted: i=1; AJvYcCVKcmxXBrvpBUP0DdgnreZph73pDvQuRQusuKbzgzG1ly6Ce+BcTzrWNmI5pzp8U5i7p9tQzHfTqnG8UyY5zezBMns= X-Gm-Message-State: AOJu0Yw6/OHi9FljEJkUiGplpXnnhe1nDsema4x1ocyd4K5kXcz9xC6j WAX5fdGpI5HtD0NaDNaJiV13iB92MwGuRLX2fyE5ypZ7V+XLBuAI X-Google-Smtp-Source: AGHT+IEuV00AurgRYl47n4+9PvAZ0CapDyov0r3kOU1pGUrQcmH2BxdM7vWeV5PSoLkG/kRvIp3Lgw== X-Received: by 2002:a2e:919a:0:b0:2ef:2543:45a2 with SMTP id 38308e7fff4ca-2f039cdf5ffmr289461fa.25.1721831560502; Wed, 24 Jul 2024 07:32:40 -0700 (PDT) Received: from pc636 (host-90-233-213-186.mobileonline.telia.com. [90.233.213.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ef24fbe937sm15017101fa.6.2024.07.24.07.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 07:32:40 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 24 Jul 2024 16:32:37 +0200 To: Adrian Huang Cc: urezki@gmail.com, ahuang12@lenovo.com, akpm@linux-foundation.org, hch@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, sunjw10@lenovo.com Subject: Re: [PATCH 1/1] mm/vmalloc: Add preempt point in purge_vmap_node() when enabling kasan Message-ID: References: <20240724124624.27673-1-ahuang12@lenovo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240724124624.27673-1-ahuang12@lenovo.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A29641A0015 X-Stat-Signature: anmhywqmnon6opx3fhmwr6je5inugn3b X-HE-Tag: 1721831562-721795 X-HE-Meta: U2FsdGVkX18UllMZQ0H5RAmGtg0wAe3WpMCLkf3fMYXQ8AIgcporbvQNkLjQamY8vvQbOaPEdb+0kq3t6KRcwBXZwEDLtWqQ62isSKiqp2f+x4N/CqXie3r1jgquz2ijB4P4fodsem9ejO82aoWmN5dfu/Xm+12kg7PGQG/P2CoyQr7FTt0z46Z01mAMidinu4LKWAfDh9SrZ8eBa2Y83D6jmvMO4iMbLPVK8n6RX5x6u4c/VTs8B6UZZ927YDVCB3L822YyA/UwYjnUCriRTls+8/JlMZHY1gh+i/9JJ4G/ROtiou+q+QRvI6Qof42iNHhELJt8t6gQHUtYfXS7Or0K93JPjg207BjN53tCTQVXouosCDeKXzExyoOm/0VTBVHCsAdFcGefi4Yt0Yt9MYEpTeHKvEjHcB2EE6IgkHKjrUWWLcpm/QIuc6xrfrMTI+phsvGdW55JHtOFvI30w1PwLkbxskZYh7v/+1TTCCo6xayOPovDV//VTLqpXiqy4jyk7zIwbS5Ev45tyYbyWviH1zC8zpPULRjrxBCRMTGXo1JQIOaSEIomtzV8IgMTcThRJ5EOF7SyAMWSiSBwdv0GLKqLQeDbpTKoejcTd4P3Ud6Vy+HZxWD2ASMfLFTbSYhgFCNM5oeAHTYipWXi+97lcQxJaolKf88EWayGIiyqQE3oxNkrpY/ANpOgqK++XIZpKXBNBCJmjDPTu3qseqGgDHCCScnhIjvW3DXw7XJ7wx80ilG25E0h/aKcewbe1Hxq19BA6mZAAX7bNqyU8Rq7dUb24DBnnNI/fUhV128T5pe28Wq1MnnyCAdf28DeC0q35YQeGZGZ4ETTvirIgc6sejkKrazGJZv+lSCO8fBIusHr7akLWnzjSNvUdfXsLZO1t7Twkf8BbUp1pVFyFpiA+Owt+7NvfoPa1HcTgkdct2LlYFgatgULe2nsapT7Wt9NfRPn+CJK6LhmUUi hioF5woW jd6K9MrkS0Zziz512rL03K80NmcnFIfpb3U04/H384USxBabjqoMfi47QISIzPF+UDBhc1cjjXWVPrN7EYjtqXdD4SapTYTJ4St29qLQjOYEC8zOGNDLqvf38C6asGAAjC6cgePRm9z1c81m7nYw0MxMBlqzVlMBfscD+sI7dmcpgeNJX38FfM9EVkQAKFpyY4XTUoWiLee4l21FUZPyCtmL4z4yIUDgx7SjskJzeu9ATig5yDVYQYZMoYN8lxpK/IK176loF5BG0mDozii+Hr16rK4UDMeoNo4tLo6T0o1+KSO5n2ROosh74GptzMzm2SK6hj01o4O812+E2weM8JRh62PihUmKtbnRWKYd1FYZqCk8G3qFnL2q60XFcke2jqYdiG31iJ5hiHPc6JlIlWEISY5CkZxuR7dD6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 08:46:24PM +0800, Adrian Huang wrote: > > It works great and does not generate the soft-lock-up splat :) > > See below some comments: > > Great. Thanks for the confirmation. > > > > >> + kasan_release_vmalloc(start, end, start, end, KASAN_VMALLOC_TLB_FLUSH); > >> + > >> > > Do we need it here? We just did the TLB flush for en entire range in the > > __purge_vmap_area_lazy(). So, it is two times invoked and looks odd to me. > > > > Am i missing something? > > 1. The TLB flush for the entire range in __purge_vmap_area_lazy() is for > the vmalloc virtual address (VMALLOC_START->VMALLOC_END). > > 2. The TLB flush in purge_vmap_node() is for the KASAN shadow virtual address > (the shadow offset 'CONFIG_KASAN_SHADOW_OFFSET' is defined in .config). > Correct. It deals with a shadow region! > > BTW, I found my first patch has the potential risk. We need to flush TLB of > the KASAN shadow virtual address firstly. Please see the following patch for > detail. (I put the comment in the following patch). The following patch > also works well on my 256-core machine. > I noticed that and it would be my second question :) > > If you're ok with the patch, I'll submit it for upstream review. And, may I > have your tag(s): tested-by/reviewed-by? (If possible, could you please have > a test for the following patch). > I am OK. I will test and get back soon. > Thanks. > > --- > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 70d6a8f6e25d..ddbf42a1a7b7 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -55,6 +55,9 @@ extern p4d_t kasan_early_shadow_p4d[MAX_PTRS_PER_P4D]; > int kasan_populate_early_shadow(const void *shadow_start, > const void *shadow_end); > > +#define KASAN_VMALLOC_PAGE_RANGE 0x1 /* Apply exsiting page range */ > +#define KASAN_VMALLOC_TLB_FLUSH 0x2 /* TLB flush */ > + > #ifndef kasan_mem_to_shadow > static inline void *kasan_mem_to_shadow(const void *addr) > { > @@ -511,7 +514,8 @@ void kasan_populate_early_vm_area_shadow(void *start, unsigned long size); > int kasan_populate_vmalloc(unsigned long addr, unsigned long size); > void kasan_release_vmalloc(unsigned long start, unsigned long end, > unsigned long free_region_start, > - unsigned long free_region_end); > + unsigned long free_region_end, > + unsigned long flags); > > #else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > @@ -526,7 +530,8 @@ static inline int kasan_populate_vmalloc(unsigned long start, > static inline void kasan_release_vmalloc(unsigned long start, > unsigned long end, > unsigned long free_region_start, > - unsigned long free_region_end) { } > + unsigned long free_region_end, > + unsigned long flags) { } > > #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > @@ -561,7 +566,8 @@ static inline int kasan_populate_vmalloc(unsigned long start, > static inline void kasan_release_vmalloc(unsigned long start, > unsigned long end, > unsigned long free_region_start, > - unsigned long free_region_end) { } > + unsigned long free_region_end, > + unsigned long flags) { } > > static inline void *kasan_unpoison_vmalloc(const void *start, > unsigned long size, > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index d6210ca48dda..88d1c9dcb507 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -489,7 +489,8 @@ static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr, > */ > void kasan_release_vmalloc(unsigned long start, unsigned long end, > unsigned long free_region_start, > - unsigned long free_region_end) > + unsigned long free_region_end, > + unsigned long flags) > { > void *shadow_start, *shadow_end; > unsigned long region_start, region_end; > @@ -522,12 +523,17 @@ void kasan_release_vmalloc(unsigned long start, unsigned long end, > __memset(shadow_start, KASAN_SHADOW_INIT, shadow_end - shadow_start); > return; > } > - apply_to_existing_page_range(&init_mm, > + > + > + if (flags & KASAN_VMALLOC_PAGE_RANGE) > + apply_to_existing_page_range(&init_mm, > (unsigned long)shadow_start, > size, kasan_depopulate_vmalloc_pte, > NULL); > - flush_tlb_kernel_range((unsigned long)shadow_start, > - (unsigned long)shadow_end); > + > + if (flags & KASAN_VMALLOC_TLB_FLUSH) > + flush_tlb_kernel_range((unsigned long)shadow_start, > + (unsigned long)shadow_end); > } > } > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index e34ea860153f..12cdc92cdb83 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2193,8 +2193,22 @@ static void purge_vmap_node(struct work_struct *work) > struct vmap_area *va, *n_va; > LIST_HEAD(local_list); > > + unsigned long start; > + unsigned long end; > + > vn->nr_purged = 0; > > + start = list_first_entry(&vn->purge_list, struct vmap_area, list)->va_start; > + > + end = list_last_entry(&vn->purge_list, struct vmap_area, list)->va_end; > + > + /* > + * Since node_pool_add_va() returns vmap_area(s) to its pool, the > + * returned vmap_area(s) might be grabbed immediately via node_alloc() > + * by other core. We need to flush TLB firstly. > + */ > + kasan_release_vmalloc(start, end, start, end, KASAN_VMALLOC_TLB_FLUSH); > + > list_for_each_entry_safe(va, n_va, &vn->purge_list, list) { > unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT; > unsigned long orig_start = va->va_start; > @@ -2205,7 +2219,8 @@ static void purge_vmap_node(struct work_struct *work) > > if (is_vmalloc_or_module_addr((void *)orig_start)) > kasan_release_vmalloc(orig_start, orig_end, > - va->va_start, va->va_end); > + va->va_start, va->va_end, > + KASAN_VMALLOC_PAGE_RANGE); > > atomic_long_sub(nr, &vmap_lazy_nr); > vn->nr_purged++; > @@ -4726,7 +4741,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > &free_vmap_area_list); > if (va) > kasan_release_vmalloc(orig_start, orig_end, > - va->va_start, va->va_end); > + va->va_start, va->va_end, > + KASAN_VMALLOC_PAGE_RANGE | KASAN_VMALLOC_TLB_FLUSH); > vas[area] = NULL; > } > > @@ -4776,7 +4792,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > &free_vmap_area_list); > if (va) > kasan_release_vmalloc(orig_start, orig_end, > - va->va_start, va->va_end); > + va->va_start, va->va_end, > + KASAN_VMALLOC_PAGE_RANGE | KASAN_VMALLOC_TLB_FLUSH); > vas[area] = NULL; > kfree(vms[area]); > }