From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F1BC3DA63 for ; Wed, 24 Jul 2024 22:15:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780526B008A; Wed, 24 Jul 2024 18:15:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72FC06B008C; Wed, 24 Jul 2024 18:15:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61E7D6B0092; Wed, 24 Jul 2024 18:15:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4529C6B008A for ; Wed, 24 Jul 2024 18:15:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E757BC0C2A for ; Wed, 24 Jul 2024 22:15:28 +0000 (UTC) X-FDA: 82376053536.04.BAD1D1E Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf26.hostedemail.com (Postfix) with ESMTP id 1956614000E for ; Wed, 24 Jul 2024 22:15:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eHadiCjB; spf=pass (imf26.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721859289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j36qx1vlc4eJgLuKEjO4bAeumQszgxwbVfIt3GwMYuI=; b=gqGCnC4942Uky4ixU8r6j7SXqs91b1RJi9vxfTf9GEfBudS0FeJ7YANgPdbAmnTO+fuoiW VTOUHWLqcCMypx8aJ7+wjXJi3Yd0kJlEgtRDvL2aD8fuI/SkexNZ6RLxKOq4bp/5UW6/QT 2WLX7HxX+r0fe27PVYKIF3HfSCWxIG4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eHadiCjB; spf=pass (imf26.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721859289; a=rsa-sha256; cv=none; b=cm7wmUFvCuY0gOYfCaH4p0/JPa+/2MJSmpbbQp0E+/0h4WiYWhI6D6orriq33vAx2SeJyd DMBKT7ULO6o04EwS+oaWo8ogzKXuc3nzn7s+bryD8LfT/18TbKd2VXLjw+yNoJQRS4+31n Fo1Oo7WX48Bgt0YwZel6fwZqFxv/+eY= Date: Wed, 24 Jul 2024 22:15:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721859325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j36qx1vlc4eJgLuKEjO4bAeumQszgxwbVfIt3GwMYuI=; b=eHadiCjBCn9ve/g3AQ/i0M34skHrCjioV9AVLBHBpo7TeMxGy0AN6Ey81EO3ElF2Wujwvu kS3zVPOA1RmKaCZvCuLuG64jP2WIk7YB3jJLZC9JnqL1UdScEM9FnTtvtkNpDI62/8TdqI tKIQpcxkwBJoUN3C2gPF7W6r/wvDK6Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Oliver Sang Cc: "oe-lkp@lists.linux.dev" , lkp , Linux Memory Management List , Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Muchun Song , "cgroups@vger.kernel.org" , "Huang, Ying" , "Tang, Feng" , "Yin, Fengwei" Subject: Re: [linux-next:master] [mm] : aim7.jobs-per-min -29.4% regression Message-ID: References: <202407121335.31a10cb6-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 8ozmu995kqxkskw9m8jd7ksupn7kyruu X-Rspam-User: X-Rspamd-Queue-Id: 1956614000E X-Rspamd-Server: rspam02 X-HE-Tag: 1721859326-792727 X-HE-Meta: U2FsdGVkX1+o5Aiy2OWmbtg+Ei7jbog5X8hwfrP2DUzHPIZbWKhIGr3zSK9LYQYFMB8fsKQS2CBPDOoI0O1wBAc+UW13nUBtFV9Ktm4ko0RnzPHueUxQ5zd/DK6OvpZk+T/mq8tytw85Pl5+sZo8bp9duroApkwDmBjL5eOIUif6fI7XLTQb1gdqbwvXjah4svQSxUyjTZlWJ11oZ+y2cBEr3qxkg6JJDxx04kFTkDvZaMUF4a2H5UK6akpzsbNRghduWK1rqB1FjS0vwbFor7ueXu0GDqsGTmzpS3uoMxin2YvoL7RVhZ1Bg8GXXkhx7yHHFcArN6Fk4rSHJqN155mvAlgdZV+vmUE/X/N1OC+A73h/4QQV/e3Xk0Uxw0J+XQbVlFDw7u8UVvK9obc7MFHAGs/vys4/R0DhKMAIH2wXJkNB/Dxlg9Vg3R4SKTsQFYJLRTNrzW7Tah0RORZ+TN/oe3Cu4nJRHpGzFENVxa0pmXlwBdDC1NnpuCkDGh4QuljyGGxG/3uFiB9sQU7w1y86IFOeQEzwSFEG6UENFClYkqfgX1JwJTgX3hHjtZCewTBP0qILFbdlVh3xWEOqGwxqPWlTUwigLKp/KlCXIdeYhmCTdLFS9K3lh/EOqoIBgGFZGSY4fReRyjwiQlkHQiyS6AO0p1kD3xDa6gQ/3FIKWyBofX17K2Uh4amcXHybmoxxe+RwEbXlYpUrKzCzZpxkiUbEHTnNXaCPetwrm9F9R5lXhGiEstCHEtnbsQqVBhhUKT5pSeOiybOpMfyYR1DXQSr4gwiGDegMG1IU0JePJMYWKsjOBNXT3W8nkQxo6iEACGCfMVtmYadsiNS7pxfuG2IWZunUNypS8PtrWDH+pMCqSV6uWsryYy4BFCDWbuKsL+mF/qp0uP6jLAKj+CfRRT70Zuy70u9v75rcDL0t7XW5gzxXDRtIFUpH2Gd4sYvnUMdku0LeIzj/aBQ dX/+2vwl Nol44D6DGS32/vqwMVdNYPx//Lue6ci17LkPezInl9ZrCUPfj2pQ6bdK4LwYaqWdciPJ/GThglG4wxuXbDmldABZWIl4Eef6JIh1Li2fUp+FTU3xGaYR68TWy7SyWlK7uESo7lGvSyvRUpT+e7r5WbyaOtHi8VMR4LG/Z3cd81AHO1d+eXMknwYLI0F5IxE8gEJ1jMebzRdMXuHbvqSxyS9Z0W8/eUXbi0kad8U/xq3y+sABOQ1PKwMTCnWHEsKu/nBPc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 23, 2024 at 11:42:33AM +0800, Oliver Sang wrote: > hi, Roman, > > On Sat, Jul 20, 2024 at 01:14:16AM +0800, Roman Gushchin wrote: > > On Tue, Jul 16, 2024 at 03:53:25PM +0800, Oliver Sang wrote: > > > hi, Roman, > > > > > > On Mon, Jul 15, 2024 at 10:18:39PM +0000, Roman Gushchin wrote: > > > > On Mon, Jul 15, 2024 at 10:14:31PM +0800, Oliver Sang wrote: > > > > > hi, Roman Gushchin, > > > > > > > > > > On Fri, Jul 12, 2024 at 07:03:31PM +0000, Roman Gushchin wrote: > > > > > > On Fri, Jul 12, 2024 at 02:04:48PM +0800, kernel test robot wrote: > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > kernel test robot noticed a -29.4% regression of aim7.jobs-per-min on: > > > > > > > > > > > > > > > > > > > > > commit: 98c9daf5ae6be008f78c07b744bcff7bcc6e98da ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node") > > > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > > > > > > > > > Hello, > > > > > > > > > > > > thank you for the report! > > > > > > > > > > > > I'd expect that the regression should be fixed by the commit > > > > > > "mm: memcg: add cache line padding to mem_cgroup_per_node". > > > > > > > > > > > > Can you, please, confirm that it's not the case? > > > > > > > > > > > > Thank you! > > > > > > > > > > in our this aim7 test, we found the performance partially recovered by > > > > > "mm: memcg: add cache line padding to mem_cgroup_per_node" but not fully > > > > > > > > Thank you for providing the detailed information! > > > > > > > > Can you, please, check if the following patch resolves the regression entirely? > > > > > > no. in our tests, the following patch has little impact. > > > I directly apply it upon 6df13230b6 (if this is not the proper applyment, please > > > let me know, thanks) > > > > Hm, interesting. And thank you for the confirmation, you did everything correct. > > Because the only thing the original patch did was a removal of few fields from > > the mem_cgroup_per_node struct, there are not many options left here. > > Would you mind to try the following patch? > > > > Thank you and really appreciate your help! > > you are welcome! > > though we saw there are further discussions, we still share our test results to > you. > > in our tests, by your new version patch, the regression is entirely resoloved. Hi Oliver, perfect! A patch with a fix landed to the mm tree (you're cc'ed). Once again thank you for the report and for the collaboration on testing fixes! Roman