From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C90C5C3DA5D for ; Thu, 25 Jul 2024 16:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E056B0093; Thu, 25 Jul 2024 12:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E44A6B0095; Thu, 25 Jul 2024 12:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F6F86B0096; Thu, 25 Jul 2024 12:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 32E3E6B0093 for ; Thu, 25 Jul 2024 12:01:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ACC511A11D5 for ; Thu, 25 Jul 2024 16:01:08 +0000 (UTC) X-FDA: 82378739016.01.40EE5D1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 99DD514006D for ; Thu, 25 Jul 2024 16:00:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721923215; a=rsa-sha256; cv=none; b=jQXM27UnGFjrlI8t1tglCrNmfr/Yyq+3oky2ySJNL5wJdlEOxU9Aq7ic1j0PY8OBFFgGBO 0YQa80vG7tbg3GZwb3CGg0hy5/1RXLUc5h3UrR0eXpmaChyWGb1/63NejZb6zHdU1Qrr2a H93AA4ePa/JzyA+3Dgq11KUaYiGxcbc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721923215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rKAeY8i6hHceTLyL1IsZjLbaVGk6FTUsWf+xxh18W8k=; b=0THwmr9kDthWAgfI3X/gPW2m+AO4NpDChj9W5UfManCt0EtBYRIBT/Wwi6RFn/C/bGNNCM q+yO7a3c3dK523kG+EXcTeHXKT2wFqHEiD9AwY0jqShHPMoYL/Pr1RCSda3PDhQOdWfIYc RRj76m2BmyIPN+Dquc/VpGC5kRn3G4M= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA2BC1476; Thu, 25 Jul 2024 09:01:19 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7FAA33F5A1; Thu, 25 Jul 2024 09:00:51 -0700 (PDT) Date: Thu, 25 Jul 2024 17:00:49 +0100 From: Dave Martin To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 19/29] arm64: enable PKEY support for CPUs with S1POE Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-20-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503130147.1154804-20-joey.gouly@arm.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 99DD514006D X-Stat-Signature: n7cg7xfgzxpw8xoti7mqe7bwkm3fk1wx X-Rspam-User: X-HE-Tag: 1721923255-485576 X-HE-Meta: U2FsdGVkX1+Cvfn4UjROJQTTP2LcGKNEDAxq3b2mYZsILyK7doKOm506vOT0JMcEF2g7ZWzEzHrGmOrKHnTXF/jGNt2YXT6JMy+23nq6g4rTGx+5Esnlk+ktHd8a1ztD9GPRuZwY4W7Ucdp1NL/f3y1Z9RAyEIUSSegb1kYkGa7xTDg7YUkFA0lkIBOjir71rbU+Vn/rh5uyfGZOZts2KmV+7iyHLVI5noMzFNAr7tDLQUMyvvf9EKnABbu4T9dXol1Hhnf72JFbSQrM+YdFLta+Dh+EGV6vNjtZE+fHERLsrpomDYHWKuwjojjliwrv+sgNdRyrcJA9Sjadf9EJF2h4oTNsLOoQs4J2yGpEV7U2gpmP4E4wToLL5mLSLleBBy+gQs0wioXVikCOaIvnkRducoGcNiFHPB42jVdCn/yYJC/pgzgp6DQWizIw/Zi2LIA8IXwmEy5sXm5Qp0wrC4UoxrnoxB3Wc5qiBluBRSS4zVof9SLNXyK5EIzkdF1KMUrxMVq/27vBkGpWrunaSq6knypoW231XrCukQgDPIWGrS41rhYEQteqqm/Nh2brEq8CJsNIVjfbhhGqgXw3ZODa0yQzG23TrUISYohgqPJlzS+lDzX3PvKqYZuddcYQ3tKhVe5hVhZTJ2rGyak0JMmxFnChr8/dc/8FrPdTuX4h0smCtc0dP9fV2e9DDZ8FMAkvOFAVSgOAVW4DocniIMbnIEIDcsW3QPgHuNO6PdB8G4vkpOy9LCf9X0N1PXCa7FBesEykXrZsaIIWJ46Omh2RVUPYdj0iPenAw7zyh/w+oHt/UeatI5Y1i5/XsckuecE87zdraCgGNTdXeHwYbC2j4IqS2vXozMAI4yrphP9ciPeCAPDvN3mMPlPy5dzE3MK6AIGrP9v2dhbqjhatB4xoKNLnrewZ8Guuwhd98RycwInC7x5/10YLTqMEwyNeDCY2NmKAwQkeUlj4k1+ fldPW5J/ GW+fGb1WoPK7reJb05EBFFa/LxvFLESOUS/hBYAz3dKFFCTOhzCH/XgCE3AB1DzZsHsIVR5ZFlYF+dqekzcWTmJbieZcNZ7MGzYsOG5vlvaCetH/+WbSFeRhGqGz7W1nizmXa3v2F/y2AT1EzA1RWyjK7b7XQLV0VK4mTNJOS+uL5G8xK5QL5WR9bDTISygjPr/cSgqznS17wfx+kEfZPJQwxgryM+zmyLsND1jTKDhmR2essJE3o1Lh0nii5k3XiIP8ChxcDpeNrgPI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Fri, May 03, 2024 at 02:01:37PM +0100, Joey Gouly wrote: > Now that PKEYs support has been implemented, enable it for CPUs that > support S1POE. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Acked-by: Catalin Marinas > --- > arch/arm64/include/asm/pkeys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/pkeys.h b/arch/arm64/include/asm/pkeys.h > index a284508a4d02..3ea928ec94c0 100644 > --- a/arch/arm64/include/asm/pkeys.h > +++ b/arch/arm64/include/asm/pkeys.h > @@ -17,7 +17,7 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, > > static inline bool arch_pkeys_enabled(void) > { > - return false; > + return system_supports_poe(); > } Nit: maybe push this later in the series, at least to after the POE/PIE patch, since pkeys won't work right otherwise on PIE-enabled platforms? (I know it makes no difference without final Kconfig update, but it feels more logical.) [...] Cheers ---Dave