From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9F5C3DA61 for ; Mon, 29 Jul 2024 03:43:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7EA66B009B; Sun, 28 Jul 2024 23:43:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2E576B009E; Sun, 28 Jul 2024 23:43:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF6286B00A1; Sun, 28 Jul 2024 23:43:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B26E66B009B for ; Sun, 28 Jul 2024 23:43:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2A87E1C0FF7 for ; Mon, 29 Jul 2024 03:43:57 +0000 (UTC) X-FDA: 82391396514.10.44DCF5D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id BE2FB40027 for ; Mon, 29 Jul 2024 03:43:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MuXV5vDz; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722224596; a=rsa-sha256; cv=none; b=Bd9mhcFKWZlp2NxxoXDAhBtNI/J15+csVTQ6RJgPPMDBNX3Vgr6PxmlOPk/IrhTy8HvZYc 2P3HlHYZRXoIPNfkzDTIvxHzfk9tKUwUTlXPZd3zh7g1HMcQYDFPhSfO0KZPTxVho/a+/b 5+m2Jybr4haUlyw8r8jLIvq5ionLjHE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MuXV5vDz; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722224596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F8hJQKEke5IRYxPjZGrirscb0oTcHFcMOJmtf/7z7i4=; b=IsC4Os68bBgaxeMF2ZDzq9DQBgukk1K1fUxwxtrjUh9QwpevOlAC9vTzb3Ypc8ulyTwvsR w7D+EyUghTtGwQL1I+kpZU+fT18VdjJv2V+IyrUgPyvixc0izZuAIsAIZTI9+elGDA8taa CbFS+UKW2Fyk3i9SzKu5Dax5FrmYRMc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F8hJQKEke5IRYxPjZGrirscb0oTcHFcMOJmtf/7z7i4=; b=MuXV5vDzAruUH4R48u/nmPpAN0 SVRXxX8B8kmAgoswA015IyX2l7Ffi/VbGKTBs1QzYyMjxV3p1rtiymARbWl7l2VYGW7wgw/8E5UHO yuMWp6rz0tfY/YS3g5CGyDg+k1jafe1aGYlQbPHo5ufRoJZ1f66yaUjt1AzoZumyzsSYzt4bT0Lgu CkAoWBrh6fDJry2ftDvbzC/mUT0bQk+rx7zcbBpGSvQgvaanTlqHheldnNf8Kk6sEaG2aOliFxSmq k/BbrEkxEy5xkONV8EUoibqBVLQkIvy02g6U8BhB+ARTu/weIBWBwBgH1D/1IOLRAwQfIxZP8DrKa zzt30kBA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYHIQ-0000000D7e1-1sbT; Mon, 29 Jul 2024 03:43:38 +0000 Date: Mon, 29 Jul 2024 04:43:38 +0100 From: Matthew Wilcox To: Barry Song <21cnbao@gmail.com> Cc: yosryahmed@google.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, ying.huang@intel.com Subject: Re: [PATCH v5 2/4] mm: Introduce mem_cgroup_swapin_uncharge_swap_nr() helper for large folios swap-in Message-ID: References: <20240729020222.36389-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729020222.36389-1-21cnbao@gmail.com> X-Rspamd-Queue-Id: BE2FB40027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gn9su376xbxjqrew4kk657dn7jw651ma X-HE-Tag: 1722224634-522221 X-HE-Meta: U2FsdGVkX1/r7fhnORigQYT0XL1Wtmz5W18onOe9yZ6r0EkbWwFdd4EWJ52zg/c9++HDfNXUq49sOTvmmw7xauQXo9UDmzyRJa2w/ruUCwoZDdfnOcXnZ98Y3+2JvW6ZvDvLJ6WA2V2XzSROTNJpZXA8XNE+qhxZWXQCJgHD+1hxHLmdpBQfbu+PX/hcJLGaTxDC1oMPvg6YgCKwL98MMEppS0Dl5+kLc8qC2oHEV+KAm8n2EEFZH+XtrMMY4GeFo1HV95ntZRt+iobqfwgmX/8mKY6LGC3ekjyTNOfn7FbcsxhrAMY5lzrwElVl9hEZ65kaWDcr7P+AGSvAbkKb+MbYmlJnGxw8wcJfQLL25oIt2xjgGhrsNk0AwzTKxgfAmlJCmeLjLiYCy2VFBEy4OZPiThKNb/eL1WfbRgDJonnOXOhuBhg38dQxUOzu5a3nYu2OqlHFrd49G5tufiZIWz+W8sExoyhy7tm9tqsmYHaC5MttPyeILK2wSVUkxPTo1vIdp1+qvfARlKvku6cBhd08D0CbtmAnMnT7/THer+6Zmb4GaT2rU4mdxmbztuS2PZ7D7zeSNazkzNRH1si/hJxNCDLOnwonnVkk46i33h/RQUMCAhbvXC4XWbn5R3he+fRnpfCfDnOGvehdmDdFH+AWtut/mHzLZwu/SgreifQCKk9qBZDqpA4bsnTmAPKYltYPHGx8dVwdm60gdQo9DSTd6AXnSVyESktTNlweTGnUy8drmsRtO1aKEqIm7wFd6ZwLvmUX2ZQEnxr2QvF7XAk30+Q+khEPPayi6QPF+Bqc+IomVpCIWFyNm5rwo+bvYQEp54ATCt/k7dOea4GDYcSSpg0aGDoXuYdoIhsCdhAiqt3xy4JB3fVMRZxgc38xahBLOInMxssZJSORhpjZcl46mn9Y+irmphAxaW3WxQMXkKKXxrX1ADSzFq6xAS9OmHzZdKiCkV69NoKkRGR HekkPZ15 w8sLzPxXjiSJHsZGXkl1m0s/bIrjd9yb0bp6mp/K6H/Dc+eN8cdhf/Y4tX1EU9NLbhiZYu82WcSRlssz0X3PfvrHwfm+HPNodzoP7hPFSe52qyM9OcTxF+4yNAyP39fNTXy/SCmRMlrF7wvrom0VTb+r6xg35SvZFwdCAU4u6B0KrDqwoTpd4CH+VFXQuI8Bk9Umy5FQdKMhI0Sh2HIWDazHtU6ETWuR98TtqPHb8R/ClCkHs0M1bXq4cSSfGD/xKb648 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 02:02:22PM +1200, Barry Song wrote: > -void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry); > + > +void mem_cgroup_swapin_uncharge_swap_nr(swp_entry_t entry, unsigned int nr_pages); [...] > +static inline void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry) > +{ > + mem_cgroup_swapin_uncharge_swap_nr(entry, 1); > +} There are only two callers of mem_cgroup_swapin_uncharge_swap! Just add an argument to mem_cgroup_swapin_uncharge_swap() and change the two callers. It would be _less_ code than this extra wrapper, and certainly less confusing.