From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC66C3DA4A for ; Mon, 29 Jul 2024 16:11:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4371E6B0085; Mon, 29 Jul 2024 12:11:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E77C6B0088; Mon, 29 Jul 2024 12:11:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6396B0089; Mon, 29 Jul 2024 12:11:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 109076B0085 for ; Mon, 29 Jul 2024 12:11:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A4D291C1823 for ; Mon, 29 Jul 2024 16:11:43 +0000 (UTC) X-FDA: 82393280886.16.8EED099 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 368C91A001C for ; Mon, 29 Jul 2024 16:11:40 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sTp9Xcl1; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722269497; a=rsa-sha256; cv=none; b=Z8FOnQ362fPlx6hEnH/ADQ315FQPpkht52KW9F9tC+5jzr2s7IKEHdPOzxiDlhMPUXW/Jh EIVsHjnjru9Ytd7S8wHrstw15/+Bq26EOVoEGYMhYKFdBO3E1ogMaznszV+5p3w/Xn7hc9 UfKmPvJrMWdensCVQt54faYbU/9E2Yc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sTp9Xcl1; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22cce97e185fdc5e0b5f+7645+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722269497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=biFznc2Qk3fSa0fTy3cAGb+McXgGU5nJpYsuEccoPOw=; b=yp6PesRufA9WlsHRUqYJmAlCMMR8ZJ1UhFkJQgO4N4kQwXMcwREr2Z1gs6Uxp4DqzRpA/v hUktQWfrU/hvk5/OwG/LdF4kbxA63F00Q6/2S7KEO+S8zK/J7FLaDQUK8iFdUv3vEVwmMn BIVc9Imp/+rxx7RzGU7GtPMxiu1xrQI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=biFznc2Qk3fSa0fTy3cAGb+McXgGU5nJpYsuEccoPOw=; b=sTp9Xcl1SMPRS5wM/FYYNInedS IbVy1u1KWVzmQjuzthx57pEkmC1oj100Yo4vxoR1npEZiRbcEKomiR/rM/OeCHbrInkR6VZ72E0LI e/bknNteJrrKjLPqgF8lhQOd38IoPpbey41fujnCT0IvWR9Qco9LZ/0NDH67n1qc9MourPUR6nLJq wTBzglB3WO6IX3hYXbq+XU6VhzfJbndwep9MnyPPCZdATXTM5OicePRkioD6TYjdUa0DLo0PFxUlG K4qlMyjX+RAfgzfneP87g2dAiHXd9I5AC1l7B1NJR1ejfTBtGxD+qh50vWdSSf8qPL+6xkSnP+zw4 l2OSL8mA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYSyD-0000000BxWA-1zi7; Mon, 29 Jul 2024 16:11:33 +0000 Date: Mon, 29 Jul 2024 09:11:33 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com Subject: Re: [PATCH v5 4/4] mm: Introduce per-thpsize swapin control policy Message-ID: References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-5-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 368C91A001C X-Rspamd-Server: rspam01 X-Stat-Signature: xruuy8w6acuc5n4pkdt67653f7wyuyfg X-HE-Tag: 1722269500-874667 X-HE-Meta: U2FsdGVkX1/njPdiRwk+OBzNwAiweTgu8NqE86K+kl/9yYiB8pfUGQq9nQD5nbn/8FXQtbT9xor8oEztaf2MzHaTEElMJ2A/CDtHnLlWwayY0XY0mtpTtKoe4c3PfYzQlZHXby9dBBlARC49M19tfEMYgNgbWwMY11rPNt0rqP4z6uNpufsH5RzySG9rMoBOa0+V9Y0q2yg7ToZYZjTLYiHqZ7GYjr98PqzWM7zR3OyNt7TDFyEvjK1tKZi/lt9PIjjKUNrJFu1h5R63rbLRkT/HtljATwpMCeerrwTgQ7vW6zJjOJhSxY5EC2VaofC4WrDLbAufVRbT7q8jaFw3EMTooifETy+0t5Kw2bKD99EW1hm29XL8ycc+VKA4j7NQb995DApOEghv44RWZcPOU1EhbCH3xccE0QmIzBcmEtSBHa+MJxYq8e/h6EFGgbF7VlNn7YZcr7xhqebowdsQsfW6DF862B16NIoAmPiPfuJKTBMku15ZJfRzWP3B/dSPyPsK7RfUYKKJh/ue/rR7dhvNa1fBeznYAzRDdEmc2atMK/sblCY5CKu6GTNQcKyG6n3RtwomgETe8GjKcWj6jM3RCF4JJ/caJ6UYcOGO4Gp2vIexQphO57fe4EMA11Q4Sh3BQa4WHwywEz9EdtcSccZ6BYQsWd5X3cFyALs73fFg5v7aE7JN9qT9fjcvWh3Yf/AWEG9x9qviqdXFDJv6hJZLcxYQAaeHJhJV8OO0DwgDsOa9gQIWjA74cKXmnUk8wrnIz6Jt/tWMoI6Nq2NjXBLsfMXPiXMtJNOoEVGhLI5iK/rNutUHDyWXxoUrCd39Q7z2d1L0gJ64JEdjx/Jxt3bbsd5IOMc6+/BkEi8/y0Ust8KxmNl4Wie9DGxDOoyXeBcv7GLok4DXvBFv86EWcn8VEflKoPwnouD8iyo4pUkdWlsSeOxegeOM09bZBTWCt/X9sJM+yA3h6JEZqca nkI1PHNu Ws9VrqO5VRo3PnHK7O0O4P6SvFlgbnlsYeJjickFqbIeaL4b1A6spW5VkzTgIS+w0gsUSctKRseMLPzNVUeNuDFoL9Hr0zJHZlbI0SMN6T4bPRgPdoBxwRQ1/leu3w4JoB7c9L0SLs5bbXL3azYmk9yhnAdaPGoJIGBg6CiPZZ2nyEY7+3ZNw3xbPx8Naa8WeqLoIkBv2w/Ij6Xi83CIXkPuRLVv8k/jlBhRE/GABKhQvULxZSd/ViyfV5IokSGIKXgRmjT8JXL88qvj7cQDAGMkRCu4YnHTKSd/5/PspOz6vxMDOQzXU+sc4CA3m2O22p1i6HQeOAzC+p+6Jgy0bfqOoArZHyvyvgpE8sq7nLG+9b/muZ+j37Csf5fueMDnOnJkgaFkolMCg5AtWMegjCQ/w3INaY/olLQodVH6XFJsnbA00P14VtTDDS2ZVgjmdivIQbvDl2bHETQc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 04:52:30AM +0100, Matthew Wilcox wrote: > I strongly disagree. Use the same sysctl as the other anonymous memory > allocations. I agree with Matthew here. We also really need to stop optimizing for this weird zram case and move people to zswap instead after fixing the various issues. A special block device that isn't really a block device and needs various special hooks isn't the right abstraction for different zwap strategies.