From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEB5C3DA61 for ; Tue, 30 Jul 2024 03:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91D3D6B0085; Mon, 29 Jul 2024 23:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CD056B0088; Mon, 29 Jul 2024 23:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB5D6B0089; Mon, 29 Jul 2024 23:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E7F36B0085 for ; Mon, 29 Jul 2024 23:11:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D903CC01F8 for ; Tue, 30 Jul 2024 03:11:36 +0000 (UTC) X-FDA: 82394943792.28.D4836AA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 9FDBC1C0012 for ; Tue, 30 Jul 2024 03:11:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=luyTwoTY; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722309042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7pYRuLHYBWIN5u3RA3hPR9pIartGYjIePiVtVVFf8qY=; b=dNl3Spuy02mdMjZEV/zKnuEHz0in535GKQkMW2NbnkT+Jp3YS564rCC1HTtLK/Gr6l4bFR g89A983ncjwMzAmXOoUXAXXMcVwAFVwbntfsdQuMjtPhUPfcFTAgZN/WLskLGreFzyNxkp iWMOSwuFgzTMMrhZHxQCOh0G99O2VkE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722309042; a=rsa-sha256; cv=none; b=FyP0+9voGA88EOAqjamIyDaUydMdOupU27NpYjnZFkd3eIzxxj6qOKy2hsL1cxRt46CT1a RkT2qjnCab/aJgL72+j73tySw7haes7dzMyVtA7HCmQQSkokHDSJ8N5d6hyj3g2uk5Y70h BSNKBgI5o84sPou3xF/CPh2LMVPdxsM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=luyTwoTY; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7pYRuLHYBWIN5u3RA3hPR9pIartGYjIePiVtVVFf8qY=; b=luyTwoTY/k8zFYu+f1V5+/juIH pN44U1XrrmTn0k2RW2BwrvKPrzcZDmBDnV6QhByC1H7CgMnfRUzJC1CJ05BiawjcrLuCCEWXikzzP BNpWbA0K7ImdmagJqipukNtMFk0pFO0zj8Daju/soioOlNNLvivpp45bU7RjDv7kQxqy8YTSJ/rqJ IIUblyEfdPSQkDNytx6AYmBuhdudJA3rfrksqRFjA3rN2m8LHvmhuwUgRYm0B38sdzhLsRSE1Sc/k NvQC6UR+YyIDAtnxuq2G9belP4SkRkfk8FgGr3DMeZ1yf6HHwoZsMGFVbxwUgP4idWszi7vxVWArU zZ31Td4g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYdGk-0000000EEB4-1sTs; Tue, 30 Jul 2024 03:11:22 +0000 Date: Tue, 30 Jul 2024 04:11:22 +0100 From: Matthew Wilcox To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com Subject: Re: [PATCH v5 1/4] mm: swap: introduce swapcache_prepare_nr and swapcache_clear_nr for large folios swap-in Message-ID: References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-2-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726094618.401593-2-21cnbao@gmail.com> X-Rspamd-Queue-Id: 9FDBC1C0012 X-Stat-Signature: bb5yjskzc5e7seoxejxh4t3sigm4to6f X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722309094-517794 X-HE-Meta: U2FsdGVkX19PnOc7syks2RWC4bdJ/rKgwz1KKl5c25s8NUF6ZxStvpYA6+nM2cFq8eFoEi6r0sjyN+WkquH1uucLwEMi9RuVSleiFmNIk2f6y61yFIaQm+Uu+rChLnUIE8PWeF6SoF4RDuuYDC7lNCRPn9LY0aU++FwX62ImK8w2cMtijNZK7Q0lxmwdNVdKdqvwbsPR2Rn+jZv+QK2es2tzWD8H0EekDmrA7wmjxcg6t3AZ3xj8nKTLR7xm36bQnjd2M7qWRuxUKExlBIS4liNmpnAuoSE5GJGvvFSaWXKkbuB1bMc0ptTkJHtNDjHr3nOWGO4Mud68nBeXuGt1ZRPFszYy//XkSe8gPYAQiTVOdLxtUzu3ya/iIEQEe5D1q8AMXZBPzQ4IQFNd7ghuZYKqx1wuXpbqQ3AUzqOtIg827VYgtfuLfoFr9vu0Ll3QtkpdPzwANUqDz6iJ+mBxAOUAAFCPkTmPOpcxqmwFjHkjTbYeb7rvgIfs4qpzouq0Mp4JzbN2jspDXf+pvTI5OyNmLC+MSfPA5YVhY3yWQSSmhCOn80clb1ppw3g82BWKymiSbFrbb/BfoktIUQzhZ2FxzyCknkPcyuVss7AODanEe6qvolv7sSbVFzy0F9CxDZvzSo+IpibL2RXP7m8F5/CObqxCj/JHRc9MS95uSFapKXN64DKarHzFPPcG7RsVdBoft5k5DHk3m+Jahn+5utwnVvOwUOC8EeFx6+U2fCgzIgo5eDf+RvpnX9MBZXsF+IAq1dPwPIMIbiZgaFm38h3dnSUkVs4iKODEWpxKXjIf5Hm/OPa8qNljmoeTG9blo/NqkoOMDvtwITHD4jHgsRxgIA6D6uWt5EC3OJyHAJWYehj2RYMpIB5ywn1aTpkr/+QkZZTIrh5NpJwmHwjr+mCc2rm1CFTwozBALxgU9Fq4RIE5kdx/jEBCScFMmEWlWPkjq7gfif+tI8y5Ccw J70IEeD/ r7TvzCHZyuUMsqZCtAK48f4rMPhSuZ3/AtVC56+IvQ0ui9KIbth+X1CaJ4srFeuNHoCgpIDxw/MBAjhKtknvXWyCV5J7XRf9QErwkroPxghUkzGNmN08p8HgnYqKz7zUYo/CYsYfWZDpVcUTo1nLgHEejvFCw7sn29VvTl0Vz9e9TV+qKfZ8VGeinrx8bNa01fpd7eMvg8sseh/RxRtCEgV0Kg4T3ASQaOH9CDfGEmPdD37rfleOvGDvtZmcA/k3O3SWI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 09:46:15PM +1200, Barry Song wrote: > +static inline int swapcache_prepare(swp_entry_t entry) > +{ > + return swapcache_prepare_nr(entry, 1); > +} Same comment as 2/4 -- there are only two callers of swapcache_prepre(). Just make that take the 'nr' argument and change both callers to pass 1.