From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7550BC3DA64 for ; Wed, 31 Jul 2024 15:10:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1272F6B0088; Wed, 31 Jul 2024 11:10:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7A76B0096; Wed, 31 Jul 2024 11:10:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB9E36B0098; Wed, 31 Jul 2024 11:10:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C89166B0088 for ; Wed, 31 Jul 2024 11:10:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7E491A4E60 for ; Wed, 31 Jul 2024 15:10:53 +0000 (UTC) X-FDA: 82400385186.09.E31C263 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 1827C18000E for ; Wed, 31 Jul 2024 15:10:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HamQ6Tch; spf=pass (imf24.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722438596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pE647Oyv/9XrpnG441AdvI7LpgdUAc4K22/cZTG/d/Y=; b=aZ5UUQ/yNOx4muiQKN9eTiyjAuK5E0tDJl6s/lv3SSXfoM/xC5jn4AR69TklooSJH6w2RZ 3svtF1JGVQFICOLJercQ6Y9C3Jbos8ktGMx4PqTbNNaJ08JkqZ352BU0q+Enwrt0o5AtkU VOXSWwhuxhBCxZz5nLGuiI4Zza2mfLk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722438596; a=rsa-sha256; cv=none; b=bCqDpDomsqoB49sBAbKK1XlePlSUHVBuuA2zYgjihzqyiGhf8+BIAecRIEegGHcVJa3Jwo HiIttTbasQXPdIAePgCN/wX2w14uXeoMsBeW6Ws6RK1UbgE7nNX66H78IRZ6CbW8yRfPft UfIWQoKpAPl5Xv3FGH1jPODx9OiWffw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HamQ6Tch; spf=pass (imf24.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5203FCE171E; Wed, 31 Jul 2024 15:10:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EECECC116B1; Wed, 31 Jul 2024 15:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722438646; bh=Pf8EjYSKJ/t5a9MR9XPy+taLRYqkt6RZTuscIRz+QcA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HamQ6TchVsbV2G8qMAkTEObyvhg84S2XI6zpwTfCO/ak0HJYKBn0zf+CI+HV5Zpm3 dmnVZsC8SF0aezKnKu++vvmm4wF+Rh5vksQU2tGldNyJftnfcvl+lja/mXrkiTvTcb hAWsd7AeeojDBHNLaiZ0C3tA4emalOL50S0aRvg3PrEiRgPoxgFoYgAqDNSEdXVR0k v3zTk60rfky45CTKHDf3jOkorj1SsmPLjqbqKrA1nx35c6hs4XT6aBNGLzzOvgh2K7 9+v4UIj9ue4p9TO+vZrRAts+Wny2qjIrZTsSJPIkKih2U/pfqIEGQkPiQO93+tv+5B je2MOKc1+Xsbg== Date: Wed, 31 Jul 2024 17:10:42 +0200 From: Danilo Krummrich To: Vlastimil Babka Cc: Andrew Morton , urezki@gmail.com, hch@infradead.org, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] mm: vrealloc: properly document __GFP_ZERO behavior Message-ID: References: <20240730185049.6244-1-dakr@kernel.org> <20240730185049.6244-4-dakr@kernel.org> <20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org> <4908d9a3-8b04-4808-8190-c1b602cba9dd@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4908d9a3-8b04-4808-8190-c1b602cba9dd@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1827C18000E X-Stat-Signature: bfy9x1u61qjjr7t857c6ec7mj3h3ehbh X-HE-Tag: 1722438650-335030 X-HE-Meta: U2FsdGVkX1/Tk1DQzPPf7dIfYA5FnAzlC3Uet/Sl1xxPXWqK5sDnVpt3suOCDbYfuZDLr7okZo6ayHP58rp3EiF5KWdimy6aawXxRrFS71BjD40eQTES4SzCwJ0elQBQe9eyY/z1+cQiiMlAdaAYgS2XRW5ffNdieLLZMevtSeaSYSdK8O8GC4EAyb00m6lsO78juU+3oUNOXkfIKqUqC5kLp1SnLBrU/PAEJEgmjEGEA2cu6wD/i3sfAGbwRMIeT/pQrV7IGsH7+X65PVp87SJJ6H/S/IcWUsdriL84aPhbqPFYrZN4F6k2xzi3XfxB4d2yki1GpLGDib7aW9jg1US+P/ENEOR4sjE06+zAQU7m1QiecRGl3otp8IXH1pZbmRr6MfwWBSmzZ6x5vd5hPRIQzUTL+EjBbmLONDeX6JTgZ8rc3Qn2KaPycqTb/ocYvBjZ18J8TLzuyrdtk5Y1o+EW+jh3n8lduzDjUrnRtqcgYfPPmzzzKHPV5hOpl4us6Zq9E/0Dcg0SQvve2vHicSd9iTa7vsQk4Oq/nh36qS6AnXt/ZAfMYNuT9GHanl/CskkJf2lkXUAvGfTLgMM6/wno68UP2iib9pEFkO91/g/+yRi4ONPdHpokE9FYacvWwP+UHtkPR4SwPt5QAzcPRGPV/Qgdl2L0Gq1lNyQYARvQ1JRlG7tArXC8flnZI23usPofs29bSafP4XdyosMY72pft0GshLnIDSUJ5XSeoXt3mN+kHxjW1sgPjXMsKr6FVGm1GPoIJ/yUaV7S7Bzl0T4zNfkjk6rRLLM05EDjqjQRQ5hsGlkFYpI5m9ZqbRMsCaKiOB0GfCKAi+7pSJfpQ9WYbUcBn4e3VYjqgfRbTbRiNicCJWuD9YXITfJIou+pohDkMCAMOE8a1dYNUkHVFs39uKxzl85KjrJDtu4Dku0jr9z4inj1hm98i2x/FnMfXxSRnePLG4BSGbGxkvf QA8Lt9s/ +8o3QjOHKNWQEZuebejpDbG8XUk1noFee3T7iFEqv8hWBxBucMnQXsxlm1SddJ1lQc1muG65cvc+ocRROLZY5JwvF/81LRDc/9arYRn0X2Y4tR8Uc1nUtBmDWz4AX8n9Kop4cEV9DsOsBJmTkLuk6IzNzAghCMxJDq1hgxs6Tu72bGJGKJjrRmg+c7F/kLHpyCUgtfR/QVWRVsMwxeJwHEuWvflaKCy/8Kh0hv8KRFmB9I8vkFZ+aa6hHwDuROtAr952rMVJzjxm0nFsu67Y1gKnO6mercq/EFgxiW4E67RniWWQQ64V/8vZ87hM0W3Y2aQXq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 31, 2024 at 04:43:39PM +0200, Vlastimil Babka wrote: > On 7/31/24 12:43 AM, Danilo Krummrich wrote: > > On Tue, Jul 30, 2024 at 02:19:53PM -0700, Andrew Morton wrote: > >> On Tue, 30 Jul 2024 20:49:43 +0200 Danilo Krummrich wrote: > >> > >> > Properly document that if __GFP_ZERO logic is requested, callers must > >> > ensure that, starting with the initial memory allocation, every > >> > subsequent call to this API for the same memory allocation is flagged > >> > with __GFP_ZERO. Otherwise, it is possible that __GFP_ZERO is not fully > >> > honored by this API. > >> > >> I appear to have just seen this, in a separate mailing. > > > > What you have seen in a separate mail is a similar patch for krealloc() [1]. > > This one is a fixup for vrealloc() from a previous submission you've applied to > > mm-unstable. > > > >> > >> Please, slow down. We have two months. Await reviewer feedback, spend > >> time over those changelogs, value clarity and accuracy and completeness > >> over hastiness. The only reason for rushing things is if a patch is > >> disrupting ongoing testing of the linux-next tree. > > > > There was a discussion in [2], which lead to this fixup series. > > > > In terms of changelogs this series is indeed a bit "lax", since I have > > recognized that you queue up fixup patches for changes that did already land in > > mm-unstable to be squashed into the original commits later on. > > Some of the changes in the fixups would however ideally result in udpdates > to the original changelogs in addition to squashing code. Also with 4 fixups > to 2 original patches it might be IMHO better to squash on your side and > resend as a full replacement. Perhaps also together with the other 2 patches > about __GFP_ZERO for krealloc in a single series. As Andrew mentioned we are > early in the rc phase to afford this. (JFYI, Andrew applied the fixups meanwhile.) I also don't think that they lead to updates of the commit messages. But yes, we can proceed with: (1) leave [1] as it is (with the fixups applied to mm-unstable already) and send v2 of [2] (2) send a v3 for [1] that also includes [2] (3) send a v3 of [1] and a separate v2 for [2] Just let me know what you prefer. I'm fine with either of those. :) [1] https://lore.kernel.org/linux-mm/20240722163111.4766-1-dakr@kernel.org/ [2] https://lore.kernel.org/linux-mm/20240730194214.31483-1-dakr@kernel.org/