From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68AA4C3DA4A for ; Thu, 1 Aug 2024 03:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDF7E6B009C; Wed, 31 Jul 2024 23:36:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D686D6B009D; Wed, 31 Jul 2024 23:36:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C08EF6B009F; Wed, 31 Jul 2024 23:36:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A15B86B009C for ; Wed, 31 Jul 2024 23:36:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1727F16087F for ; Thu, 1 Aug 2024 03:36:00 +0000 (UTC) X-FDA: 82402262880.06.9E1C697 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id AED07180009 for ; Thu, 1 Aug 2024 03:35:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kFkXLDs+; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722483314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlwpK9U6TuXGOvkD7uqz2mtvB263qVdMN2nixeBYcks=; b=KOjnoJR3T48HQf2qFUcoyE0iPpKk4THXwYSn/sUkjGAZD0YYsM2hxUAPPgWxnlPupoG7Ba yzLos9vF8CjTt0zPzkDoZI6GG78YcJlgzPTv8hXE2ZkTXkuFOwxCoNLtI9e3lnKwd44nfu V9aClGXb2zyEhj79FvURN0VnbFH/eUA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kFkXLDs+; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722483314; a=rsa-sha256; cv=none; b=yn06o7fyIZU3aHID/wXEVeA8ZWGCYYQjeyvGwVXq8DSBFO+MQ7RCIud0of4BjwOigDnZDT 0HCJyy2A3JKnW7YcHsEmC5nTJ2+4/oQf/X6i6xLYZDUr98APuz3uFU9l1VU50b4+LFCNS9 cAoIvUxjuBqr4mejBmomIPMd8hL4Ofk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HlwpK9U6TuXGOvkD7uqz2mtvB263qVdMN2nixeBYcks=; b=kFkXLDs+s2g5TRWrcWJXtGgXex xIumqTI9O18RcKHMj1wMlXhpdDh1DHUu9OHstHWvv1CBGfds+qNPk103wk1O77A0dWDK4ubzF//jL P2sSZr0LxaOX3H24flSTfjVagtztXapHeVi3ql5sv93xNW3u72VkLMPYY/lSK3fdgMWN30dVY6ja5 Dw+7gDMLcxgc77MM3wuymbmQ1fCU/+GaZQKnil8KC9yC4DnJxogCeXDgmqwi3JUB/zWqRQnkfedFW 18kWw5LjqpBtwTqHtJ/0IQNlJWbJ+AgUG0fpbJfAaWIxX5KDSUkACsFmCwR6ZgKe1+MzRHFDuOWJH MLfgMm7g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZMbV-0000000Gvqc-1AdQ; Thu, 01 Aug 2024 03:35:49 +0000 Date: Thu, 1 Aug 2024 04:35:49 +0100 From: Matthew Wilcox To: Sergey Senozhatsky Cc: Alex Shi , alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v4 22/22] mm/zsmalloc: update comments for page->zpdesc changes Message-ID: References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-23-alexs@kernel.org> <20240730093726.GB16599@google.com> <8fc7939b-416a-4328-9df2-488f17783543@gmail.com> <20240731021619.GD16599@google.com> <20240801031304.GF16599@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801031304.GF16599@google.com> X-Stat-Signature: t1p6d13srrsqgu3zk4b7emhk3gqegi73 X-Rspam-User: X-Rspamd-Queue-Id: AED07180009 X-Rspamd-Server: rspam02 X-HE-Tag: 1722483357-564647 X-HE-Meta: U2FsdGVkX18PvXXtWv3Tr2dDqldxjXAD/XEk+/9ZsS6rXOZREMnJIYVWq4HboBisq6XeMEEe0t8lzugxfsqOQQPKTN0yeFdnpoLYXctgi8uHqBFKwmOUs8QGf2Y55/76Shj5jJBHFSz6f53tIwxSW6CCrvG/m2k9bz0+f71Pq4bSELB6FQRlXZRXnS39+xt5999HCr4k5/Ij3kAmgf8POAsx8ITMw6KiWMKYhmC6Fa0AI4jQRegXvRtBZjeE3up9aA0royxBJfgppjpFf7SPgEzmPewH2Ay56/S6niUXH+4io5G9t/uEghxNFqkzhXa0u62hG1sGym3ZSxRDoY6pCACjgGYYg7GBVPIlpmOJhF0c8bOX0JThj6OTfyJ46qyOqpFulOzY5mVdZyijiwwPacBWi23HE0QQNKM5RT0xttMHHKbYoVZSfyTBOJuBj5MQ1w/Vv/gl+zvH5wjpc3zcjAV7WnB2E/h1CB+X+x1KbJlvTvjkT0N2aJt6Q/tzqq9xzILiZe0ieHjhH1xors6gsd+xVS9xlsQ/++hz7xDiq28B07G9nvUHW/BI8NbpDT0+mxaJQ83EjNWW+Xftg6jm7bXlX35mKOr1doRp18iYfb25W1SNBiIs3N60M0clIVz+y3FcGpcSEeQdVHJClsSvO+zZH6wQHRYNqIgT3fbK92tRWZpZyuIKkeKKBdNXrLh7b67H+eZYnLifK4g/1jShJ3uI+Az8TTkATavbsFlK7N6hWgtODlTba9ONbqnURODP/jTURt6YOd8rBu8QpfJd+hc4U1aIyunj2wbLQ8x/WoAes2C2XCMKDYxqTHgVkmXlxN+zyLAE0aI8tRWuxdO4ib1pcv4aOiU0viGBdMnLOgxT1gl+yzsk3ommV+G0KAIsIM9hhL8l+Eh79IzRDpObbAaQMPHCUXd5a2Fr0tYBaXU15POwhMFct5dLJBHKg1KoS2bAgW23vbZJpVvqe+D BesT5t4w dlkywSOgcUO+hkZ4bl7+mscgDAFy2bbHTQUOXT8TCWZ2AfJje/S4MxZ4ppuFym98ogaTKZ0T+FqynM4Q/7GTX29QA3dA7asyQE+hlzJI7o40m0WD2M8QN/yDMeD5aNiEGwuVJ/GvyNQDvPTEhBvHPaz7LVPjFoyot/ikL0/G5tAj2x7/VHlRI5PariGcyUH/PGIXObiJtQ+Yj0WB56geUqaSdzNpPle4MAWs1fT5IBaTQiVaUCitA5lNHxFSZ5LWjKOSIMtawHHvXuy/sokhDnpZiOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 12:13:04PM +0900, Sergey Senozhatsky wrote: > On (24/07/31 12:14), Alex Shi wrote: > > > A bit of a different thing, still documentation related tho: do > > > we want to do something about comments that mention page_lock in > > > zsmalloc.c? > > > > Good question! > > > > There are some comments mentioned about the page_lock in the file, but missed > > in the header of file, so how about the following adding: > > And e.g. things like > > `The page locks trylock_zspage got will be released by __free_zspage.` > > Should this (and the rest) spell "zpdesc locks" or something? Or do > we still want to refer to it as "page lock"? pages do not have locks. folios have locks. zpdesc sounds like it has a lock too.