From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3402C3DA64 for ; Thu, 1 Aug 2024 06:11:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BE386B00A8; Thu, 1 Aug 2024 02:11:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 747406B00AA; Thu, 1 Aug 2024 02:11:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59B316B00AB; Thu, 1 Aug 2024 02:11:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 361E76B00A8 for ; Thu, 1 Aug 2024 02:11:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DAAE41408BC for ; Thu, 1 Aug 2024 06:11:19 +0000 (UTC) X-FDA: 82402654278.15.EAD921C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 006261A0017 for ; Thu, 1 Aug 2024 06:11:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YTCPHZH4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722492632; a=rsa-sha256; cv=none; b=j++Zu7B9bvPsheERIgrUS5Exvhww832bQrrJy/5w79PlytIgrqMDo66oXaTg9h/VnY1Aa8 It+UMtxzyIF7TGVdhZpVO7xuI3KEMXawCe7RH0bGB3ccFmQUOstX6c+b+BcTMjZpZp8v5p 6mFinxykRTXV1EASJ6PgXk6wYUIE8eA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YTCPHZH4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722492632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tQ0yGk1s0jn9uGjOqi3dgYvr0p4GuE/7Ib7pfuMP9ag=; b=miVOxJGXt03gJ93QiWybslstKRyGE4XILWyM7897HHZyhjjPthtJzUW2wv/gyG8Hnjy4bv GWZ+Wbyfpgo73YYSVga4GEqOgNkgB9VjP3Mb7hyRy6FykYTcffxYj3ZUFbFG2UTRyXL2mY /xQ6vPiOFn4D7fLpqMqO2cfwYGto5nQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2DF776140C; Thu, 1 Aug 2024 06:11:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8639EC4AF0D; Thu, 1 Aug 2024 06:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722492676; bh=F7glOAsYhDlHdSJ8EVqbQdYGQGstaUZBiVXnAKmsuNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YTCPHZH4rICXi7konJET3SbLcbfe+zM9cWf/0mYWAZnp6Oc+wpCCVb8+xBTHIWrw5 jTBrEg9BlyM4E6XsyMJ7SaV2OD/B7WUqPJbko03PN6PywaI6zrLSfJyf40zbcca+qX QdudLa1RKt/atOgd2WqR7W75r2MI+nABCn+xXP56R27yo8RX7JPySyy+eKTgjq3BIo EjJaliUHBm/WFmfzbVbeE8qhKSCTLZTBCQ4Gj01OadVBnnqlYtnv0SEHUppaIH9XtG MgfeU+aHVfejs66AQDaGCDj+QQ3aJgJ3cl8ZlDuHyPi5PzJW1P1XRJ6GRWCetxu30V Xy5YYTtFdgJFQ== Date: Thu, 1 Aug 2024 09:09:14 +0300 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: References: <20240729014725.29839-1-richard.weiyang@gmail.com> <20240801000739.lrgmokbbgvikrlkw@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801000739.lrgmokbbgvikrlkw@master> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 006261A0017 X-Stat-Signature: q9byrfdty6jyd9gauqmc6yyxyr1tb33y X-Rspam-User: X-HE-Tag: 1722492677-698387 X-HE-Meta: U2FsdGVkX19pQWwUENaIAWOIA/EocSpTTlnWNsGs/9N3tiDT1gG/kqqSf8eG21TjzUWdIPZkLxBibr1JDhRrFjx+hcIUmmY5utPo9JtnWkZ6F/y3TmpbdFxLPIeZcj9P51u0jrmj5AFcGJ0K6iOLhG6zQN45Cly9Fo8xZt75Qg61PsYd/vF+n54XSQZqsd73126rnZKDKo3c/KXohzpUlMNXJedV5FNvJ6TNtD5+EIsbTNx9y2lS28akrI0SCJjXes2gPEHDaIH8rleLDoC1vIJeEtshBhawC1Hej9pDT0waqu3vIUJAoJ+Qpfpno0Vsx1J/MUej0TQMfLrfKE1LpVNDico7PUlA0NfNRxyI7p/QCHt2OOIm2Xs/CtWHaeKLn1Cm3saj6/IgGsaI5xqshUEJaduV/++3QkfOVI7qU/lCRtRlxhYgiKWAshiYdkjvA4+T0Jr2MmbUW3QbA+KUCj2/H8qJBjBxqGJMWV4lzDPYVWkKO+TIkqJPMOxrI2U2FFzj967yEiONFijKt+2omofb1zYpI4ulR+Vbzp0RRHgTrPxpuqlEytsQh67aaq96F7ItAt2F1Ip0q/QmxmQLQuONAYBh+x0H/KqWpZAh9nupdhoaTiNPD/IDNlz0Dg6W1/c/5hpmjAGWiuJtTfd6tHazLMlWN6JrMG8ncUIlxgP4VfbkTy+XxOIuKvmPo9puPeL7V+CPe8JaJe0ROaTHnwSV+VWKi4LocSI3KWQ7B/5yTlxllE3W+l0JG+SA8ziW8+zAIjlFtpncNtJwgiBzuh3jIookNib+mOUNtWaoGGEEpyxzQjOk4DB8tTbfqKtp7up425VXG4ODIo09p0yLkGvy8bJQiwzi94GYULF2+p8FAhJk6KS5P74+LSN/pqvxJ/kqwfYUi2GOhqGYm4vufCvgo+UB/LVqOOlJpD0T1vupf9bkUmo0C+jGfkdPAaP/wlz4JPuBrLDPMuJ+6UW +P3EgT55 qGh071EnOztq0g2Uk94QSa8HBX3goC/1feRL9IdvTLF8jVuzhuS+HUukarQMZMdOikRhkJxDYNUtEaO2AO8B+GCz70r+kBeucFjms7ehE8pacEooMVlE5DfJs63lTKA5mZZtsD+K9xz5TreCrD5CzlUixlR4Oo7s8JpNKmUXnwZ3Ghg0KhAqRyxWXl5vfC47jW/zu3gsWynPOnC2RIBg9ZpIuBh8acHcjjLFIZYyidQKPTiwDXf5wipdM6SQ2Yy7GhkfcILwFwqXHdK7u4/QRd+UaTrW6R84WuNbTXvd1UlCWT0MzATr5CRA1SbuKRFeFRwC0M+WR6Ss2wKY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 12:07:39AM +0000, Wei Yang wrote: > On Mon, Jul 29, 2024 at 08:37:23AM +0300, Mike Rapoport wrote: > >On Mon, Jul 29, 2024 at 01:47:21AM +0000, Wei Yang wrote: > >> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys > >> alloc") introduce the usage of virt_to_phys(), which is not defined in > >> memblock tests. > >> > >> Define it in mm.h to fix the build error. > >> > >> Signed-off-by: Wei Yang > >> > >> --- > >> v2: move definition to mm.h > >> --- > >> tools/include/linux/mm.h | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h > >> index cad4f2927983..9db45c5d00fc 100644 > >> --- a/tools/include/linux/mm.h > >> +++ b/tools/include/linux/mm.h > >> @@ -20,6 +20,8 @@ > >> #define pfn_to_page(pfn) ((void *)((pfn) * PAGE_SIZE)) > >> > >> #define phys_to_virt phys_to_virt > >> +#define virt_to_phys(p) ((unsigned long)p) > >> + > > > >Please don't break #define of phys_to_virt from the static inline > >implementation. > > > > I don't touch the definition of phys_to_virt, so you are willing me to adjust > it? > > The macro here will be expanded to code at preprocessing stage. I don't get > how static inline would help here. Do I miss something? static inline allows type checking of the parameters and #define with the same name as of the static inline allows catching other defines with the same name. So it's common practice to use this combination, line phys_to_virt does. > >And please make virt_to_phys a static inline similarly to phys_to_virt. > > > >> static inline void *phys_to_virt(unsigned long address) > >> { > >> return __va(address); > >> -- > >> 2.34.1 > >> > > > >-- > >Sincerely yours, > >Mike. > > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.