From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8FCBC3DA64 for ; Thu, 1 Aug 2024 12:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F9056B008C; Thu, 1 Aug 2024 08:31:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A8E96B0092; Thu, 1 Aug 2024 08:31:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 298056B0093; Thu, 1 Aug 2024 08:31:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B3E16B008C for ; Thu, 1 Aug 2024 08:31:42 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B447F140D02 for ; Thu, 1 Aug 2024 12:31:41 +0000 (UTC) X-FDA: 82403612802.29.8896A6C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 06A0E40006 for ; Thu, 1 Aug 2024 12:31:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="p/qOH4gQ"; spf=pass (imf27.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722515455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UpgbRL5CeoPRLA1dA9LQEMWjzulgs1Oi0mHBeKv1+eA=; b=LsZ+9eamKt/6w+LIT7275yEJ87ro1sMVVK04tSkLQX6ZLjGfY2M+C9ESCPMnWbeh0hK1W/ Lwl5Rext0s8FGSoojiSBedqVYB1+dH+G9nmtK2/R+fCdHXVwZOwSN+J2xXnVro/r5C7Ywe WE/wKLdQiA6sjKkvkLRLI6H3Bx13qs8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="p/qOH4gQ"; spf=pass (imf27.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722515455; a=rsa-sha256; cv=none; b=DQ/aKfTpauPn1J6KNcJ7wb7m76F/yPiuN5sDQaaROUTKI+rvoZ3aJBf3iY0882WOxQ5RNT NmIDrpLdEkyx9hyib5r+eDjir2V3W/zkf7ckNYKZ1+wt3G/+T19yAoPnli1efXLb29aD9v nHQgsJ0oiRzVOHz2GKVdwRUbZ68hcbE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 495156284D; Thu, 1 Aug 2024 12:31:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F73AC32786; Thu, 1 Aug 2024 12:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722515497; bh=UK3PAqMjw979wx5Ie0BBTgUW7P1oxUk5LvST6rJ/ctY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p/qOH4gQEmTdcjwrP926auEMzokTQWEJWVzEZSW3aNPE357oUPqYBM9V3CytErj6x yFd5GXClcORsfuZESaRL4G8pkggB6D6f7jnts08B8xqtJV4pdRUyd4RHypLe0HKlZo AscXUgSSKXx0uBZAg/kZ+pPT5rKcz1oaBT7ee//CFRE73H4eJg8rOcwtKyyGXp3p4L lz0SwLxzwSwRCCcGoZt6SAN+fs0YujvU47f1SSRdL42KgIxCOegVU0svu/oDgjbLxt bmvgX7CbZsno2vZxvu4xqgVqjFriSVDL+Jw1xgHSPUKMpUZr9D0RZbvZj0tyTUWwsd r9kwcPnGux0fQ== Date: Thu, 1 Aug 2024 14:31:29 +0200 From: Danilo Krummrich To: Alice Ryhl Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 07/25] rust: alloc: implement `KVmalloc` allocator Message-ID: References: <20240801000641.1882-1-dakr@kernel.org> <20240801000641.1882-8-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: wcko6dzotuinjn75z1uw4ysp3xaugyhn X-Rspam-User: X-Rspamd-Queue-Id: 06A0E40006 X-Rspamd-Server: rspam02 X-HE-Tag: 1722515499-201098 X-HE-Meta: U2FsdGVkX1/AuDVsr5gUgDS89sfecH5rqx4VxiaIMqDlLAUT0XNmkhS4IZESASf0ptJp110i2/3Vrph6zNWpflRvPhikcvIeq0ybMvUUOtx7nG5x5UKRUsqjj2frPEKiMBuE1wDySUvv0mHZc6PMXDdW+0JFeMbbXDwtQy/pOVv4nq2d2ApvPvpEOMAbahv9eg369brRAUsAgMnlq9jISqheNVesZd4ocEULGpQ85rVNeGY85/+tgS0O6lDCcMTQF88xFvbsxjEfqYwKLjl7HFFhHb1PY36yiMbrfaAdx+jgV9c6JyBV2ZhDw9a2tkS9EdtomZyGcnfeMaIOoG2aK0c+Z/Xoui0HRkgI4mdTNKvseOoDnWRG0HyRceJVftksBta/HLhfap2aXOyqBZryuf2CsFh+rrpX8tdVBM8yIKxjX0bUmdi100nU7BFL1ws4OfkwePy9cNCjy2BRTOq0vLHbCljkA9iAuXEJHXaiVCkjOj5AZ/NMNAAxaMIIA1Pc58n244hOW6M9Z6eFumpf4nBSsORcIesGsvKVfiLXqGiPVkZieEQXZ+sW8jyb7S8ssYO55Rb6rC1ZsYE7SDD/jZAIKnlyzwphfLrXFXksauZO1TECwJhyQcbsImCvra9sCwE4k8mI7APrhaBgVoJ0taJO5NoQc2GSj1ckaCrW8dO+uA4mFnZ/xW1reGiFxRutT9bkH6j41ciodNT5OEEzZwO9rdHfvtLwmRGq7UNTo4hZa3exsuQ8hBIRKbSybIHiKKVKRIaCd8tcXZfMmi/s56eRRheUmzeijIIEuTQ8pqeb9yg6masq0ub1SIJpL3+hlf4xl/cKUy0tbeR5ftwD1yI9nWLascQUE/4GuG5Tx8PLONxUceAheDzTFMLYEcyvz22M5u85L+fYYkPHuD4PPYHJbQiSxoGMG+6rfxqzgDM9V6Bz2DhDAQRGNRjTrtybGLV6u6hqdWBl6KnNPPb FZo6HKQS gUQk30w25LIrWmFhhJq2cjGE1/BL53cWWWf5JCwgotdP0HhtGKitIgYejx5URA5ZbkWN8QqWQJHnddz75uGkWV1IpRQPAReYpAKV0yQPFvwqFp4Nm4AprslQwG3EYG99Z8bE8A/zVZRiSiaosTheQN8ei/f8OQ4cgbboORlSJ8mHE7lZTNOHxao1P72dfNiefDOvaMKSskR9lpgxDhoViMCOHB69ATa8q7/v9kep3Zo5LLDJwg1smLWwQLNWOBYvgdj3sX5yAhqUGK83arAYQ7mxNtQ6XsJKHI21XU+e261vg7GE8h8megp/qPkWRYCApbTyWgooD8MFuK28QTS0+CgCDPhkwMaYAQ8bqrbH/HRF4USTDEnRNKcOmbe7sEUg24el4PrNGAhHX2NEPDxnEuWMovg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 10:43:44AM +0200, Alice Ryhl wrote: > On Thu, Aug 1, 2024 at 2:07 AM Danilo Krummrich wrote: > > > > Implement `Allocator` for `KVmalloc`, an `Allocator` that tries to > > allocate memory wth `kmalloc` first and, on failure, falls back to > > `vmalloc`. > > > > All memory allocations made with `KVmalloc` end up in > > `kvrealloc_noprof()`; all frees in `kvfree()`. > > > > Signed-off-by: Danilo Krummrich > > The nit from vrealloc also applies here, but: Yes, I will add the invariant comment for both. > > Reviewed-by: Alice Ryhl >