From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565EBC531DE for ; Fri, 16 Aug 2024 07:20:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74A3E8D0051; Fri, 16 Aug 2024 03:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DFA18D0002; Fri, 16 Aug 2024 03:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43ABF8D0052; Fri, 16 Aug 2024 03:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1CBE58D0051 for ; Fri, 16 Aug 2024 03:20:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE60F41A06 for ; Fri, 16 Aug 2024 07:20:04 +0000 (UTC) X-FDA: 82457259528.11.B099F8D Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf25.hostedemail.com (Postfix) with ESMTP id CB8F6A0002 for ; Fri, 16 Aug 2024 07:20:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kogqdz73; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723792743; a=rsa-sha256; cv=none; b=p4XOeoouWnLJoYsTgQRgvAinFDB5PW3q2HU1g7vZaea84AKtvDtG8q8NeWBlACUWPQjbic iGTvpFgkB8g/0jgnRBUIaEWCVeTNzt3xS9zEErxoE3SmcF32uqcskuHlPNQZJWGnmHQT15 RuMvLwnlDccgLV99tSW8ZO496kyTXzY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kogqdz73; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723792743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BCDYMfGySc443px3vz4IJgiNfp6ypozgyP4rObiGgj0=; b=ZPC459weaVUh3DGVJw6VTO+nLqb8DeACFM4SZpHza3ipBFv9m7o/OwxufWrqAI4xFtcTZn iOCeSAym16ZVTy8SrpJCRMlW+AMLnwyZDDfEjgOaihJjjkx7gle3ynnFGEoqYeZuJH76Gg ifH+cWBj0Rmt+BLswhoWJQ8Sg1vp+1I= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-530e062217eso2219875e87.1 for ; Fri, 16 Aug 2024 00:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723792801; x=1724397601; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=BCDYMfGySc443px3vz4IJgiNfp6ypozgyP4rObiGgj0=; b=kogqdz73YjUb4ZoCWdXZonGGaF/Ep5gsmhDOintVuKrCIrngogH5RvpgI6TP5bI1Kq Y9GKghWdR89wLtrEPlnw0TdXbBFBDBLp38Q7WrWWbJR3eGUAO4a6YJfxdpKCd263/swz ZTnWKDs4jUBR4fyTrJO1hFpJxCItkmZHkUb9DiRjPus7IqjsF3GKjV5hfboRMO+odmSu pBDYIKelEeb5jjppDKe9gUAPHkE0aLhwVY1KIPhVwYBrO6zn+GXIaQh5N+GLKFKqrWXg d1rTMRRs9dFDzPfRClguvVYZJbOlgbznyZdcWIt8UlpdgdtBoWJTm4m/WI73XDLNoVaJ K/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723792801; x=1724397601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BCDYMfGySc443px3vz4IJgiNfp6ypozgyP4rObiGgj0=; b=k6CJhsbfJo+BwQt14oSqNm0+lf+kWzMyn84NVVqgQCknO12jh1GTQ0Ly/3esn1R+qy FD4ktxEyu7YE0WDsqsSi6panCcSeIrwlby9zJGQKldeYQ0nXAsrgkKkbi3oizrTidgbn pebZ28qlhGqNYFhLcn56zNrRyFLY9tMoFI7wG98j3IR28lJqm7hCrJG95ByJod87SPMg qVtfoIxOZ2rNF1Zuy+aWT+DjEx669VIQnc5ntIkEsvs1UyuMnuaQtSPdmCG0KuUaO83n HjNr2nKfXtfwJHD0oC4MovcDgQZbCsz4DibTgQm4A0YD9N7JKfzLDJOUmdrrhL7wDLdb SGmA== X-Forwarded-Encrypted: i=1; AJvYcCV+QdD5xQVJNJWu3N+wUCHFhVm5dYRvGhFiyjRgaSuos9wbDtg1ngmEuohEM8E3JGYn+W5qQx7uW83ljSu+DYpqFno= X-Gm-Message-State: AOJu0YyYTp1J63F034hC/M0b1JZexIs42GunPWyXHJjFIXgySd5xjt0h rnAEnm1oPaLcPUpXKP+9/ZF/z8sRMvb5T44tLoc3NoGyD5+R36cH X-Google-Smtp-Source: AGHT+IEMNiMu907jG2oLMbP8LWHs6njbuCrNw+PDgwS8M4Ji8B1T0eTn7Bss8F5WwbXir0Y0aKTrzQ== X-Received: by 2002:a05:6512:124b:b0:52c:e170:9d38 with SMTP id 2adb3069b0e04-5331c6b027bmr1363916e87.31.1723792800401; Fri, 16 Aug 2024 00:20:00 -0700 (PDT) Received: from pc636 (host-90-233-214-145.mobileonline.telia.com. [90.233.214.145]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5330d3af9b5sm471263e87.14.2024.08.16.00.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 00:19:59 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 16 Aug 2024 09:19:52 +0200 To: Andrew Morton Cc: Uladzislau Rezki , Michal Hocko , Barry Song <21cnbao@gmail.com>, Hailong Liu , Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CB8F6A0002 X-Stat-Signature: ymjnyd8ix9tpx58xnxbw3r3hfxcq5oeo X-Rspam-User: X-HE-Tag: 1723792802-777934 X-HE-Meta: U2FsdGVkX1/wLo8EYFpq3xp6Mc6U8WsZfcnyBzO8o3LC/HCFs5hX3Ayleum2oxOe8/JIP60FflIIddjOqpLx/1n8/QaqyAJ/G7A1pTceepyFy/wgf9EUrCeQupSggEmMqsgjPitVr8BMteMMUxTQ0OP4RFMH5Diz1QEqn9NwbEvUp2NQLaNVAC5omWJt7yxxNk1c/pzNBgLPiV7Rq65Nb+K53irz6hwfM7aP01b80OhwgmXSjgMthtA2M7eeP225Vwu/qeu+yv2bDVQjodST3qH96WjSsgFaSt2Vf3ZyogzwCLot0zMdTmMlDQJudQBtGawZDp4aXM1Vd+lRMcS5lORizz5zpQ/B5rnuidTVMwdh5n2JIx0iGy099LaKZs1AZ5n0m+IdhxDMt5R5s8Xt2bL2ftDT+MGi4kL9i7UB4N+6/l+4WKC6dnCygxnTBWwEsrAegIx/GmKjNL4zDrZaWgdmEQOxrLLO+Nbc/sWY7zCRuqVWhD2Nt0+YaA5mb6VsPtkVGEAtevOGFyYi3n34kZMZRNsee2EGkawPuvHxKeFG5aMOf59dwKsaFtITyxq1ch7sjDKEgQIeDrTtXd8XTgnwQIQ/rBEJBUciNQIsj8QNY/sG9ARp2ZOyzW8sJ8tkFxWDD1aWgIVQXZhNeoZL1/NcukQmAs6fHL7SaT2IvPtYN/s24uuJjcITWiwaeuRj6hs29Z4Gksx/yoZTZnCfExwb7yn/AQ5M2mG1WvU2KHH4sQQVseSxvw6zFKAW6bGtinm/RZmR3JhOTHyimSm+f0TR6Au32IW0t2xBa4AJItqgU1gTxdfHAbXaf4W791HCyWq5VitvOQOL8HkePvpo04FN61as1GAjckOpwtCzQrv2NpoDhNUzNk7BpXGsJXdkHzl9rRrzY/51zAemqC5iX8nnPcZmjkzuZQpjvmxWICY/tmV6og0kEOYzPpcPVwGXyeJgQadPEk4AzMZ108G z0UrDaBt WKpA0+tglfsZDOCh6YfXieJ1G4zkhRtWIjwWABfMdK6V98NzRghcgDypN5+6WqQEAnf08NzdMXi5g27LLmF/1xVbevju0wlngbiHFJyEErB2sWqwbeLM5Zw1edcNqXmXtEQZRWE9yUWrmv8IE/cqszm83DIc6tEOTniHjTd6QTyBLh/CHVFvB/G93MbIo2cV7uk3qjVvCk4fdg+Zs2nTZnBHjlFWSnRGH1GfXLm5gn+MMqlDDly43scpILG556SwNsikcBjZZu/zgbjXxnOQ9WD6RSO+6fzMHISCy86l3IVZKI/z3P0ijhboSGO6Cb+8H4BDAyD53r+pXUil9J8jZ+PQpbd8yTlN/5dleOTXX0nH6+YOAXFXwlCGbMOYuz8D5VVw/ZwWEnEbKHcNHYZLsXTb9aDSKM6Cwm54CkQnloFL1RcmCi3hm3my6RvYyvqhpwSBCuf1rm8SK/vf6JuBK8VlKgSFtTh7h7vPd7OCHqKZ21ahvsjWKoQ11idqa1SLb4gMXFMSq0GyiAo7kygL8gD7bA2WjfkOQUlPMfKIW9fGH8QFypzXNQHuenw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 10:07:09PM -0700, Andrew Morton wrote: > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > Acked-by: Barry Song > > > > > > > > because we already have a fallback here: > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > fail: > > > > if (shift > PAGE_SHIFT) { > > > > shift = PAGE_SHIFT; > > > > align = real_align; > > > > size = real_size; > > > > goto again; > > > > } > > > > > > This really deserves a comment because this is not really clear at all. > > > The code is also fragile and it would benefit from some re-org. > > > > > > Thanks for the fix. > > > > > > Acked-by: Michal Hocko > > > > > I agree. This is only clear for people who know the code. A "fallback" > > to order-0 should be commented. > > It's been a week. Could someone please propose a fixup patch to add > this comment? > I will send the patch. This is week i have a vacation, thus i am a bit slow. -- Uladzislau Rezki