From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96327C531DC for ; Fri, 16 Aug 2024 10:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3185B8D0065; Fri, 16 Aug 2024 06:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7526B0307; Fri, 16 Aug 2024 06:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18ED58D0065; Fri, 16 Aug 2024 06:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED66C6B0306 for ; Fri, 16 Aug 2024 06:13:32 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7D1F6121A78 for ; Fri, 16 Aug 2024 10:13:30 +0000 (UTC) X-FDA: 82457696580.23.2BAFA7A Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 80E7640014 for ; Fri, 16 Aug 2024 10:13:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vi6ge8KU; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723803133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mX0QjytBccHj3E/U2+ZxJG6mQrfJ0MGA/Z6TLsinBxw=; b=IaCYnQAM5ScnD8QEdVEjhkeXfRm8Uz+uZIrmaLPU9xQULEm7two8wvmRas5PW4PITVawLq yB45Ly0yF7KRgO5Lq7dgl4wf62xOxNbqhEQip1xqWMMOjIPjRzhRpy3FnACPMiXbEn04KC p9FUXuNiR2t1dvgzRbzGFCKgmAbgO3s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723803133; a=rsa-sha256; cv=none; b=N6tC3US+0RYtCFmSmB2axGtvqMCYCvnt4SxOvSc08MtxxpMsgp2Fht/N0TxlgII/e0IGkz HoGr0wmWbZMo+pV2jhBw224ppXg15DVIujfx2XNxWk/FK4Dh4aKxPzFcRLP7Icn8EHA/I1 defDVAMkvXUdIxpRnNKIcNfiU3IN9As= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vi6ge8KU; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2f3bfcc2727so11643271fa.0 for ; Fri, 16 Aug 2024 03:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723803206; x=1724408006; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mX0QjytBccHj3E/U2+ZxJG6mQrfJ0MGA/Z6TLsinBxw=; b=Vi6ge8KUl/ZMbpug4UUHg2gKjWzRvOnIXnsMktXp6NnrBJZlUnytHRu0z4xpQv4DXX IWud3oRMyaVFT/rs+2ppQWXitaTtYD3zVE90jm5ENzyJuE1vIgYwiCwg1VxCmFUkWB0O v+DB6hcEYvfbPY0ekXKguCbvYUrxT08+u43DLV6Bhq+YsNfZMdw914XfywECQrr8Qn7V 9uFlGJyPd34HQ62yh3hTUufWUwY02l5ixG8XJ7hJREchkC4SsFhg+CxjZohSGjHCe+nV /AOtNodB00kTTxp+CpXFRSkyiQEQro3kBwZd68xOmQnQk2ZLxJppSFHG2E0EvDjzbMP2 bpKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723803206; x=1724408006; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mX0QjytBccHj3E/U2+ZxJG6mQrfJ0MGA/Z6TLsinBxw=; b=XXlYH5WoF7ApW+w/MI73m9AajD1U/N9k4ye43Uv4IfzSqh19Bl2kBZTA2KgrhAdDC8 3zfCoHTI+BL0KJcyNg14YGsInf2ZvoFb/SlaE2aE49U3IY58tG34LLuKK72f1bqzMsqG GSW3TIVef186YECx+VpOXpXN9VQcw5kGIh2Xzx+RZuqlbxE4lc+hfKaZlUNmK40Q6ht6 ZIUtYa9VUEXtpIB9F4H3VImWMHOWbPgK2zpcpwF6H9YOE8Z7lFPCzt0tBTfl3ox32cc/ XYh/XPxPiHHs0YElGk8faJqN7qdjubKnW6dfDr1qKv/Do8RCTyCpidAFzhqFp+cazX+F J6zw== X-Forwarded-Encrypted: i=1; AJvYcCW6aVDyw3rvGVg+SoUH+q4kBgt5sCZHoYA+PIt9gR6qN9yafB3pLJUHW+uC1tWz68Y/Hv5Ycc2yGKYAqJWwzk/vg7c= X-Gm-Message-State: AOJu0YxWMnwkcIBGs8Unjz1+ZDyfBnSfbeDu+bNaxDrLH/QmXEZ7KKGj 1AD3AAcZf6ek/RE27FMyaDnSbP19sKjpCGmnerJmxczN2TmaIIG0 X-Google-Smtp-Source: AGHT+IHoN/OTahMDYZFxiU7ILKiovPlHB8SS+Ly2Ed8r65CGLkK2ARLHV4+PTXUycWoouYbLtPjl5w== X-Received: by 2002:a05:6512:10cd:b0:530:b871:eba9 with SMTP id 2adb3069b0e04-5331c691e9dmr2025403e87.1.1723803205198; Fri, 16 Aug 2024 03:13:25 -0700 (PDT) Received: from pc636 (host-90-233-214-145.mobileonline.telia.com. [90.233.214.145]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5330d41df75sm501629e87.194.2024.08.16.03.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 03:13:24 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 16 Aug 2024 12:13:21 +0200 To: Hailong Liu Cc: Andrew Morton , Uladzislau Rezki , Michal Hocko , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816091232.fsliktqgza5o5x6t@oppo.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 80E7640014 X-Stat-Signature: 6deweohnus9y3ppptfx9hj56odi8wazo X-HE-Tag: 1723803207-621308 X-HE-Meta: U2FsdGVkX19ryrktTp1x5+ygSD/Wmfj0onqfOwLJrNiMUPP3XlCzMKuiTPw5u+ThJfn3Jx+fmhCW3nAPTDr/N0XtsdgdCuMUclmQBXEgNbu0rLBJEnarMg2qm2MFS4/H7pZK6SZqcTpNhD2rvdZWxyhlDvoRg7euoUre0dFbi9VwDvqLNufIsFvqBobQlx+XiBGKkSgN7kY6jrZt0Uykw1UCGyUJdq5BdQxBn50/NbmFtUBBx437CznGl+26G+TguFflUxjQ7dMyr9bpR3OlYsY5YVJL4coBzZDgEv4QRgpdxXXJ4jl7SeAh97ZJatwf/rb4EiodIv1GVoCTi3yxqUZ3RbmJKXo0V3/hJxCqNshm1ctRUKomvbjdMiBYjm2CmcIYV8g/tqwHHM9fupbq5n8U1hHl0UgcFHO5esSV+GwxkjVMCXt693tFohhUnQmy5FHGkghyqv8tZFrgKt4KZjCfHp8+SnkY4ufhAzQHVVGZuWRwuRys+jbGSkdVNCDcUfvwkPNyadgTI7TvUt34/89ci2TYVWeAkrIl6NR6kdn3zv8m8Mqb9pMsr+SQ21CkSnURKxxRrTkyKNHWOCLhHoEVctu/9g+dOjWS0sLkcn7/bEeAPMbieCLyomoGziogayGFm6l3k8YoVk9dHgSLKuInGcWYaN3H6Ggt6bnsZoYPlU4n2pVrYwO/1DWkvN3l9VQBy52SxLIhJd/LXmaHLOGzPZB2t80qktCAxKB6zuHg6Tywx8zeEHzgeN1Mjidq9hlhEw4SOvFUBlnRpSiz0vUsLP+QZJKpyTgUzHdHkNsfX04P2C4cDFDj+nQZTFkrhj1lhCs7bIBX6FgF4oN7hURxcogHEnuogD6I0MlW7OoNLXkzbIGJCDiE3mlzN+53RsNaHEy5hfsA5iA/oikaKfGtH2eLecmxKkpuSa3sJfFj3B03n1IQJt5bsacjIP98EaTrOWll48/byXIUQKv t+o/JTmr X/YlIM/DRgeQCqEwHueHPxd86uRLqW+K0u4FOdkJA1G++GSj3K3CNydTUqdeeRi1XP4oqQKVKUoSb+IkXuWUAiqiL5S2N6gB08owko6itC6rZ5JWMYnCf6FrbYBps83sgaLTb6cwxeIJYNqK9Z3+lBJdCrzDgAqksebM9rQjrBxLandQGmcXNR8uZ2ZRp8hO1+hJrafOlUCWHe4hH72rF6xoXdLA1R5uqX4IFWMnW6lIJOPIdEUV1Zm/gN0rRsaX8z5itPKOmCgajodq/h5U/0amLYhwM4qqALCVE3otrJUt31jIl8CVG7nHUxL4X2M61rKlFGwEUspC/orLS2IoCYD9aBdOcsAR0vOKuVEvtszfGZEYnErumjaXA9TqBiWZQOWwAWk2F+r/ekRWQJYb4myUdiQR2p0t6lOzLBuSxgMKNIqll2DhbGPDx1DA1KUOPElZaD9d+cNNV2L9vsIXCN8ZUgbH6KQuJY8yC03h9ucbyDA1xbQNu5N3uB5yqlC4Jej9f4RduDlq3WanEOVRL07WlPU8TpGIOOM3h2Yf2r7BeatpzlaAnwko/bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > Acked-by: Barry Song > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > fail: > > > > > if (shift > PAGE_SHIFT) { > > > > > shift = PAGE_SHIFT; > > > > > align = real_align; > > > > > size = real_size; > > > > > goto again; > > > > > } > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > Thanks for the fix. > > > > > > > > Acked-by: Michal Hocko > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > to order-0 should be commented. > > > > It's been a week. Could someone please propose a fixup patch to add > > this comment? > > Hi Andrew: > > Do you mean that I need to send a v2 patch with the the comments included? > It is better to post v2. But before, could you please comment on: in case of order-0, bulk path may easily fail and fallback to the single page allocator. If an request is marked as NO_FAIL, i am talking about order-0 request, your change breaks GFP_NOFAIL for !order. Am i missing something obvious? Thanks! -- Uladzsislau Rezki