From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B00A5C3DA4A for ; Fri, 16 Aug 2024 14:26:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 337BF8D0080; Fri, 16 Aug 2024 10:26:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E7538D007E; Fri, 16 Aug 2024 10:26:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AFB28D0080; Fri, 16 Aug 2024 10:26:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E7E168D007E for ; Fri, 16 Aug 2024 10:26:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 99175A7549 for ; Fri, 16 Aug 2024 14:26:13 +0000 (UTC) X-FDA: 82458333426.16.D05436D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 6CA1518000A for ; Fri, 16 Aug 2024 14:26:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZGVbDCMJ; spf=none (imf06.hostedemail.com: domain of BATV+e28816062944b636f5b1+7663+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e28816062944b636f5b1+7663+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723818313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YlriYsXOqwiTgS6I2KpCXQbTpQsu2jOM4HwsURrgwvk=; b=5XdJkSn7KNfdwqpCr83OISZj7WruaFfjbwYMfeZgh4Xvps7qZdqIC8EKRw0p3anNQQ6N24 873EVs41L9J1HDSwKPHHOzsPSQiSo1wB9/0ckmCYB213SeiYNv7yfnrZwjGAxwKlg5kzbg F6R2CIhE6wpNQcKixABdbMoz8kW+Huk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZGVbDCMJ; spf=none (imf06.hostedemail.com: domain of BATV+e28816062944b636f5b1+7663+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e28816062944b636f5b1+7663+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723818313; a=rsa-sha256; cv=none; b=t8mY4XQpRSMoyt4DFphZQbJj78v+aLIVdOQlatPWMPr0go/rcJlJiNzcOC6rO6KWhUcCnp jlVbWZiKtG6whXOFH0OEZpdLUFME726h3ShSUokU/uVLhWpivTpoOtlNppiUFdVMCDBcMQ 4CjTzxNXBxJI8+nzNvTatDa+5EJhT/o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YlriYsXOqwiTgS6I2KpCXQbTpQsu2jOM4HwsURrgwvk=; b=ZGVbDCMJ5EQ7fDp/OW1w/N7NOw 4t+UGUuzMVqEK9/1UpIg5LVG+0GmLRIQrnvLOOjD2AxfnJdrrhEqzr5VehqR6c/WWe4Q3PHQqzsHj f/x9rq1sXJN0QvuLCMVJSch8/gBas02AEufR03nbqbnPUGKg8d5QmzW0Te/lIzEkacXUNISSGeKwU 60rG7hv9cp+sos/3IXW0eY+GOTuZOuouu62pxF8Y4uz51gooHNqk2g/493D12BrNKUHv7fJxLTERT qF+qjvvfjj3EuugholQ1ggNpllxtTJBAjHQ6fmhY6AXsTS+bJztsBU3yi8o67zBw3RyA/LqexGukV WnT3W9JQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sexu2-0000000DCiv-3kjF; Fri, 16 Aug 2024 14:26:06 +0000 Date: Fri, 16 Aug 2024 07:26:06 -0700 From: Christoph Hellwig To: Michal Hocko Cc: Christoph Hellwig , Yafang Shao , Andrew Morton , viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Kent Overstreet Subject: Re: [PATCH] mm: document risk of PF_MEMALLOC_NORECLAIM Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 8u47izke6w1rx46g8d7y3coyau66z4xh X-Rspam-User: X-Rspamd-Queue-Id: 6CA1518000A X-Rspamd-Server: rspam02 X-HE-Tag: 1723818371-100468 X-HE-Meta: U2FsdGVkX198IR7H25KtJ4AOGhx0kbWu6qSk5ymSgHw33PrGvDVXmezv0hf5P8FOvzY0xLhY4zH7sWo/99saWS4vHQOigLa3nDWS3Mf0UEO/YAcZaYhho29Gf8UNak3zNbJq+3AjZQT/JG9sJ1x6MDyyL22RtE0bgEpbPCudJTs02541Zvdry4iMj16pb8NAZeuGkJqxIKXu9siE04BPlUC+YJ4HXEdkCJjatAv9GY049PYNRCmorilGgr7Z/dwhpbFs6ApMsBXOjJVUGp8YLv4j81ktzXRNMN7avPqg18M4Bbsgd1ylZMjap7KLdGvsQzo4I2OAxv5H7Xf5we1t0nZM/N6W44ZPozAZlIFP1TQmOISbswRuvb4HgtBoJnIlB818ye4DyemSrfe0Q4OxWT/p9a4ZMorD9kPOQ3Ds+kNLOSouFM8wFj1YJT/Pi+1cjRIoFkLEHiL9XuG+Hueta1P0EPCN+ZhydM+q/xqgzOzKwgor+1wPeVHs9ksELNgxCDTJrYMDZM88cWCXFqWK55E0PW7aTgf1CUcmazDFoBWZcz8K20bD+psjGOCML3huTcCFSwr68rWYdqiHNnNV68LUWcKQpGpt9UYRiQogGjwZ74/YkRxrFBHDZAoFt49gOAYkcusjzhbmh6XjgU9wXETL1v5pnTM/e9hNBLOplpafE18VsCHZmG+i8OK6XiLe+LRbsxBhsEbiCjLWIt6c+t92BVGK4Cxe4uHCVNAvHz/c3GmUBWv13Y0MAhBS7iRvf7yG8gd7z3HwhFJbas2pEfyUKt3I4Z8OojW9ZXvZXceAjZRIM9rYTSCEfZEf9KRf7r5f/6kkr+jmBfy5Qmw6QD/V6Kog3E9GsbW8euyauqBJSYeeJhg6ErUQL1BYP4P5Dp4xxeleNROEpgaD1GUbGxT9mdv6VQazIY2qb+2YHGYeyYlcMSKsCo9d+apil7zvkAXLDWgk8jsO5iFx1c4 1iaWmku4 zeYDhpc0+g8SwjNh1yjHpgoWbRcI6U4gMUa2s9U3B6AACT4K1PGnVUyo+MFhYGI0wfGK9Cq7byRrO8XY19D2X7z34CkOrg9CQ+2TWhHc6YylJLdvzAnpFxmebuc3MJoGNfqHJ2RWz4LCX6FAFHgfq512Do/whMW/YUxXr+quoEMM8Ft9snM6a0hnWZzHuTxnKdYWZC0m9IONjDtB40YIbULXZhf+fNv09BX4M5X5KTpw5rv3XqoI2vvfQFg7Ik6wHWtt1+565zANxKfoSVKTz6Pzma9F+MkWm+7j6+DrVtkzDMbNfSrZRqjHq9ZWFxf4+CX9d0s/anlzNEcsmmnMUnxmGDQXPsEwticVfetEijzShFqNVUOsRNBJURKLbe1f3a7vlGedPeC7zK9KGZSmmRfJ0TZf6jfxuE3zfn+o95JxOPLyi9/eiCq1OGLfAiECGolaYFGt8TXBIpPtmmicfhrLvVo4amKxZy+7InK/senbQ1sabMv+vy4THw4mBbR8BpDhmsAFFVIgbm5bQJafRoXlbVwPXGwVzyIoAFUf5MaTd/ExJ1XZAqi5h3m853fC0zC4q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 10:54:37AM +0200, Michal Hocko wrote: > Yes, I think we should kill it before it spreads even more but I would > not like to make the existing user just broken. I have zero visibility > and understanding of the bcachefs code but from a quick look at __bch2_new_inode > it shouldn't be really terribly hard to push GFP_NOWAIT flag there > directly. It would require inode_init_always_gfp variant as well (to not > touch all existing callers that do not have any locking requirements but > I do not see any other nested allocations. I'll probably have to go down into security_inode_alloc as well. That being said there is no explanation for the behavior here in the commit logs or the code itself, so who knows.