From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F548C3DA7F for ; Sun, 4 Aug 2024 23:58:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A64D6B007B; Sun, 4 Aug 2024 19:58:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 756086B0082; Sun, 4 Aug 2024 19:58:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F7DB6B0085; Sun, 4 Aug 2024 19:58:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3F0CC6B007B for ; Sun, 4 Aug 2024 19:58:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F15EDA7452 for ; Sun, 4 Aug 2024 23:58:33 +0000 (UTC) X-FDA: 82416230106.27.0C4BB2B Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf26.hostedemail.com (Postfix) with ESMTP id C5BE8140006 for ; Sun, 4 Aug 2024 23:58:31 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cmEu5uqk; spf=pass (imf26.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722815881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fpM5H1TDUfySJ43uH4f1cuN6lW8oKfIMeXGJAKsYgdc=; b=K8BUxKQIX3whHQHRkD8AyQ3tT0JWewXjGEIlCZhc78ChzTcY8XA8zxiONsIVlVurBDyGQe LkJo0ko/6T3BhogkKRJflz0PR7JdphF+djNQHwp2WVo8/QameWCuuMrw2L/6Sp2g3Xrah2 U3/aQhfX+9oRpGIt4QaI3MdICfOM2Ww= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cmEu5uqk; spf=pass (imf26.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722815881; a=rsa-sha256; cv=none; b=dxaO/kNWUK3sHwHtaMG9ATtS2YLTGoNpqEPRjLZrqEW9axFzS2/xfdyr5Cnx5e28w2gY53 cik30QpPbGVlSCoQHwGtOBfN7acWWRc4mGRjy/T7NNYLyE6ljHumJ1I8+odQ47r6n8Swzf P59z8RJY7/uZFfTXb3rQGHNdUiQgnYE= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7a1e1f6a924so652006785a.1 for ; Sun, 04 Aug 2024 16:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722815911; x=1723420711; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=fpM5H1TDUfySJ43uH4f1cuN6lW8oKfIMeXGJAKsYgdc=; b=cmEu5uqkQh85vOeUBpnOjzRA0z4on1zvam6k1WBkRNpuIwGna3usVnCk6SbIQZX0yV O1O315Qym0NH9k1BtbpGCLxd3E65tAFUCjQsvzOV8PU1ft9M6tjRIrH/8ujkNgb6YczP l469UTaXYx9FERXLD0/HPPY1qcA+TPyk3nHcsfjyqaO5rIpgFtyTd5P8NA9omqedXecO OWgaI//MrNPhu/4gi/Mp7Cyl9/Zqij8c0S+7DSXwlkg72OykkaO3uvOuPw7HiG03J/Tx 9gfiDcnAMyfJ1VFXHJOlylTtG9cHd3pwk//j1hTRoJrFGoSC5qrG9Zz0/uWf3P51mxNG WHsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722815911; x=1723420711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fpM5H1TDUfySJ43uH4f1cuN6lW8oKfIMeXGJAKsYgdc=; b=vs0se0uczdOBoWedQvVb2JR82J8FgkyuzN5ME4rJioLE/cLBYyxmac+5WhFv18eXVz JXucrRZzOYhyHgQm8dcD32lfsqFyIyksmDBKQN/z6WrS2kLH5kS+5vEkebuorJSqxs81 f9M5fNjUNd/qT8+RcnL2a5Vaweh0YmnNeS0Vnvb7x9/DyOcht84hTgzrhy9IM+htVb+Y 0yB9+39fyiannXwET25kOZGkbY5mksfzsvFw0nMmDkI6XhJkSKhUHo8rjSvyDZtqfTlS gfnRGoxrLE0rlf46+6Zbjm5plcHwc4BeoKCUlzML5YuggnfK+p/LQOo4m3zn7vXUv5z6 xK3A== X-Forwarded-Encrypted: i=1; AJvYcCWtIGvohFcVA2/tjaZLweRX+Q5n1vLmmqA8WJ3dtROU/dOc3ag5fALkwmsjeV0z/5/SX8s9SVSI6N7O5adSqgz9Puw= X-Gm-Message-State: AOJu0Yyo4jQoRQB7rIkOmsD6V6Z2hAKcVyXnGAeD3fh4KsrUCxonmItu 8mrmsMvHcvRW5EkwN0G6ZiMV841Nf54L4Iec5KdWay+aVELHjrWK X-Google-Smtp-Source: AGHT+IFVFzc4iKp4sWX998N/3yecTCH60QR1i8lzXUqfFFymFKfKL3Qh7JUiJTAwb2IxCiCdjziOqA== X-Received: by 2002:a05:620a:b9a:b0:7a3:5fa3:328 with SMTP id af79cd13be357-7a35fa307bcmr495790385a.54.1722815910668; Sun, 04 Aug 2024 16:58:30 -0700 (PDT) Received: from fauth2-smtp.messagingengine.com (fauth2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a34f6e9172sm298494385a.43.2024.08.04.16.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Aug 2024 16:58:30 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfauth.nyi.internal (Postfix) with ESMTP id 64AAC120006A; Sun, 4 Aug 2024 19:58:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 04 Aug 2024 19:58:29 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrkeehgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhquhhn ucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrth htvghrnhephedugfduffffteeutddvheeuveelvdfhleelieevtdeguefhgeeuveeiudff iedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsg hoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieeg qddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigi hmvgdrnhgrmhgvpdhnsggprhgtphhtthhopedt X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 4 Aug 2024 19:58:28 -0400 (EDT) Date: Sun, 4 Aug 2024 16:57:30 -0700 From: Boqun Feng To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH v3 06/25] rust: alloc: implement `Vmalloc` allocator Message-ID: References: <20240801000641.1882-1-dakr@kernel.org> <20240801000641.1882-7-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: C5BE8140006 X-Stat-Signature: a6wqfk8ibmqbxko13hzn78coxfyo9kbs X-HE-Tag: 1722815911-588379 X-HE-Meta: U2FsdGVkX1/1CQTxim+Zpoj+VQuXK/4AAxQZ2PmiyKB0X2lGhqq2cIIIGnOiAa3We6d4fKRek5P62yi1Y/Me836YLm2I13az3+yWEPL4p/z54V+lky0W/BdSTohN+gdjEaXFZJGAebHYnCVsEHGMkZ6bE562WP6ojhVQGuGrqWEdA3qPJ5lKlnLDlY29XzIpjlD9K+E041VwU1StmR+Fsz6ecQEoB1u/yIIi8mpGWKma/QcjuMqvwceMYXLxkJ4GkCGBFFXmfcWCv7b/InM22c3NpK9nxhReDK8MNiuMipHu+5X2DrxL0AR952xdW3Czn9+BIgZVOEbaK99bQPerPTT4x8bfoDTy1+Zg2tXCzssVnl+CC5MuDMr8XQSoCIWPZLKTSsLOm37d+u4ZePRSpIGhA+LACt2iBERWTayYGZWtLj/92zSN0CBsQqMdHTQuwIjl7UaktRf2qvnJ+UD5FVh4VGd18330Us/whxz+kH4+F11gxtBS2K/P5LW7rhHNp45WMkdBJJINQj31T77sNFq5swDjVd8MYVGLNx887jN1/A30xawsqyuvRK58dssSovx4Q9HVKr0EL/4+VtmedAdlq1cCR3nhdO6zt3E6lrKegWKy1nFt70+6e5UmL7pz+9iTnOsGSA8LfgEZx1GO1Rn09doeOI4cn8b1EOQdAeCaQkJ6+Bia040MZDXrWQTEllhv2UGBRlovvU555zP4Wl7mlcErRYaiBaG7Oj55eFCmEBBG6XAzSBnCl5iT17oDyzeXFK0vPu6bGRe7bT7w39ZlmWyLtDacZEFO/bQxkfPwqSO1SCUETIuoY/f52vOc/pQO0bmfuxJ+Tmf8Cu8etlWgV7XTX7J7cEHQaYWdkPzLOhQ+LCmmkzLQGQpk8ZaFOh+2ScVc05L8I/xOUU+tWcyC87oPHYqPmO0XNnChmHb64W++SW9roQrN/LMJTHKBneOqB355XHF0Eu9iRrl 0Efz6umA xjvYA09OLKkY94boXDeeDD107IjNB87VAn9qwxBwYejy30snld0BVZYXpzzpDmibKixWd46nkumKFQ7ExmlMAvQEkfwqfNOqkKs4Yq+RxMARUNEkKGtH41luJsVaJvdZlrqJZzDIn6OPCkKPA9onGovFLPwYEEXxSmnCP8zOQnsN9Wl9Bu9TJ1g5sxFdePCAIkW1NqTqUUECJxuTVd5lJYmA/q7F6Qwh38XAiIEaY7wJx9bByr8EgifXwia826K1BF+Nc2Px09226PORixNA8u3MdjyrSJPfSvcEWQYhflfGrIwIQneFWD23ebFwzn/zbmHQKb5PAqnYSkHgdCnY5tSf74iPEG2jDN2T+KVfBMB6ykvUlZGETQ7zIJ1IaGdVQR9CGd2sh0MXu/L8dskFs/SmCN6PtWY2quajbO3b8lPLssctHz4h6oDH5Sdd0ImfKrrsls0gw5p4buOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001864, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 04, 2024 at 07:39:52PM +0200, Danilo Krummrich wrote: [...] > > > > > +unsafe impl Allocator for Vmalloc { > > > > > + unsafe fn realloc( > > > > > + ptr: Option>, > > > > > + layout: Layout, > > > > > + flags: Flags, > > > > > + ) -> Result, AllocError> { > > > > > + let realloc = ReallocFunc::vrealloc(); > > > > > + > > > > > > > > IIUC, vrealloc() calls __vmalloc_noprof() in allocation case, that is > > > > calling __vmalloc_node_noprof() with align=1. In such a case, how would > > > > vmalloc() guarantee the allocated memory is aligned to layout.align()? > > > > > > True, good catch. I thought of this a while ago and then forgot to fix it. > > > > Just for clarification, we're always PAGE_SIZE aligned (guaranteed by > > __alloc_vmap_area()), which probably would always be sufficient. That's why I > > didn't gave it too much attention in the first place and then forgot about it. > > > > However, we indeed do not honor layout.align() if it's larger than PAGE_SIZE. > > Another note on that: > > My plan for this series was to just fail allocation for alignment requests > larger than PAGE_SIZE. And, if required, address larger alignments in a later Yeah, this sounds reasonable. > series, since this one is probably big enough already. > > However, for `Vmalloc` we could support it right away, since it's trivial. For > `KVmalloc` though it requires a bit more effort. > Could you elaborate why it requires a bit more effort? Because kvrealloc() and kvmalloc() in C don't have a way to specify alignment requirement? If so, I think a solution to that would be just providing the K-or-V switch in Rust code, i.e. just `Vmalloc` and `Kmalloc` to implement `KVmalloc`, which I don't think is a bad idea. Regards, Boqun > For consistancy it would probably be better to support alignments larger than > PAGE_SIZE either for `Vmalloc` and `KVmalloc` or neither of those though. > > My personal tendency goes a bit more into the direction of picking consistancy. > > Any other opinions? > [...]