From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD02EC3DA4A for ; Mon, 5 Aug 2024 10:05:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57B0D6B00A0; Mon, 5 Aug 2024 06:05:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52B1B6B00A4; Mon, 5 Aug 2024 06:05:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 419E66B00A7; Mon, 5 Aug 2024 06:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 222B56B00A0 for ; Mon, 5 Aug 2024 06:05:28 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D4071A4C11 for ; Mon, 5 Aug 2024 10:05:27 +0000 (UTC) X-FDA: 82417759494.23.E8BD777 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id C679D1C0012 for ; Mon, 5 Aug 2024 10:05:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SWRDz09z; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722852295; a=rsa-sha256; cv=none; b=3JR1K0xjR3X4sqEYxtwzhPMBGPU2gSxGhjnxPX9zo0hoYWcKAvv0CgZs1DKW6eLdNU2Ral GwSb0KZJhqknqLJxIk4+yko/8nENHJaR79kCemWVwOKBa9xZuI3pYZCRk8ec4J86HROd3/ lajo1bdo0HzVW0m5u6mI8+f50HPHpPQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SWRDz09z; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722852295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tr/gRpuCONM6qqy0RMh6A0yqlDUTG/dikxaWjkqFq0g=; b=cWrFz7gsoMwaW0JffNs8/J0IZy25pKKsAD4/IQkht1EYwiUNI8n22VjNRvUbnff/XNshhh KCOt6Km6aMz98JFXm5DhcOBRjWXcX8GVM62sRgAF8AyKktI/HcDIncf/QHPgkHrz3TSWVF VxxERnOQ4TgosfLW1v53T80pUAZIddI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 35866CE09B0; Mon, 5 Aug 2024 10:05:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14751C32782; Mon, 5 Aug 2024 10:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722852321; bh=/06IadH+EV4lkjqp7OH/dHVKNM+jHZzeTgU9JSf+Pi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SWRDz09zNVaVoJEyrZtuKh6/2w+lw6Y+tSkZHOCots2S1uDdq1MP5jEPd8zzxCLAn 5r3DaqHtiSrx90zy6r6MtNt6OPZu6tjF94eB7Uy1TX9Nw5xZPCzueGt9yh5dCmavlh MIXc/2DKBfV9tCSqKi/n+xaKpcfIQoEp13qGeKVpOkNrC8OAPhAR+5FDYI9DiooxF9 Hb5Li+SY3Q2+wEfjsY1ozrIKAVfmeIHUEMalMoj7gSV6MRpEXOxMY5maNLLnRPqrGG ZOkp56DWeYJyFl2mRGDkK98CIz+QYBV3iMeGSc6O9F7UrlxiUZA5Ed1G0gf/nmt6B9 DY5Z0zbQiM1/Q== Date: Mon, 5 Aug 2024 13:03:14 +0300 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: References: <20240802010923.15577-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802010923.15577-1-richard.weiyang@gmail.com> X-Stat-Signature: ti9dy19r1xnfenndqf9n99xse7p3rcab X-Rspamd-Queue-Id: C679D1C0012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722852325-18460 X-HE-Meta: U2FsdGVkX184RFvLBZiFtQLsonr6P9b62A01RxmkeT5nDSjsrGNvLvfHI20cPfKV50QwNh6v2fYm2rQ00OkebSx222YTSJlaTF1LOBXz8BdhIEPpj4TGjOAt7+E/znHvVyKgVj9+SpBUdUIMLi/kOF9riDrHHJGWT2srzsNYHZDmI13ZuoYtzBgVYoV77pepf5PzGZoCJ+KEE0kYMKflr4p1+LD6PXL+fKjX8PR2RcZrYqHzwSfSLiAjSuazQ2T61TJ4xdEJUjt+AeMQ6ya4Updvo45N1Xxu1mT7kXtnG/POPTD6hMeQ7chvI8eBIsO+WRWSy8VlJ9vusL/agXn++sVPr5Ikd0zLLxJk5EeCI0FVxO0bgYIVzB8oe8XdV4qMlYFEsb33CiLGOrQEbdxc9PAfqQyAROLW48s2aDBIhMGlQ1A+I/0fX3L2P03cpMqPhCByQNXXfvY/xcg0QDPTARFId4Qn8513j7EZxJqzGUYyJk1B65aebkrIPv8IvRWGcT2DB9GjPB49LkoPZNCaSzboalv3AN7KOgNGIu778v9YkTFYJi665F/61r/7AQyrlEprTKAIukUvlhcOFI6GyoIS2qMJGA5cFPWsunQBMkPQgdrsrHtnKbPh4EGGi4gRaoOEukWtS2B5SNbDRnRQLlOJrAI2vdfzgTxVWLFVcv5IHcKSA6/Bb0NklghpEQO/xk3TNe3nkKkBo0Uu/12JFjm1urmgxjD5QPkyuPMiEnPNwbgp65duQGt4oQn2phWUAvwuaL73BJbvedXT/7/RK71h0UL69zUpI4JCOXSLo6F19kqC/m2mIZgQThAuiEuXjg5TSkSlqqxjjapsOK+7VrZD5jYVhgok3w8dwSgnusR6MCTZT2nheSdpSYBs42VJjX7fkhxYmQqI+m6K4ukUFfNmGcxKGfskrFsoc3H1XyW7EUPBOWyj94e+ldUdegCmm995X9h7bAf8a8Dbkeo L3R6fqg/ DLrEXkzmvoRiUTSbeGBmh2Gq9Qmg60qSdKANWm/qYRQ3yRHivEAXqEdK6elCLBkZO24PUV/ZBBhvWVpxyFqoIm+I/7HixSGoBPcVhebWaQwI6tnx6BJsFLV7GSg9ClDRa774rNIDVNg2JtNSlT7hF66t0WRlXAB+Xr9j6wWY51r0V74bK14vbmVR/tsGQohflsHzzowhjmoS5oNfm0/9NxU4cawGYv1BaGnD/5vfNBvKsdjGC8eTdvUauLad2QfnL8sq3Anr8k62vxaV6wJY3uDmr+LOKNLzamDrySDEux+Cpc30ms43lO5tMVJqInAaJFRGI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 02, 2024 at 01:09:19AM +0000, Wei Yang wrote: > Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys > alloc") introduce the usage of virt_to_phys(), which is not defined in > memblock tests. > > Define it in mm.h to fix the build error. > > Signed-off-by: Wei Yang > > --- > v3: use static inline as phys_to_virt > v2: move definition to mm.h > --- > tools/include/linux/mm.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h > index cad4f2927983..c9e915914add 100644 > --- a/tools/include/linux/mm.h > +++ b/tools/include/linux/mm.h > @@ -25,6 +25,12 @@ static inline void *phys_to_virt(unsigned long address) > return __va(address); > } > > +#define virt_to_phys virt_to_phys > +static inline phys_addr_t virt_to_phys(volatile void *address) Why volatilte? > +{ > + return (unsigned long)address; This should be phys_addr_t, look at its definition in tools/include/linux/types.h > +} > + > void reserve_bootmem_region(phys_addr_t start, phys_addr_t end, int nid); > > static inline void totalram_pages_inc(void) > -- > 2.34.1 > -- Sincerely yours, Mike.