From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A630C3DA7F for ; Mon, 5 Aug 2024 20:36:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 028446B0083; Mon, 5 Aug 2024 16:36:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1B6E6B0085; Mon, 5 Aug 2024 16:36:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE2506B0088; Mon, 5 Aug 2024 16:36:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD60D6B0083 for ; Mon, 5 Aug 2024 16:36:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6EA2216023E for ; Mon, 5 Aug 2024 20:36:04 +0000 (UTC) X-FDA: 82419348648.18.6FE2CBF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 6A363140017 for ; Mon, 5 Aug 2024 20:36:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="g0ifEE+/"; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722890155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XVvnTj824RDl/7yi3d09b6iyDC9SJpmseeIhPc08sow=; b=cByfkNM6mirHRnZXf3B8Xqnqd4N6h8vCySDD8Ci6AtSXGypU8sPrfDTSEeB8fDL9G7PYmz C5SGESECkhKDdryEmOBJHx+pjhMwve0+6QKvhCjcq1+FAPrwXmjKFaOgxZlNsxO9yEb2ZO Ze5gwBUJUWID/6uZDw6HsJGov72ZqeY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="g0ifEE+/"; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722890155; a=rsa-sha256; cv=none; b=ctpBWGAXVWPzjrsub+oGV+NpHqNmZR5Zx8U6ZM3dWazvLiuQUPm7HyNTkL2jXEObuyVP8I DZLBaoe8ogK8J3G3zZSsjbSDFRyZ3koLBtnTfuNG0uwYwVFWAaU+0dmNuArQt7DAfjg36h 9LxiTHV3RLpMwmTvdb9puAYXGe9lF3U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CBB4BCE0B42; Mon, 5 Aug 2024 20:35:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A51B2C32782; Mon, 5 Aug 2024 20:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722890158; bh=wRagKm6MS39NDYLBbcdNfb/zxQJOwJqmtNN36cxhWNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g0ifEE+/fQd9VQyFJiGF6eqG5LkKWn0QoytIRLG6RGNO3Qz+ixAqBqBhJXWXYzJE8 0lFaNo21LgP2mbO565lm6BtVRnS7fXNHEJVy8zEtHsy8Uw8u/a5v19B4OkrZVUS3fx ix+vSxthkk0vtjORnJgV3NWtYxBAy3BhlS8nwLVfIFfPyq5ww4vSd2FHKgUzoj06Iv Vb4ByzZFa5e2puJlKIa3k2+AazNy3wMipT1Qok9eH8nBZ24hNYG5OjUnktHHi7xdO4 HdW3CuSUf4iLi1uAYROJiEHzYtewSLvIDZn8z4DY92o6CWtrXY1hYgkOWg3WUTpR8E O3fqMHFNWnE8A== Date: Mon, 5 Aug 2024 23:33:39 +0300 From: Mike Rapoport To: Dan Williams Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Cameron , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , Zi Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, nvdimm@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 22/26] mm: numa_memblks: use memblock_{start,end}_of_DRAM() when sanitizing meminfo Message-ID: References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-23-rppt@kernel.org> <66b1342e8af7f_c1448294af@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66b1342e8af7f_c1448294af@dwillia2-xfh.jf.intel.com.notmuch> X-Rspam-User: X-Stat-Signature: x461ekyoxxsqqnqcs6ywcj48wz4hukmo X-Rspamd-Queue-Id: 6A363140017 X-Rspamd-Server: rspam11 X-HE-Tag: 1722890162-95897 X-HE-Meta: U2FsdGVkX1+RG2EqzC2GyzuJuFEuZpz0YGdAUF1sVVf4j6b2au0O76BuKQssjc2Jhael4PRUlAE9CCP+0P6lIHM8FPmG93uGgxz/J2I33lsIHZGa9eyr2tLL2uEpXy2gwJUQUcPvZaOWdt4EX7aaLpIV6hwCCdFruF7XXx2eD1ELURzhIaf/grk/jnmHy+miokIlPgj6wLKrX3CWp4iKJ31gGN52JBX7a3qOYvlL5T3y3ruSdz3LpkjRz1w+e1o8cbARNCfOMTMAxcgL9CLRzhzopOyJvx+Mn2E5+0EuOjvIonVVj6zlNz6cWC8vTDsmKtnu8rLy0bMRm3aYFpo4/iy7P9ndbjNbHKX+lXWg30IPbulEPyogAnkNP4ApBqLDBdtuM5AP4sa2s1ivrw7ZY7sEIs4yvX+Upo415z+n6NWo0XBOs8Ob+zVTsgpjyK8MclgBynk1OrXVGl3F3gkgY/bu/V1LBN365/smAo5jUzCB/2L69z7ON3jytzkTs2xnga/1uvmm5/rK6T+fLXWsg+3BrFIcDf6ttAENXikJMxjqYzeCtfR5Ey+yToVwq6IVHi7WnIyTEdRCB/OEcTPQGKSu2G8rQMipxA5A2ctMZOdY0eQhtxEhHGFvK6/XSh1zRxbxPXmrEQ3Siu6et/M1nxlielpG/9LneUT01zpDM/SiUHh3pXXxu8HlNg7T32PpxX/AgkUkvWhcZ+keXrmmy0GDRVhU8rUaYf3oo1vCn0yjtkQIsaI8Xi+bhKugKORdVmvkcLNTmm3kjy1f2FSCmRKhjB1qD1f9pLe4tifCG4xqV2TcYjaDpFogaVt4+VduQ76NZboHqmmSbraYtoPBUwFxHshdOmsuqeeivuo3x93KE4XndXWVdHObBxxN1/hIACwUQwsVBHFhsTpQ9WOP11g+Mn9NeKyzKkAlESy3YecF8SyueZMLE3xtGJPzO/h6z3gDNI08gGTiIdyjRRc fLlr+jsv RUah95ypIft7dfP4s05kp5vCxbd0ISPw+ZPSNlLY5hbvLxvlYO8CYPmAx/LTyC34JSOpmtJTL53gYhbpFdaGBxnk8UthyAfIlAviAeZ8cyiRTY8Jy2zYoGmTqxUei4qHDwX6eNit/99mx+f3vNdyw8GTBpLpK6nUocq3OH3bK5yOK1BGDOoKe85zM46p1SYwKGaugzfEl2dBKM5pexRGOUvLZnsmLxymUPBLOX3inmDG3wBUMuRXD2lao181ui87+9ze/q6OuILsOU2bxHogHElCgiaDXriR/4Slb3QW8HwB7oVJu0ZIm1hjWbLzMdbpAqJ0lfrozs4YsvJWF3fHSpg7sn81phG1B7+OF9gcaJCWA44w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 05, 2024 at 01:21:02PM -0700, Dan Williams wrote: > Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > numa_cleanup_meminfo() moves blocks outside system RAM to > > numa_reserved_meminfo and it uses 0 and PFN_PHYS(max_pfn) to determine > > the memory boundaries. > > > > Replace the memory range boundaries with more portable > > memblock_start_of_DRAM() and memblock_end_of_DRAM(). > > Can you say a bit more about why this is more portable? Is there any > scenario for which (0, max_pfn) does the wrong thing? arm64 may have DRAM starting at addresses other than 0. And max_pfn seems to me a redundant global variable that I'd love to see gone. -- Sincerely yours, Mike.