From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E3AC3DA7F for ; Mon, 5 Aug 2024 17:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF9FE6B008A; Mon, 5 Aug 2024 13:08:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82CD6B00B2; Mon, 5 Aug 2024 13:08:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D6C6B00B3; Mon, 5 Aug 2024 13:08:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 91FD46B008A for ; Mon, 5 Aug 2024 13:08:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 101171C0F7E for ; Mon, 5 Aug 2024 17:08:04 +0000 (UTC) X-FDA: 82418824488.05.6FCE9FE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id F229080005 for ; Mon, 5 Aug 2024 17:07:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VNdj7pQZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722877629; a=rsa-sha256; cv=none; b=Y0T38vd97i0jNtqQa/fu1FTPmkKDKMYlKBkkWuXLiR0X+KQsW96NCOzZs4sgJAfVV+7nvY Y8ZsvFUGZBIg9cJXMU/1cWt2uVju/6F5YD5QNjmZG8Zd+DNc8JeEX0on5bx5qJpWWOYjIg krCF7RxZtbnsRn8bXhgoIRafbTvDblM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VNdj7pQZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722877629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VidfNFBAtcaiXTxJdY0cu2dUh9yHTRWIKk+TOXacxTk=; b=y9kSI1lqyMfymT/fH0eRRo2otyArKvPqYIB+qUGKa6Dbtn42jmv1snqkr/By9QU4Ac0vgo 3iLMfSriBWASqcbgaTZI3wbaIXoSom6LGCwdF5RgOYiiXZ55li2LJC2gtffG6DlGum/3LI bAP4+0Q/oi6tT0UBn4ok+ain8rG1ZMw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D62DA60CA3; Mon, 5 Aug 2024 17:07:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C020C4AF0C; Mon, 5 Aug 2024 17:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722877677; bh=8oDLsrYMWaJslusr/zMMcppEbGxigROfZnvgJbcs1kQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VNdj7pQZ2QpTGcBfZko56BcFj9SNEjepo2DM89QXZZPk8LeY+e3Lu6chB4DgunfJs LfdIJCtGaExWxr4SyQga+c5JqikMuVVVU5+Ig3e7WMN6WuAOxXdEKMQnAoxtpMV0NS lIL3wuCiLzjbJQz0EVdr/YlJPdfxmyRdgr/Ofg7883YYqAbgaGCCYNjvBvWcOYm/Fq +/9J4R695vVsaa7923qaSKdfiqvdYd4iHTRNO4/rNMa4rNpWRWs9QFkLwcqxGd0o1Q X4dy7c/oPVmBJoO+KOjufTnnjQsQr++PBjikSlJcj4jvuKLcwlZYwasTyXi1jqk0eC R+3h4XlUh7kXQ== Date: Mon, 5 Aug 2024 20:05:51 +0300 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: References: <20240802010923.15577-1-richard.weiyang@gmail.com> <20240805153720.myjqd6ur65x5ucsu@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240805153720.myjqd6ur65x5ucsu@master> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F229080005 X-Stat-Signature: x83z7dnyhubznq1pjws8jtudkset1kbj X-Rspam-User: X-HE-Tag: 1722877678-907059 X-HE-Meta: U2FsdGVkX18zR8+XY9DwOT88zrdteuzXl+Bgo9kSnK53m/osgqiircVvZ4VeghV60RVFe1hakfWkXei3QcldMsh49vpGh/COl/eUteNB1qBS1BiRIqc3lsrbJgsFENMsE3i3b13/A28OM14RDaSugknXLJJGhtMfb9RCqeyWtOzZ72hyXqGnP6lmeWEAEpuEWlcyrwVn8jybS4OBd5JqVk+mOO0FRMgo3U9ZKdfbWP5AC+7iSsEC2/Jz194PbnrPZ7O3hGu955xzalx22VGThTbQFcgTAJoHyNqwHlLIHtt2x+ILoADWhxgdbv4w9bbJpl3n9etYqXjCsX468MKg79sOU6mOqNAEcY4qgUZdbDLa2szcjbcDE5mSB8nNAZJyjx8O+STLo+/1VoOGPDXmRHuRmvTYSmjTIrnvlhG0jZMuQHPNjQSwznc9hSOJBQdRwH3VoICmoVKut8dIXmqmYXmOhFVBnX3N68CCu9wNqxMpPYtjzGSggAc4qE38ZgXlY9SRX8v82jtJ6HjoyMZd06PfAjeAlfb+Z5reSP4COK6/v2MDlh6GxVBZwERWdwazffTYtJV1yy6/VgTh8zHL2ByOahEqbACy2JGDCJgJczIYqxLkVhGa+RSzsy19BYMN4HLduo3r8t6JWReJi0ARFzPZhS3Thf2YFzQX7RL6csaV8b5L1euuRH+tax+hQgQ4NvBMfR8RDiql3jv1zb5YWqyjdBt/tqozN6l+ZHv8SYZnNCqf1PF/eHRcaq4W0frL/dSkQEil8qHbsSF/RVw7fedbMNoFQiYKkmcPJjmTboqAeECKz5ZeNQq/MqPo6Ob82OswLbhoYJV2EppGcIDDyLNKiohNx9vRbzWofijCK+gT3pPK7KDlxSQJL3w361CjN4ltD0WIYR3bOqqZpwO+raL33dOE2Z5UvddDZeUXGLEsI0Mkw76B4WQK413izFeJjiV+VrXMuhBNMfJR/JB NntJIS7m p5tWU9h2c2bD3isp4ECACyLSbid0cYmpZNJctMG/3rcaj2rbA0Msc65/GaAHXZ1oIOATN9yM+sUn1NGO7kCZqVTwY0+aexxIAVwzUPe/4J2Fy5DhFYBgC2jlq648dIvhVZbqzS3yMBwxOzpW7CKcuC1+AaKy3Z1UWm77PfP8Wb0krcfRDoEEcD2HGgHcNHyOjhhsiWho5C98bWCMASSOyBWq3m8Gi/fR6g/rbACmgZR6RPyW4zIM/Iqcpa6iJnYP82v5xoF2qgmy+E3hNaY1Z0ltEiNsL8lBLi5Tn1ZFZApQZOf6WOjYPwBnx7ErBWXNSDSdWpGMolVtan3g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 05, 2024 at 03:37:20PM +0000, Wei Yang wrote: > On Mon, Aug 05, 2024 at 01:03:14PM +0300, Mike Rapoport wrote: > >On Fri, Aug 02, 2024 at 01:09:19AM +0000, Wei Yang wrote: > >> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys > >> alloc") introduce the usage of virt_to_phys(), which is not defined in > >> memblock tests. > >> > >> Define it in mm.h to fix the build error. > >> > >> Signed-off-by: Wei Yang > >> > >> --- > >> v3: use static inline as phys_to_virt > >> v2: move definition to mm.h > >> --- > >> tools/include/linux/mm.h | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h > >> index cad4f2927983..c9e915914add 100644 > >> --- a/tools/include/linux/mm.h > >> +++ b/tools/include/linux/mm.h > >> @@ -25,6 +25,12 @@ static inline void *phys_to_virt(unsigned long address) > >> return __va(address); > >> } > >> > >> +#define virt_to_phys virt_to_phys > >> +static inline phys_addr_t virt_to_phys(volatile void *address) > > > >Why volatilte? > > > > There are two definitions of virt_to_phys: > > include/asm-generic/io.h > arch/x86/include/asm/io.h > > both has volatile. > > I just copy from it. But I don't 100% understand it. Let's keep it inline with the kernel definitions > >> +{ > >> + return (unsigned long)address; > > > >This should be phys_addr_t, look at its definition in tools/include/linux/types.h > > > > You are right. Will fix it. > > >> +} > >> + > >> void reserve_bootmem_region(phys_addr_t start, phys_addr_t end, int nid); > >> > >> static inline void totalram_pages_inc(void) > >> -- > >> 2.34.1 > >> > > > >-- > >Sincerely yours, > >Mike. > > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.