From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FC6C3DA7F for ; Mon, 5 Aug 2024 17:17:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AADD6B00AD; Mon, 5 Aug 2024 13:17:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75AB26B00AE; Mon, 5 Aug 2024 13:17:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 622046B00AF; Mon, 5 Aug 2024 13:17:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 403E36B00AD for ; Mon, 5 Aug 2024 13:17:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DE039A843F for ; Mon, 5 Aug 2024 17:17:42 +0000 (UTC) X-FDA: 82418848764.22.D2D0290 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 2DF7014001A for ; Mon, 5 Aug 2024 17:17:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Z7q/lW63"; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722878253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DXDScnCj5Fq32blUBCPLnxMhTjkl8uFnAj1OBiC0Kow=; b=I7/+MpUzUtsZ3oCHBGb/0xxI6uXYi9NCpFzd6GJoW9ZcIF4apo8qQWBs7llnaFh9EZfyV/ uIbJ0Dq7RMmb7TNgUk/O62KzgKtvCE6Xyy1+PpbDnxoUVOK8SYC+lzOc/tfg/1O3F/SG0T psUSu3R1X+POU25tHwPCPXanzxld4Ik= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Z7q/lW63"; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722878253; a=rsa-sha256; cv=none; b=WWpmGf4U5AFDfKP6A+AWOfIjiABHNAJyIl7/vEhApqj3aKOxWIz7pEuxFh1VKyyke1WdJS 7l0qepOc2rVidaCSAIevJ0OZkxb2L8l/JeEKndTvz41/q0nSB8F7pCwW9E19xGVmayP+gX v6m7t2eAsjNjdhrCXYtivcQGIP0W1NE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0CBA960C67; Mon, 5 Aug 2024 17:17:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A951C32782; Mon, 5 Aug 2024 17:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722878259; bh=xUiHKiiFB+eGRf4/0vdH6U+v/YkOQHoLKaT521lWFxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z7q/lW639aowtINXwVebTG+OLoxrXof+zBNSeR/8WY86B+624ZIuqcPJ12uz6WAq3 TOktvjQuFO3Psh/zSZk6bupzno8UjNgzGdjWYsGzuDHPa53tI5UwJrFUIiEWAMkla2 aZhopzXWwqHlnm+KETHsoZ8cxcOCV/ES/RMeaNClV0U/lI74zaSa7QLz8oGGmPM5b+ WVRXAQQqToAOAcGGygHFeY2KPxgU/pB39IDAe0i7d4FyqehFfReXcy3JQ8TWWNvwl/ YnEvZ6i15oUR+XxxozKV+u9zlrKVedpz+W1ReJtnBjYdPuNzzekfqSWqwV+cKpPHX5 XzWc8YkjVKQSQ== Date: Mon, 5 Aug 2024 20:15:22 +0300 From: Mike Rapoport To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , Zi Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, nvdimm@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 09/26] arch, mm: pull out allocation of NODE_DATA to generic code Message-ID: References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-10-rppt@kernel.org> <20240802105527.00005240@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802105527.00005240@Huawei.com> X-Rspam-User: X-Stat-Signature: huhd8a4p58onmd5j4yxu64pxoxs7o59a X-Rspamd-Queue-Id: 2DF7014001A X-Rspamd-Server: rspam11 X-HE-Tag: 1722878260-504689 X-HE-Meta: U2FsdGVkX1/flRJHBlEVTnr6/6nxRYbk7/HTMF7DdAFiRxfkvAKDsdLrfpA6JUrR5iFoYaPX/ro/W/TybCbzmfgcwywRU2EWKVh4Xn0HXg/7LzOOC3OqeT0KjdK2PuUAugJDcKnB7/JN9BF2sL7wIHw3NwHKF84LGiiMQiuRs2PkVr/RprdhT1t7YpeP2Ty2knDORWpc9y9QMlUTJ+6o1CHEsQ7ecZnLn325y4pqRlHXGs4pt/CFtk49+HKSCWc1iYSy3tjwVV4wjWlFaEBNaLZF7rQj58b1+JvkW3sFkxR8UM/oZZFTo7csGMOsv0cSXkG6XhJFcWNMO6XF4UiCLCBmL1au30O7CTlSJ+srB9z28lVjF47YMHOJVrK3rt2AsRyGqSLB3dTVSvARqrGTw5Wn9DpR40klElACq8J+AonX7uU7ie3uhbINSJLMtBTKUpjogKmKMWulA/EgCydlWHVdAOV6XY2Z96R3SJJOuzfG6HIcLdBF+hGdEYZbzUcYsyWRlLVi1mejoP49ECmLDc1vGBPMHwAnFGa9B9XIFdPrWmV6q6O2ANbOFL+XVPUk1Bp7tus96h5PW3v37xHqBVijGABRPisnmimMNPkbmU/agNIjWpuoMXhtD7/1EXpiM+8eXfwRWPbRwHlZLp+HbMDuNZ/wEX+U/fb8M3oecq4ncQDIc3zaj7iICU64BXsxBOZZq1aZmE4KWmwXwtxPIsKvaZ14GJwB9T4Kxusuey0WnZvQgJzQqkcOAN6rmrasAzjv3rPLPtwWSgjmjbqS5o3vaAkbxYzrgYbi33GXBdu68dbsYaKbpaVB2OeHPfs+5LcUSns/ivZlchmpcKDYA1uYNvKPGWyTXMvVNPyZ6tbmQQhxmD/VNNrf1Rjyox5R42Z+Fhv6J16x2C7T8uo9Qj7TWLid0xU0BjJHSebI1K4gm2j0sSMy4WtwCX7CPV2ZKp2ztqdwPhVp4++Rvvy A51q1FUs CFaLwDhCoM96qhi3jpTFsQSher9OVWQtiGD9Wbtid+Oob8OKEeC6VZf5Qtcla4NEhy7c7EPeF805hnFGRrhEGxUROXiXuOVw9JRzWCDx0BoUSULUfRKmd9Jk/ZNUpyo4T+RqCnUaabWJH3GymtAZwIBqaUXUQwpLCVjSX9t1z3Dgr1IsRpcKB5a1rq3COnvaFvFUjh2f7TxZOgmC9SNR0+JL31e2sbYFXZ2UKmqF+fSndQ5foD4K5AaAlfGiM/O7eeqOBQ6cKsF6mgED/eVikJ55Px4J5piX1I8crV0sbhSzYXhL1E9ZhHarKKlav/vuDeIz9V6U6xSHOEn4dV4tKbhdFwxSERrqlnVUFpVExuzzC+wjijka2n8M9JcUH2JGRWdlOEm9KAowKHwqDU5Qos8DfYSHMb2T1pT9Yzic3GFWDfWcCX/uwoDve3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 02, 2024 at 10:55:27AM +0100, Jonathan Cameron wrote: > On Thu, 1 Aug 2024 09:08:09 +0300 > Mike Rapoport wrote: > > > From: "Mike Rapoport (Microsoft)" > > > > Architectures that support NUMA duplicate the code that allocates > > NODE_DATA on the node-local memory with slight variations in reporting > > of the addresses where the memory was allocated. > > > > Use x86 version as the basis for the generic alloc_node_data() function > > and call this function in architecture specific numa initialization. > > > > Round up node data size to SMP_CACHE_BYTES rather than to PAGE_SIZE like > > x86 used to do since the bootmem era when allocation granularity was > > PAGE_SIZE anyway. > > > > Signed-off-by: Mike Rapoport (Microsoft) > > Acked-by: David Hildenbrand > > Reviewed-by: Jonathan Cameron > > Tested-by: Zi Yan # for x86_64 and arm64 > > One comment unrelated to this patch set as such, just made > more obvious by it. > > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > > index 0744a9a2944b..3c1da08304d0 100644 > > --- a/arch/powerpc/mm/numa.c > > +++ b/arch/powerpc/mm/numa.c > > @@ -1093,27 +1093,9 @@ void __init dump_numa_cpu_topology(void) > > static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn) > > { > > u64 spanned_pages = end_pfn - start_pfn; > > Trivial, but might as well squash this local variable into the > single place it's used. > > - const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); ... > > + > > + alloc_node_data(nid); > > + > > NODE_DATA(nid)->node_id = nid; > > NODE_DATA(nid)->node_start_pfn = start_pfn; > > NODE_DATA(nid)->node_spanned_pages = spanned_pages; These are actually overridden later in free_area_init(), it would make sense to audit all arch-specific node setup functions and clean them up a bit. -- Sincerely yours, Mike.