Re: [PATCH v3 4/4] mm: don't account memmap per-node

Pasha Tatashin
2024-08-08T19:06:13Z

On Thu, Aug 8, 2024 at 2:55 PM Alison Schofield
<alison.schofield@intel.com> wrote:
>
> On Thu, Aug 08, 2024 at 03:42:37PM +0000, Pasha Tatashin wrote:
> > Currently, when memory is hot-plugged or hot-removed the accounting is
> > done based on the assumption that memmap is allocated from the same node
> > as the hot-plugged/hot-removed memory, which is not always the case.
> >
> > In addition, there are challenges with keeping the node id of the memory
> > that is being remove to the time when memmap accounting is actually
> > performed: since this is done after remove_pfn_range_from_zone(), and
> > also after remove_memory_block_devices(). Meaning that we cannot use
> > pgdat nor walking though memblocks to get the nid.
> >
>
> How about directly include the failing cases and user visible impacts as
> reported in the Tags appended below.

Do you mean adding panic backtraces or repro steps to the commit log?