Re: [PATCH v3 4/4] mm: don't account memmap per-node

David Hildenbrand
2024-08-08T18:26:48Z

> #ifdef CONFIG_COMPACTION
>
> struct contig_page_info {
> @@ -1255,11 +1272,11 @@ const char * const vmstat_text[] = {
> "pgdemote_kswapd",
> "pgdemote_direct",
> "pgdemote_khugepaged",
> - "nr_memmap",
> - "nr_memmap_boot",
> /* system-wide enum vm_stat_item counters */
> "nr_dirty_threshold",
> "nr_dirty_background_threshold",
> + "nr_memmap",
> + "nr_memmap_boot",

While we're at it (sorry, I should have found more time revieweing this
earlier!) ...

What is the unit here? Should this be "nr_memmap_pages" /
"nr_memmap_boot_pages"? Like

$ cat /proc/vmstat | grep pages
nr_free_pages 3618323
nr_zspages 3
nr_anon_pages 1053316
nr_file_pages 3199210
nr_shmem_hugepages 546
nr_file_hugepages 0
nr_anon_transparent_hugepages 0
nr_page_table_pages 15215
nr_sec_page_table_pages 0
numa_pages_migrated 0

Nothing else jumped at me.

--
Cheers,

David / dhildenb