From: Matthew Wilcox <willy@infradead.org>
To: Barry Song <21cnbao@gmail.com>
Cc: wangkefeng.wang@huawei.com, akpm@linux-foundation.org,
baolin.wang@linux.alibaba.com, chrisl@kernel.org,
david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org,
hch@infradead.org, hughd@google.com, kaleshsingh@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com,
ryan.roberts@arm.com, ryncsn@gmail.com, senozhatsky@chromium.org,
shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com,
v-songbaohua@oppo.com, xiang@kernel.org, ying.huang@intel.com,
yosryahmed@google.com
Subject: Re: [PATCH v6 2/2] mm: support large folios swap-in for zRAM-like devices
Date: Fri, 16 Aug 2024 22:16:57 +0100 [thread overview]
Message-ID: <Zr_BydCiQInI0ZMz@casper.infradead.org> (raw)
In-Reply-To: <20240815230612.77266-1-21cnbao@gmail.com>
On Fri, Aug 16, 2024 at 11:06:12AM +1200, Barry Song wrote:
> When memcg approaches its limit, charging mTHP becomes difficult.
> At this point, when the charge fails, we fallback to the next order
> to avoid repeatedly retrying larger orders.
Why do you always find the ugliest possible solution to a problem?
> @@ -4244,7 +4248,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf)
> }
> need_clear_cache = true;
>
> - if (mem_cgroup_swapin_charge_folio(folio,
> + if (nr_pages == 1 && mem_cgroup_swapin_charge_folio(folio,
> vma->vm_mm, GFP_KERNEL,
> entry)) {
> ret = VM_FAULT_OOM;
Just make alloc_swap_folio() always charge the folio, even for order-0.
And you'll have to uncharge it in the swapcache_prepare() failure case.
next prev parent reply other threads:[~2024-08-16 21:17 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 9:46 [PATCH v5 0/4] mm: support mTHP swap-in for zRAM-like swapfile Barry Song
2024-07-26 9:46 ` [PATCH v5 1/4] mm: swap: introduce swapcache_prepare_nr and swapcache_clear_nr for large folios swap-in Barry Song
2024-07-30 3:00 ` Baolin Wang
2024-07-30 3:11 ` Matthew Wilcox
2024-07-30 3:15 ` Barry Song
2024-07-26 9:46 ` [PATCH v5 2/4] mm: Introduce mem_cgroup_swapin_uncharge_swap_nr() helper " Barry Song
2024-07-26 16:30 ` Yosry Ahmed
2024-07-29 2:02 ` Barry Song
2024-07-29 3:43 ` Matthew Wilcox
2024-07-29 4:52 ` Barry Song
2024-07-26 9:46 ` [PATCH v5 3/4] mm: support large folios swapin as a whole for zRAM-like swapfile Barry Song
2024-07-29 3:51 ` Matthew Wilcox
2024-07-29 4:41 ` Barry Song
[not found] ` <CAGsJ_4wxUZAysyg3cCVnHhOFt5SbyAMUfq3tJcX-Wb6D4BiBhA@mail.gmail.com>
2024-07-29 12:49 ` Matthew Wilcox
2024-07-29 13:11 ` Barry Song
2024-07-29 15:13 ` Matthew Wilcox
2024-07-29 20:03 ` Barry Song
2024-07-29 21:56 ` Barry Song
2024-07-30 8:12 ` Ryan Roberts
2024-07-29 6:36 ` Chuanhua Han
2024-07-29 12:55 ` Matthew Wilcox
2024-07-29 13:18 ` Barry Song
2024-07-29 13:32 ` Chuanhua Han
2024-07-29 14:16 ` Dan Carpenter
2024-07-26 9:46 ` [PATCH v5 4/4] mm: Introduce per-thpsize swapin control policy Barry Song
2024-07-27 5:58 ` kernel test robot
2024-07-29 1:37 ` Barry Song
2024-07-29 3:52 ` Matthew Wilcox
2024-07-29 4:49 ` Barry Song
2024-07-29 16:11 ` Christoph Hellwig
2024-07-29 20:11 ` Barry Song
2024-07-30 16:30 ` Christoph Hellwig
2024-07-30 19:28 ` Nhat Pham
2024-07-30 21:06 ` Barry Song
2024-07-31 18:35 ` Nhat Pham
2024-08-01 3:00 ` Sergey Senozhatsky
2024-08-01 20:55 ` Chris Li
2024-08-12 8:27 ` Christoph Hellwig
2024-08-12 8:44 ` Barry Song
2024-07-30 2:27 ` Chuanhua Han
2024-07-30 8:36 ` Ryan Roberts
2024-07-30 8:47 ` David Hildenbrand
2024-08-05 6:10 ` Huang, Ying
2024-08-02 12:20 ` [PATCH v6 0/2] mm: Ignite large folios swap-in support Barry Song
2024-08-02 12:20 ` [PATCH v6 1/2] mm: add nr argument in mem_cgroup_swapin_uncharge_swap() helper to support large folios Barry Song
2024-08-02 17:29 ` Chris Li
2024-08-02 12:20 ` [PATCH v6 2/2] mm: support large folios swap-in for zRAM-like devices Barry Song
2024-08-03 19:08 ` Andrew Morton
2024-08-12 8:26 ` Christoph Hellwig
2024-08-12 8:53 ` Barry Song
2024-08-12 11:38 ` Christoph Hellwig
2024-08-15 9:47 ` Kairui Song
2024-08-15 13:27 ` Kefeng Wang
2024-08-15 23:06 ` Barry Song
2024-08-16 16:50 ` Kairui Song
2024-08-16 20:34 ` Andrew Morton
2024-08-27 3:41 ` Chuanhua Han
2024-08-16 21:16 ` Matthew Wilcox [this message]
2024-08-16 21:39 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr_BydCiQInI0ZMz@casper.infradead.org \
--to=willy@infradead.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hanchuanhua@oppo.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=ryncsn@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=shakeel.butt@linux.dev \
--cc=shy828301@gmail.com \
--cc=surenb@google.com \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xiang@kernel.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).