From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6FCC3DA7F for ; Mon, 12 Aug 2024 11:39:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED4576B008A; Mon, 12 Aug 2024 07:39:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E83686B008C; Mon, 12 Aug 2024 07:39:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73266B0092; Mon, 12 Aug 2024 07:39:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B8DE96B008A for ; Mon, 12 Aug 2024 07:39:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6EA09A1CE2 for ; Mon, 12 Aug 2024 11:39:08 +0000 (UTC) X-FDA: 82443397176.03.2A6FAA1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id C0A8D80014 for ; Mon, 12 Aug 2024 11:39:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0Hghn9jO; spf=none (imf30.hostedemail.com: domain of BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723462678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9QeBzfyt7uwo2634Q3bLzYTBJAAbSVcjEFRlDnwoGms=; b=RRzBWy3OsD+wb3P3PFDQvI4R5lgMjH9hMGqbUYbzSkG3SuMR8uQKJxuGBDHrPTFjpoeLoG 2NA+b8LhoOibxA76DvjVzuxOJ7Xf/cbzW1QPIKMTwInnYHlHWfEAeeE7+QQ11Y91LI33tY a/Ri5K72IwTaQVc5aKo2AgXj+KMK4wo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723462678; a=rsa-sha256; cv=none; b=Xl0GN0NFLT0kacTdcIe5IBRgrMJdsZFyE/UhvVmG4Sky97bQmmsTFq12Jv49wma/IOoydb 3yQ1BeD2HZ7XvQv7wiRPnFLYbVBmBE9l3z5V97Y5xKwbXRJdPtw88BMLzaXo3WDaN10OnU nOQO/VuXFHtWcuBuX5Aq+Bq5YDhpI5I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0Hghn9jO; spf=none (imf30.hostedemail.com: domain of BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=9QeBzfyt7uwo2634Q3bLzYTBJAAbSVcjEFRlDnwoGms=; b=0Hghn9jObIur5bYWdn9rRa58al DiH+aIR3oy2lZGsv766i210aOiNBl+qa4loPUpcwbJrMwmF1XmHd3fjy+r743Dt08yL3Jbd9Q0Au5 tMTuRhymFJNZbjOjl+OG75qKaR7YXhbCe+rBVnT3vcZccf8YtB4jlXT0T/MhBfeSS0ih9ZLpZoF7P m7VSKCXiZBoIkLiY7IhHMTJ88Es6jXOzCgmrhKein9ySMDFURMbluW9gTKDJNQuHGH9hzCJZICXQ0 xVbGOhErkfjC8FEP2nuuLHrD3h9/M/o6e3vxozngMxl0u7xgyJVAplMKudvkRbZrzqWeDuPQUU5Pv 68Cs/U/A==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdTO1-000000009df-2f6F; Mon, 12 Aug 2024 11:38:53 +0000 Date: Mon, 12 Aug 2024 04:38:53 -0700 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, Chuanhua Han Subject: Re: [PATCH v6 2/2] mm: support large folios swap-in for zRAM-like devices Message-ID: References: <20240726094618.401593-1-21cnbao@gmail.com> <20240802122031.117548-1-21cnbao@gmail.com> <20240802122031.117548-3-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: C0A8D80014 X-Stat-Signature: 6ddjnhx99ij57hr7d7ptjpwpaafqbixm X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723462746-972702 X-HE-Meta: U2FsdGVkX1+QQYR2ulazSGcOrdAF/4QGMzAJ2hkklcoAUrQXOGfmUQKEBaRlM3POJzaT2Cw2IUD59EKsE+7dcthCyZbONWe5mOHfzVULyRHcexlX8RdwJduSve8dbftFb1ukZyW9PNuQjjSI4IlArXUkqqACUo7Gf/yXbW6Sc/Chq2gt14ZOrX1OT1kGADKdNt3DRq8HBXrRsdPJWRn2ux1Rm3bjh53zeZXtHl3qi/oCjlpcqnZq4aiP271Z7/lbBm9EAVt/X+eSdmWm+APrzFR2kogE6qNwzQbca0TvGw7+WzmGT+otk9ExqtzuC+6ei+bAR8NMolkzB1C2D6tZVszLAfIkRbuE3LGUZFfrWUppH6Xrf0/oVm+P6lK2pdYGxM3vzNz9JQnZwYZ+wv9ZX6KC3Qysz/lGXUn4LDnDYEbWaDkkAVUQ1jcqw6kMvm72dl5EHSNm/6aGAjIYYbIU4NodTTfeWhOeOSUn8yDEDgJvd8OcIEioXkmElqJk/qZPpg+WP35+I09Yce9Iy7G+Q9mpdCnPU5FKQg0nYXNNyzkN82yYyftIjDRKML9UIDSnZExVbMwiU3JD2kh8EfjeZ7Y6vyfX2yD/Vu8gTIkGjjtCn1SI+Rf1GXTGB8wZVLHABWh05OuXBDkHRIcQD0rc+E5reKGFOPit7K7/VtUzllw73IpMpL4R8YfBpa0m6mn9lLkhfvgPtXuw6etf0p5Nq1fAb2ZDepLpEFLmZqVCD4CbmITHYGRNCgsL6U/IkIg27aM7nd3CF79RORfzx6jsATOmbOsqVynFfMpDUV3SeLVfhe8/cF1yqu5oF6yu84ajtuOcucU4cbCrtYoXCGmgPWMSMvcUlleWncf+Mh6/tC4FlwiQIZjQ28dzTAhAerUQ8N+J5X8Z04VXI/5QsTSvVxDpC+unp+3VByfent/Kc7nKTZ5KPsIiDM4xW9s7BCTtKnNuywc5NWjS12CZTAY Yix0QGP7 uZWYCHRP41Ggqumact1Z7Q2mhQyi+U8wjWs+0khtmAWAJq6xoEQyH3cH/2j8znjddUdebOlwDc1PehMHfro3KOoTAtTv8fSxoiSIQfJgfGpNLSnxieJZdV7NZ8fND/jtQugpEvKJvskVsT9rQql7gzj2P7SJL3ZE75FiFVsYV0XqipEr2E6jgbI8Oe2wQfkuIxhdEk/cFiz/G6BoorbWSORyVrF+p2bKMC1c4Nh1MFWPjKUc/nmKYYJSpo7lh0HJkUZTmKdmTSm2GcTb9S2Diov4aizkekrNHT0db/LbXeNqvb0G+wvxkOuDNc+efCCOjCcpCtlWa9UZbWSYUb2xA0Z0GvR+s7mb3/OYk62jIlPDeCEaS9ALSRqbgiQZrzo/oH63nao7w39NYzWt3ZuEBkDRR7y7t9bP3vCOkxQo5yTk++TTvM8yZv7DsGT6h7ZbsaJ5+MPwLbE3cX5JYOzn2gKY9pjr7B5HFmOoWxKaIXWi8F/AWgCfUad1KG2af2100992VW2Zpa4KlpmoeLzWEBai5X6Y1q95aqwN1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 08:53:06PM +1200, Barry Song wrote: > On Mon, Aug 12, 2024 at 8:27 PM Christoph Hellwig wrote: > I assume you mean the below? > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > static struct folio *alloc_swap_folio(struct vm_fault *vmf) > { > } > #else > static struct folio *alloc_swap_folio(struct vm_fault *vmf) > { > } > #endif Yes. > If so, this is fine to me. the only reason I am using the current > pattern is that i am trying to follow the same pattern with > > static struct folio *alloc_anon_folio(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > #endif > ... > } > > Likely we also want to change that one? It would be nice to fix that a well, probably noy in this series, though.