From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7382AC52D7D for ; Wed, 14 Aug 2024 05:24:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7179C6B0082; Wed, 14 Aug 2024 01:24:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C6BD6B0083; Wed, 14 Aug 2024 01:24:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B4E66B0085; Wed, 14 Aug 2024 01:24:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4293B6B0082 for ; Wed, 14 Aug 2024 01:24:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 941EA140C75 for ; Wed, 14 Aug 2024 05:24:27 +0000 (UTC) X-FDA: 82449710574.09.C3961C1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 5128120003 for ; Wed, 14 Aug 2024 05:24:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tb7nJYp0; spf=none (imf13.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723612994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YtGli/qwsKnpfvyTqwkhaTjpFa79AO0G8UUfN1W/xSI=; b=hY3jltkGQ2pIcIs4jxs2wMsnrGxJmQg3Oln8BT4OfKcV+J2vvA3WG1VU6SxnO4M9Z1IG1M Jwm28nGcpJsDj9blN63QuGPHkIAr8E43qENz7YeU0om6GsMXNLyioFSmEKRBXbX8eC229X t+CudN3a8zhPQ3hiIDmJ67DeZ1EB/P0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723612994; a=rsa-sha256; cv=none; b=Youb6SJjk8aYwJz2x8A+tcy74GgHCRkIivdtpqTb8a0Jr0JQ5OFddRxrzaT2tiz6idX22q yqDZ45wwhDMmI9sIi2vn4Cv8URxNA/l0cb82L+2oqw1VA2bES2HEZlvXk4WJbJKrJxST4K rTSj1W9Ewv8LJ6Zl7P+iDx/+kKM+DYs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tb7nJYp0; spf=none (imf13.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YtGli/qwsKnpfvyTqwkhaTjpFa79AO0G8UUfN1W/xSI=; b=tb7nJYp0FTmqAlbqxBJivVrXdj 4obYfqa1Ddwr2TlS48jqiSlhoBJQ7R87ElLyAEbQq0hjY9Ub7yHDSg5lIz7dhrDGOvO6AtD++vaPC ABpanMbwD3KLRxWScfPhyaZvOQdhC8fy4fl+na9Ee2j8Qn2iQU6S/YfFHvf0S+bPL/qyPTwcLIQ5S sy/85FArFjVCIHrlAJ/TSF5qRBmTCiRP8JTdszEngGH92SqLEPE6obw/aeRnlQRk5IZVLHHghnxxr euaRC58SJb9vCZJz891WYtJcaNWPAguiRwcZLDmSDdFzht4g8d/pxy+W6MjlnhEx7uubKvKDTbm/f BugAn78Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1se6Uc-00000005nMv-0Kva; Wed, 14 Aug 2024 05:24:18 +0000 Date: Tue, 13 Aug 2024 22:24:18 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: Christoph Hellwig , Yafang Shao , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore} Message-ID: References: <20240812090525.80299-1-laoar.shao@gmail.com> <20240812090525.80299-2-laoar.shao@gmail.com> <5evd6n5ncanmyc2qtjpb44bd76xj7icitdf3g6xeb2eiofh6ht@eqm6r2ch4b3l> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5evd6n5ncanmyc2qtjpb44bd76xj7icitdf3g6xeb2eiofh6ht@eqm6r2ch4b3l> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 5128120003 X-Stat-Signature: a1tzebedc9eo1jwgwsrus5x351ozm3h6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723613063-335119 X-HE-Meta: U2FsdGVkX1+QmDCOvJ5tQFOp7XuleRRGxON2l9/8zchSbo6knNNTAUg7aMe2Qj4+B9vmxDdcqNQUDDnA1lKp7+UK2hscAZWEYnBmQnkPza8HtXnPSoy+oyuYrlonnSOskDBl7y93aJq2R71/VudJt6LjoOiJlluohndyEUmAtVQvUlriQT6syakj5YuIq3FHSmO/6ssoisYWmNVBEbxIo2SpLM/8WBU5FT1wN6nDjWDNc6iBafNUiwBAkoTiOC95l6QgeYRitU4AW06MwasNu66cBrmDlPxTn7Brf10EFKNWTtjEYcwL1ZeC9vAYkpn8q3489qZkTkL2NX0rHEISQaAdY6/+1mhwE5+PKmU3trJOvOrHDNmNF6U2cg4C039OvQ93Lp3ifa+lka6OF64O1cah5aY+A+jBXpPuPtSAPEqPI3hGgp22y/lTbCHfyIEBDj9tE0oWL1cZvqyynTugwo3txIsN9SF7d4W4H3LDBerQyRR94m/vH7ppRQtvU3tPO1id6gcpkurAIFs+rgFUE5jbeZDSlFh3E4bzOcGjzJEOZNfXbWLwF8RCxxyvN+FeSvgKBQoW3NDrrH+/A2crKYVSFGwPi2CtsZFD78qGtkQ8UjmF1I1uZRFAhUxVlO29/nW7dCHa2f/LBbBYoDeM/kfY9DS4M/37rx4tmyxGSY7/1zviglJ4qTTG8HwNb1D04tGBv7ndI26QCmwQFQBEo08/9aTQZAmslj+Pn5xLpSUa5DawPHT+Os2Plwxv/igu+LYvwd+JESZzVdYjf29CvTrrKik9TBkI2MLGXVZs08si54NFpuESRpjaeRff6TkcGkPc2z/IbqlT/jBqGVXRSk6vEH3/weq7yo/I7dVYRM0+JUHzMvY+OzktYfGjP5569tFFN6V/AgzXFC2uKjC0tFMGSldVB9vHlYD/TWBVmvTHKtDBttWHuqBo0ZdFUEO0XP/jCFlEFhKfOOfB0SX SWIDslJr ybLdI9E3oYCVd7nbCOcU3Q0h4QfjoXbmRg6F1eQtWWVKTSs7Y7geXaV8CzXS4U48hNMZRZG2hxUKrfBcp3SIgs89GrvBN+gdwdvDbjQHqOnwID3A7w7VwN0QOpELHfExxMP/QX7McyL2L0+YLXSH6JLJqfy+bajd9D9Eyqp/NrJekr3bPa+E7k8KUKz1x9z4b/fNXNM+CkWuFWD2xML0cMpdr21bROKopDtldt7IWxs7VTmqOrMHlUhp56RuwAzsBm7dj3UnhtZqwwEmWrMzC34Alnm85mtmBE3xOtutTjcvpqQMMqzRPp8f4ZJRBC55cWUgca9EQrnCdDZT39eSA/pjJKmwsu0+FKtf79RON5GA+OnoG/LOpubyKEaw2bu7f+6z2XBTUNekhyYH4aZKomxOPSJxc2Hn1+tDG09fDiJNsJrXUwKTypj1Ozf3lWk7A6X0Hbp6Zo2VGRNSHObLeG2UezgFlQeWNwqC7var8r4Efp5T378Qf8fTd1Vp4+gbSB0VldZTly6b/aFJ9GeJC8+p6KoEbvPE02W+yEZXi9I3V/a6w6YBmG+JatA8sdVkA8W1A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 12:48:26PM -0400, Kent Overstreet wrote: > > Unlike NOIO or NOFS this is incompatible with NOFAIL allocations > > and thus will lead to kernel crashes. > > No different from passing GFP_NOWAIT to mempoool_alloc(), and we're > trying to get away from passing gfp flags directly for multiple reasons > so we need it. It is very different. Passing GFP_NOWAIT to mempool_alloc affects the piece of code calling mempool_alloc. Setting a GFP_NOWAIT context affects all called code, i.e. all block drivers under the file system, and possible another file system under the loop driver. And none of them expect the consequences of that.