From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95462C3DA4A for ; Wed, 14 Aug 2024 05:27:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2FB26B0082; Wed, 14 Aug 2024 01:27:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB86F6B0083; Wed, 14 Aug 2024 01:27:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58E66B0085; Wed, 14 Aug 2024 01:27:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B594D6B0082 for ; Wed, 14 Aug 2024 01:27:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DB683140C45 for ; Wed, 14 Aug 2024 05:27:42 +0000 (UTC) X-FDA: 82449718764.25.72715D5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 37E8416001C for ; Wed, 14 Aug 2024 05:27:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Qb16q3Js; spf=none (imf08.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723613226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aevGGSQc0VDR/d6wuXp/nfXCQB1eisuqo6Ik/+jFkJw=; b=iYxEs/xpO4/3nzxTZnrF/hFxItbWUeSaxydMYbS2BKJzTWCqI5KE3U/WKhG9cfSvP4Pssb IOMalbXnEQ5z0TOeSsM4NzcNwcjkmiPy+X2KPS7MBYRcjQhQu3x9mEWTCgtApYiiSZ4tvR XnKUP49CZvuWIl4FBE9YD1wDAgSF0nc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Qb16q3Js; spf=none (imf08.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723613226; a=rsa-sha256; cv=none; b=B7FbCMyBWceyKhluPMR8aX/AQzj2AEJkGZDZvMW0db1TN49T5BjDN7UdWbZbUjpFCGxAuT 5uBtEixEkkLouCH/94weN+YZfE1o7UzcfbZGObHo30yiNZftzSDDIpZsK0tNGcQWJMWpk+ J3huexkPayc9KHaPkiR6ZSUDJrQTYvg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aevGGSQc0VDR/d6wuXp/nfXCQB1eisuqo6Ik/+jFkJw=; b=Qb16q3JsdsN7s4kWdj4ZZvXBL3 4lf1p/6wn1Fb2JDM/kP8Q19dt9dLO+93dhZk2dD+736piFVbXEyVzCxsCizWqt8CrBrkn4ZxwHlpO 1ztmPDoDibogaINHXfQgKvY8atxnJmFAMu+OtAf1urIm0bCNhJIu09yhzm4GV25vgFQd+ew5AH64H jgw2u4VwwCk1pJVthvhh1X+IxvaeIAfDnwDNZLFot5/4hRfxaOT5uFGSCn4E2bGqPngCfDfF0WqhQ Nvs4dFMlQMFZNwqyzLG1XlnuWgMx/t1PoSNgX6nuF5wVDJgRHFoX+QlE49bEQiRAoRvwAYsi+J5Ha QDL7fiJg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1se6Xq-00000005nr9-3DHe; Wed, 14 Aug 2024 05:27:38 +0000 Date: Tue, 13 Aug 2024 22:27:38 -0700 From: Christoph Hellwig To: Yafang Shao Cc: Christoph Hellwig , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Kent Overstreet , Vlastimil Babka , Michal Hocko Subject: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore} Message-ID: References: <20240812090525.80299-1-laoar.shao@gmail.com> <20240812090525.80299-2-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 37E8416001C X-Stat-Signature: awz1pepxa7iz1s5dzjpc6eij5j8kw1x8 X-HE-Tag: 1723613260-170229 X-HE-Meta: U2FsdGVkX1/uRgN6A9TZrn+rDCITPTt7A3oPO/zlwI10XO8qfeq+GMP7yKvui1tm2Uo3+zGzF8mLjkv8VpttM1NgQsJ9tIWgdgJOJv50A58ZNeXQIKqgFV0LEfLFEwWLEml879ClQRr6eZKawBAetoly4VWwhYCAQdTcr9bOHwu1Yh0OKpcW+F7OSsvKdWfYrlDZ3gqQ11BbInXBQQVQkzQq+pw6Gn4B1edqyunr5FqeoB8tpCfifhvrLbXxPn3DByD/fvyFpmQXZzC4NWz234rpaMLdlOWQFkWqPDcbmluLCe7bN1aWGDYxRnKlEpMgS6hwIs2HvbMATLcSHZsx9xcyp2YtkyJqKhXWuZiPAHj2kdl01fh4lWEpXDcwTKzj/tUDWi18zrbskAZwgUzDFOgNNEF/xSCafChPZwpbm9UMReS0vKbIbmaXZmJqIAa0cO4gkh8llx/2dbpItNbJ7cWkSadI/z0t4raBYAIRrhHc7xeT6DMaWQKXDfGTZl7FF654rKeNykvgr7brMtNQKhNjSV0FfDtJVAvau0Jvww0nwOB5em3PUC6NwSOz28xPc5uzbWdSL1bnAoPF533H6zAfzLsgrvuSgPruyZMT52bEKjvvGytfD9rLKp4JIVgmImFNi425uS9d4viWzzyDukbu6qPDvcW/0rAuq/qmtChzroSdTojYwTbtppNKGXTaqNrtoNmdRdIwdceQsEqg0GY6rgeGPs13YwCNAIXBxx99qUKf+QVfw/oM4lkaOw5HGS2QQgPO91Zm2AL/xyFHG8kWh3cdR27UYfJd+L7fKs3Q6oRI2QL2MzdwP/ki2lZ+oolIYykJ0jr2qxj/gwIJfgIAUWMRpdsQhXEuvHp8v2GdoGRp3qlGFNdrdc9MAFnsbfq/G82FCxs05/r6i5q/vaY6m8ZMHPdF1IUrQD5z4xQH6Stt45XLQ/gkWijc7QTFLB1PX2Ykxf5RIlYzhrF +PMa1Xh3 lNyEYzvI/IgMsvh1ZDJQpt9t+8i9GjHIo+ufRliNC06RfuLJpVbiIVaq/mDcN00bsM+F8sDyDo/dJGKzWgpr+CWlfF08ZTq3y+yC5KnjUTDQ4k+h133CxIU++0Iy80kg+xf8jUEQU1V25ms8RmFkbjemV9Pn50M5Ku5BQOTKC4KJBrE6uAAyRJpEMYGthb0wjjMPF0boB9UKDdgSBFZq814z7w5Yd8iDUjG5TdiMxp1N2lWMEG6DUrJs75thsQku8+O0E2DmvJELhdEM+4PaQvGyqYux0YPK7RoZhT1JCePjTbPpbP9oSa+Ho+pJTnFMho561PKGIdhucEveOcrMM1goH68zURgTN5O1n1uOhTjvJIwGaXmTE/uE2uWjX7aovTdZJ5XIgOjTFIpOcXH935Tptf6sBSAFcTxZwOILmBNN5K5V9/X2sSD2xoydtDMSsxa3zCDb6crzLAeknUaQKeJqMsHCvM4I6GxdrQeUHWWWA+BHV8R7Ov5kMdB9UcKDCEpjA7Efus5iySpft+Lm2IDV37jeiLrG4HsmRt1zi+EsZ4DkdsW67xmPPuBv81GGh58NCN2zL/0dc7zM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > There are already memalloc_noreclaim_{save,restore} which imply __GFP_MEMALLOC: > > memalloc_noreclaim_save - Marks implicit __GFP_MEMALLOC scope. .. and those are horrible misnamed :( If we can't even keep our APIs consistently name, who is supposed to understand all this?