From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75332C5472F for ; Tue, 27 Aug 2024 13:37:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53106B007B; Tue, 27 Aug 2024 09:37:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B02F56B0082; Tue, 27 Aug 2024 09:37:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CAD66B0083; Tue, 27 Aug 2024 09:37:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F24B6B007B for ; Tue, 27 Aug 2024 09:37:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CB5D314193C for ; Tue, 27 Aug 2024 13:37:44 +0000 (UTC) X-FDA: 82498128048.15.ACE3207 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf19.hostedemail.com (Postfix) with ESMTP id D40EE1A0004 for ; Tue, 27 Aug 2024 13:37:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="Ia/BW5xN"; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724765775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AT4VXmb4R9vLR4EZHGzi0KQ518kZdDJ1Wc7PbdyET90=; b=klVSaagkEA7nC4K4FVqnp78WvQ4jcHaoyKESQwYYYE8E8dKX+4gxsmnTWOOONxg3F0jNS8 F5XRW6ozJMGBNEYVaLwIY6ylpPsULOQMHxX1GNgSL3B88VmbX7zEFO33y+5l/tkPpoBaeW gK9W++pw52iOD9tY+8osO9JCf3Du8is= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724765775; a=rsa-sha256; cv=none; b=KGLsJHGWHK9isiHKNsesTqq5t/q6aQI/dpbAp9rhhk3KQOkl8AOL7ZY+qwI68RUUfTaNbU +aWmtjI0uG6QkFZZIX4DQpWTOYoYnX7cfJ+cll0yH3hmPThdVvnqbBl1YentQ/6HC3x7tl AALt/O7vskHZTBm3eIMn+h19wM7zQ2Y= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="Ia/BW5xN"; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2f3f25a1713so64925021fa.2 for ; Tue, 27 Aug 2024 06:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724765860; x=1725370660; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AT4VXmb4R9vLR4EZHGzi0KQ518kZdDJ1Wc7PbdyET90=; b=Ia/BW5xN2OK9V19jdqTiETAJAW8xTwi81Tnimz44RQe6nSnuRfTG2Jo0u36CiND3dr MBveFem5g12ja9jSn6unoye1uNGDZOkS/B7NwueZydsB+3J833VBQJLpnYa2ljT4zcyX 9i5bLoZkI8HaWu8ebOf4kDENPNyALDhcCft7mCWwsrXO0742eHXRTCSqLRTOZbLh8WsC p3HWEmhpIkdu/EePLLzOd0R4e1hhDYwtI8i61E7DsuO4FknxQIdIRjcK9hqAwMNlpWzA UG77QXmWhvVqHHNzdmW0IquZ2g8QHLFOS+pjYFtOR/QiFgUsXBMHdH7TwNQwqom5jmA3 AlVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724765860; x=1725370660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AT4VXmb4R9vLR4EZHGzi0KQ518kZdDJ1Wc7PbdyET90=; b=T41D5MKduRB/Dw9Kpng/ZqbNYWO+8wp/XGbDcx61KtOKVk/jV08x8pCz66AeAUEMiy nMwPlNz3A+Lu3A7IlaDJyY38ELN5O0mFnj+OjvyEbV0m3VuRSJ1o7WbBxl4ajvKFdTey 0ERjbjMVo8mylqXWD1bMJtMC11mkycymSs3dKn3zdiMtON1ujW3VvkVofyKxFLAdKbKo ez3Oi1xfYY0DheREz2nMrqoHTolNVlRvXg2dDWg7QjWBn4VMt7z0HDIUkGYkyg0QgQv0 /nZymRGnmOyCtM5U+bLt8GN4o1W+AUO/Vqtr4ucqyhHuT9L1z9tj2QN14EBUOXa830a6 aqmQ== X-Forwarded-Encrypted: i=1; AJvYcCW4xujMEVfNFlAxTAkQjnWc6dbAKcceaZWfWkqEMuiNxsjHdzrhECmq9kRUhENEAu27M5mcuEMbbw==@kvack.org X-Gm-Message-State: AOJu0YxAelGgLEg022Nv5mtYy0g+FvYZaKR2VRShdRKKLhiQWokwSqbO /o1aLIjAQgUveRW2xfYwDrtb/BohRRJUtBM678HKqbc+gzrXPI8+P0Bn3SFENi8= X-Google-Smtp-Source: AGHT+IHLZaTBk7t7Tm5sDsRxPVC4MnBBYf4HikHA9gnfnsCOTEJ+b/dFLLVXn/7+6yLZPfm13I9ibA== X-Received: by 2002:a05:651c:b1f:b0:2ef:2b53:c77e with SMTP id 38308e7fff4ca-2f4f48d605dmr94846181fa.7.1724765859849; Tue, 27 Aug 2024 06:37:39 -0700 (PDT) Received: from localhost (109-81-92-122.rct.o2.cz. [109.81.92.122]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0bb1c2d45sm1029610a12.12.2024.08.27.06.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 06:37:39 -0700 (PDT) Date: Tue, 27 Aug 2024 15:37:38 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D40EE1A0004 X-Stat-Signature: 3ypd3mzdxkzmrej55ztyfcxejwj8uf13 X-HE-Tag: 1724765861-458353 X-HE-Meta: U2FsdGVkX181HSxy+/bCZx0jhtkC2HoGdar77FIa7KONse63ZXayoUOWfi/bOqrQLhG9IEr9Z9+hpF1JidPWXxh4C0H7JGBsgDqBhOlmolbKD92rMbIBbZCdP2dRLy8OZHot7BiLCGT24GxftwwaD+uGBQZ91mJ+4EN71DS6Y4FjZHwkEQ6tcbK2fhFaqkVlU750KnxKtC3Y+pMvquKuo/wNE8ep3HsV067I3sp7YzIH8pX/BPnNiqZqWKsKV5pV+vV9s5nhlKJhVZX2dVPLpxi7fLeErDwTP1MA30Kn4FdyI3vYkMs9YI1W37p8Ncv7yM0JGjMv5PCQclnmLxTte5QvacUoecJacnloTh1kmRmTSsDdoF07tUscFYTulN7Ai4XC/HjrRcEquKR69wrnk5FGJQz/BycpjbKRc3CoQATLJJClKhR5IhgbL5lFt6w44bsVmhasazRlL6t3CXiZVs6K9+EE+4jEvwY7IdWahIS0MSylGre6P33taOnU+BQkMwY/lWiCF1cqJ2rwaQnyYhDPjWF2TR7mndwVZf56TfkrS8Gmi/FI1FCrf1jLoyGPNFKF9Px/zRy+vHeNRB23QzLLH1uii9d9/rgBvc4G28e+CUFLzvyadpbTZqBf2enmWIfZzgWlaLp143MMr8CPhWdVFCS6wGhIA+XIMg184jQ+EgUmDwNFsQugU3x6hTPSzAIkfDzleJ43ZjGmyuzc0X+PU0JNzx8pWT0lWPFlFBT52+Xr1b+BvRPrqC9wwd4shOf4Urk7u1Xehk/HtBRjr5dVdo5mQnfPeLySLxxWtJZnYyNTTigVMN9FbZIUD2DDx1nXPaLlsv2AQmTlEtClIlxgSteJNDskrv9EToosNIN06UtppltJjT4+s0Y+QCgs1MVHabFrr1HVlxKD/F+Lgmnkh9VbA8WPJu1dyaNJS/ebeUPOWtXPwRJo8bn47aKxexyygVh3MlJsucPYmsm 2FI99kHA BKJh+JOtd0VJ5gTPQDFbLXhOjbN470rvBT9TY/bg/prHz/rAuey+An582ZoTaEpd1XWQxjs8lgaNV7kT+ZSQb/dAxTmWolO1BbrrvLw1flKB5u6BFXsZr3/bZBct7S2/rjdoTMU10Sf5HG5T7nuY/C0F8pvAc+sCDN9T6SD9f7zp/nrbD6keCTRJrPI4McrBht/jC2JxwzNYpHhrKCWHgY+fP8I6b5KNfJBOjHdstBUp3BS4ABHaaMOONZvBWQOM42Mfra0ifbw9qL3wGolCziCL4gw5mIBb9OhgEpKElmfZhKP7/9JMA3D7FOSAbvKLCTeE+E/QKrx0zaTh/JnFe1ooPGg5An+l4Z+9j5/0u05rRbRA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 27-08-24 14:47:30, Uladzislau Rezki wrote: > On Tue, Aug 27, 2024 at 08:49:35AM +0200, Michal Hocko wrote: [...] > > > 2. High-order allocations. Do you think we should not care much about > > > it when __GFP_NOFAIL is set? Same here, there is a fallback for order-0 > > > if "high" fails, it is more likely NO_FAIL succeed for order-0. Thus > > > keeping NOFAIL for high-order sounds like not a good approach to me. > > > > We should avoid high order allocations with GFP_NOFAIL at all cost. > > > What do you propose here? Fail such request? We shouldn't have any hard requirements for higher order allocations in the vmalloc right? In other words we can always fallback to base pages. -- Michal Hocko SUSE Labs