From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58A4CC54731 for ; Tue, 27 Aug 2024 15:29:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E17956B0082; Tue, 27 Aug 2024 11:29:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7426B0083; Tue, 27 Aug 2024 11:29:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C416F6B0089; Tue, 27 Aug 2024 11:29:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A7E406B0082 for ; Tue, 27 Aug 2024 11:29:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 16D08C1893 for ; Tue, 27 Aug 2024 15:29:42 +0000 (UTC) X-FDA: 82498410204.19.24DA5EB Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 08162180026 for ; Tue, 27 Aug 2024 15:29:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QdlV69bG; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724772536; a=rsa-sha256; cv=none; b=6Wc7SqxQvgZBg0hu1ZBl1cIuIt4JlctQzMQAk/zsyNHfjcR8+WtRfTFVpcaylasZmr05m/ pAqBuauORYhx9TdaQDJIPYJ/LkAXGEQcqNuTgjqbokOcN+3K+scD3CU1viSTA22oA29RgT sEyBfLgPj7Aa73cPIbCkKrpeHY3WiJI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QdlV69bG; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724772536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f0CuVBUU188TFdCdCElDdpiQeiLNGXtDVDEZ4g9j024=; b=s1xy1UzU/SaBeoDoRp0AffytDXisdjqvsUbgSzsqKJYPBucmj22ImONEBpuAgEnsnngUhH M+EG1xJh/VyXUVzZVKhhBhrYWFF4mCFLnKx+S0HYdv8BXHbSgLORcA2zdh+Tljrovd3bHx OXogbeHCfE7BpS9Csz3x42HQhfsJLWk= Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-53349d3071eso6888376e87.2 for ; Tue, 27 Aug 2024 08:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724772578; x=1725377378; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=f0CuVBUU188TFdCdCElDdpiQeiLNGXtDVDEZ4g9j024=; b=QdlV69bG3uL1jDo2xO8sI3vo4TIqECEoNNgMgM4v1E6jwOZoPmdj6IIOk73ts1MRXf bMIcou1igJjiDN9J+krr85CwJgbCqJYzy/Y2aMI+yRqStYZX/0NShd2ot5U29TdQbv/K cmP69CFPFWaZIfFZWP26cX35cQNAXn0OGMmAI/Xgxk6ob54QmIK2xw5/Q4QfLglr8EcK JT0Z7PMw4w9R7ZV/mw0KcoRzXe8ztMlivlDxdLR347iYCNz37qFMESNQdiyOYuAyhNmq y0vwTVzjFDnsQjJSDmUyvaCbaoRefFGhVpdrVDjWO24BSeEHv3oOm/eAfUb0RCmSmNQH pzrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724772578; x=1725377378; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0CuVBUU188TFdCdCElDdpiQeiLNGXtDVDEZ4g9j024=; b=DL7xgqy1XfrdUevJe3QsY3wyAW8YgvE8nUfyKnAFB/KyZXYIT2A5HJRRW77tU+DIxe vUqOoMuTVdUIRtCZH0EAfs/Hswc90myz0Twe+CZZYy8rQZYDCPACv9gBIBv8hULab+O/ f5hRxFuFldVO+j2RoIw4UuUjEXjisI/UZdsAz4FCtrOUMMpc+PWaSRcl9o88ADhnciIc MXeAZ7dZtBWTVzmR20/SVrny2X3D2zr/ogNbey2/xg6SmVM2IB5ffWOZBbMu8m6+bphg VY+3dkqb7B7CJi3Ay39vktKroZlivN6aEvMwYWQoK1l8yFTruV8Atlehy9v3Qf1qYLF5 QJNQ== X-Forwarded-Encrypted: i=1; AJvYcCX8qpyPjfy4P0i+t0L4jdnRN9I8QzBCog/E7sskmbn8Cdj/QRYQS3lBJ35mCvHzfggJBJo+WiKaZg==@kvack.org X-Gm-Message-State: AOJu0Yxfr1Y1Rb1GaxxcqgTu4t98UWvSXRvKhM5VOjKppKksEyW4QtXb VkZie6Bzav7wwParMPn5Oji4u5SaBEq+IMhL+SYvLGAwPVz0eicF X-Google-Smtp-Source: AGHT+IEIP68WxlCLDhys8pYQtHsPKoUPB4CYjjsRJozxWR4f23vWfH5GoC33jNXHu9c5dPW+mp3mkw== X-Received: by 2002:a05:6512:108b:b0:52e:768e:4d1f with SMTP id 2adb3069b0e04-534387858a6mr9416434e87.36.1724772577623; Tue, 27 Aug 2024 08:29:37 -0700 (PDT) Received: from pc636 (host-90-233-206-146.mobileonline.telia.com. [90.233.206.146]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5334ea5da51sm1826531e87.224.2024.08.27.08.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 08:29:37 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 27 Aug 2024 17:29:34 +0200 To: Michal Hocko Cc: Uladzislau Rezki , Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: aqecunrdxsw9ko4fshrnznycx4dr75he X-Rspamd-Queue-Id: 08162180026 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724772579-566114 X-HE-Meta: U2FsdGVkX1+XlQEGaeVMli6VjLl+H+pQS/IetlolDvd3/PnEQIut/fgGmseVCk7r+9abnOVppX+sXqy9RKY+6Z2YMrPa4sIhW05kMcONyL1g+v2bkBsQNChtzfdvuNA9RyRncJBbym5r3hcmqoBw9PPiDp89nNekr5pX7JMDhGgNPksN9eCsfB2yQ6knQ0Z6JUXq1rtIf05Ql88jtAcl/fYHmEbbpSa2a/RmyvRyf0RH4xSvxcCeWAtB8zwG8kNwSMCeOEzXmsPzr0AE3gpTwvBXUH7Mk5Kl7jc9rpy42vMgSArrPSHfASkyNfgO/Hzva3FxmWtjK/BcDw1V4qMuDX6J63p1UkXHH2ewpsVTbr47c2SqpICcDia81tsjjCw0jvcZ6vgV70Sl7S0FumrxToX9uF8m7TvN69IJ3uwI3A7O3oAtxGG8v6EXrtEXlfcqM7hHZsFyQvOEuK1esze6c82sgDeyCD5FmOV98bh6JuUsIo74fg/kB0YspoBjMlNLxiJTMKzNzrSnOXTfezU3hZg0R5uB6cnSamUhS14MT3s+W0kOW1HryzKHgohY5JEc/ZTKMiq8xg+NYSrXuOaFAgVxOJgS1IEpVRpdGB6sITnj/YEySOuTdJ3/kBDZH5eksLpKjuNbxgzcjDZEKdY07vkpjJdy8ZcF0bFpO4NQYmL3/i3X6Ogl7Y28P26LGHVD3wK4MODH09WYgx5uJNgYjn94l6xQnwLA+wTLFvMWLbT1CSznmWbUQvd+Qozn4FgTwJPKHPwrOp/dLN0t6JkbHKI5YsWpwPEIA2IgQtbW4DYKsT7vGJ+fg34CoYkMsJsb4ZkmpnQBrQJ/haVbXreIrO1G8uZqM7Z8RSTs5fRzW48G7dZ6F4xfh4V37SgVVXjQ9h9o5fqlauDdM3Rmyy+ysEk91l5vvrtYxq2XU7DNI5tBi2Gb5NnK24T8B6DoPnb/Tw/pHyywfqUQ5NoMPSq TFhGEUgn ss4I7BEWqJHj92ujrdwRWmFPxJkGEm5uDCxtomkIKsAuO0nqGcEyoPbAsfbBqP4IQsTZSMrDs5wBpc7DWz1tikqELh2wRATbdZ91eFdxON9hH+UC58U7zwnAP4pXxzq3dse/ltLtlb2ipil+i4CDq118bjV3LnWh7ZA7lt5k5F4XSVSAqYYCyLMmQTU9pcRgZgVpWnyHWDQjQRDMTpqHjSBGRKrcJsnum8Ze6hMNDgmgC8sYvu/31lZLed6nfmK+7D2NFydLaS6643mSLHoYr/y+oIBypMcjZf2SQczZolZgtdbFoVT+wpUnp5Wrp3/Z2QOMzQwszMK5sVRrTYRf15wSrrKQYgHZAU7J2rkNm/5nMmcZyZGTMQvv4GWvIgSZEUwQhYIcLlOlg9ZQrDtOq72uTAyEJnG0ZEkGdhL0id4UHeUsXAVWKKzx2DAhRsCGVIM0r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 03:37:38PM +0200, Michal Hocko wrote: > On Tue 27-08-24 14:47:30, Uladzislau Rezki wrote: > > On Tue, Aug 26, 2024 at 08:49:35AM +0200, Michal Hocko wrote: > [...] > > > > 2. High-order allocations. Do you think we should not care much about > > > > it when __GFP_NOFAIL is set? Same here, there is a fallback for order-0 > > > > if "high" fails, it is more likely NO_FAIL succeed for order-0. Thus > > > > keeping NOFAIL for high-order sounds like not a good approach to me. > > > > > > We should avoid high order allocations with GFP_NOFAIL at all cost. > > > > > What do you propose here? Fail such request? > > We shouldn't have any hard requirements for higher order allocations in the vmalloc > right? In other words we can always fallback to base pages. > We always drop NOFAIL for high-order, if it fails we fall-back to order-0. I got the feeling that you wanted just bail-out fully if high-order and NOFAIL. -- Uladzislau Rezki