From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C483C54731 for ; Tue, 27 Aug 2024 15:52:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 836656B0083; Tue, 27 Aug 2024 11:52:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E7516B0088; Tue, 27 Aug 2024 11:52:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6123A6B008A; Tue, 27 Aug 2024 11:52:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 43CF96B0083 for ; Tue, 27 Aug 2024 11:52:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CCD5141A74 for ; Tue, 27 Aug 2024 15:52:28 +0000 (UTC) X-FDA: 82498467576.15.8D5817F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 41544140004 for ; Tue, 27 Aug 2024 15:52:27 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pJjeZGdR; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724773831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GWHE7tOwocWsn8tOtjtNDaroe1R2gQ10VN2+EPpdp4I=; b=i64zri5P4tgV5r4sRfn3r1FppgNenffmLiI1UfC3lqO5iHp6Wrk4/8uPzoTSK7DhZJLxH0 gx2cC0cC3J9fGbIVhBVjJZEEJEdAYmPBpbRjam9twBa/phX7tu6gKKrQvjLJlT9OuapwKo pblc07/WUjZJZgj9QwN+wkYdc+Qj0s4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pJjeZGdR; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724773831; a=rsa-sha256; cv=none; b=KKkjtRPy7InSijB6rDJX01T1gYpygJG3oVD40wRnoC8esWtsxRJHAA5ttk21rKUo/C+Kqr XvabjbpQexRcG20LdWluFSxaEOrwj9f4bxjWIZbgh3KL/TpXD8nhE751RE5HlCutW8RJ1u U4N3creJ9gmKl/x9x79/2HQbAXs3o/Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1EE20A41FD3; Tue, 27 Aug 2024 15:52:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0C93C4DE0D; Tue, 27 Aug 2024 15:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724773408; bh=gLN6XrXPe8lnOYBY+qE6Br7q9z15uQyViI2cYvrjDUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pJjeZGdRlRZciwiSds7ncOoFJeP+wPAbVUVeY1LlTa56La6oD/XycPb3ju2I/Si6N bNsP9pfRPVziKGgn/Q7CZW62Bt7rl9iXHC+NkqAHxIdvlozlUPOn7DKQtQl24SAAKo NVAJkyrxO3xLQShBOmpHzZcPcSpDnuVLQLFIjp6TCSAVJcQE/Q6oni4wO6fU4ZsrHD 4ovVIvkGw6loTWaFlHze4az9iCCc+TXdBuzKzGsuhZ4ATm4q785T8iPGoGLrAdyrZK 3tUYk2k2P5uZy+/qiIPItAj2gx6xlt89fXh5S1kblIuw6KS4FNa+7dzFK9H80hz+VW wYQnWN9qfNMIA== Date: Tue, 27 Aug 2024 18:40:35 +0300 From: Mike Rapoport To: Steven Rostedt Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 5/8] ftrace: Add swap_func to ftrace_process_locs() Message-ID: References: <20240826065532.2618273-1-rppt@kernel.org> <20240826065532.2618273-6-rppt@kernel.org> <20240826132909.306b08fc@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826132909.306b08fc@gandalf.local.home> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 41544140004 X-Stat-Signature: dcd447mpianz9gmbfds8cdhw64u33gxd X-Rspam-User: X-HE-Tag: 1724773947-331503 X-HE-Meta: U2FsdGVkX185UpgiTHEq2urJrGqECOo+d3cvGhP5dy6Q/mVC0KaiWQ9BdLOxckrthb4u+UsZUWl/oSUy7h7U/eOsiblAAke/6QQuDzDMYWLPb1KU6tN9GQfYmu6dAHUNFBGOQbl45Y5GjLrOtUdV3l/eC3b8qrd4uAgwTZIrybXl4lYgTtChVDhKy40mGoOSsSM256OvUfkIUwQ9kKdHFQh+jRhgRwKHrQuhzxRvaFWAjVBVVB4NE+inssMZLW48Ezxa33IAt83LbMJQC6sPAiOlD+C0tBMOKpIBMoiVz8TG/3CxtanZwFM+b20hpDL0To0n0bCMwvHMjLMfW4WRn+MFgJA5BdYwe5jvFX7FFtPYJi9aFf7jfGhkyQAhTpuzTkYUbNnuOOO2akwAmPQjyPc6YxO9FWCkDbWGAzb/FUhN6mVgqcYEUtdS7WvHcGC8FUHHvsuuohq+RxU3fYCKzsPaAMehWISM6RZWK85vgHNSLRYNpGjRSkcEcn3UaTdxXjF+/FzgQQYmsCzocM2gDeeS/AQxr9yAnreuXgR6T9BEdpD/qbEwHn3Q9KfQtd3xEI1HeJ0neV1sXtPPs5AfLf/FwefMjrq6AW6a7Na3fdHPgKYy26rriLLLXIEff2RpoIJlsGweVFAknwLY2L9ks42U/iBTgfhZH7t19YaoS6ZGD7RJVrYLVSniWi6l8+bunC597Pa5qBES4nC/xf5qR+hN+TZB1BT0YETzl+RWzjsFLA3rFpEmyNR2jqBIIeRcn0gXMOTXradpzEni4L1ow/mwREQonj1xzmWlGQiQaEPNWp4r8P9fHync8433fIgomAYsf/qRKSjVqxNoz7bXViBF1XL60cL0M7jJWp5YFM+hV07Wylh3BNzFIaS6ELinWsc2A95YWxmgDfEeMe3w+RuI3rKUA3ofgnXrYiGGptzMP8RCA+zfPZDjhBrmRg33pNxGazkh8MTY5lWQzYf qhEHO/eQ AFNF6NIqlhOVj1DK7HHlxOiB4KV2Pz3kYvp1w09ArTqE3B/0Nh37VlZDeza+Aggu11ILzUt+m8/xPApXwouvpXd202Yk9UQifaJDN8JjFr+xXYGRVRfu/8mUp/FILRp8uVGtBA5BaRgEFIPXnccED9+M9yeJQEL7MTam4PrGhUh3+B59GYkmOTozX6X+UCbdTOM7o8E7mEOwnumL1max5gbchLZRsfZ6K7ElkOZ61+i9SICtJRmclTadsqaat2gVK3R7AF/Ja0a70AZs0UiTnNkUKqlZkGkyIfoz4luIFrxWSS1DaRVU5c0g4ql8ilmTi+GQkqp7nHdJ2Or28LmiVTxys2tFxa4bV0/xVkkJA4T9wqx4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 01:29:09PM -0400, Steven Rostedt wrote: > On Mon, 26 Aug 2024 09:55:29 +0300 > Mike Rapoport wrote: > > > From: Song Liu > > > > ftrace_process_locs sorts module mcount, which is inside RO memory. Add a > > ftrace_swap_func so that archs can use RO-memory-poke function to do the > > sorting. > > Can you add the above as a comment above the ftrace_swap_func() function? Sure. > Thanks, > > -- Steve > > > > > Signed-off-by: Song Liu > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > include/linux/ftrace.h | 2 ++ > > kernel/trace/ftrace.c | 13 ++++++++++++- > > 2 files changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index fd5e84d0ec47..b794dcb7cae8 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -1188,4 +1188,6 @@ unsigned long arch_syscall_addr(int nr); > > > > #endif /* CONFIG_FTRACE_SYSCALLS */ > > > > +void ftrace_swap_func(void *a, void *b, int n); > > + > > #endif /* _LINUX_FTRACE_H */ > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index 4c28dd177ca6..9829979f3a46 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -6989,6 +6989,17 @@ static void test_is_sorted(unsigned long *start, > > unsigned long count) } > > #endif > > > > +void __weak ftrace_swap_func(void *a, void *b, int n) > > +{ > > + unsigned long t; > > + > > + WARN_ON_ONCE(n != sizeof(t)); > > + > > + t = *((unsigned long *)a); > > + *(unsigned long *)a = *(unsigned long *)b; > > + *(unsigned long *)b = t; > > +} > > + > > static int ftrace_process_locs(struct module *mod, > > unsigned long *start, > > unsigned long *end) > > @@ -7016,7 +7027,7 @@ static int ftrace_process_locs(struct module *mod, > > */ > > if (!IS_ENABLED(CONFIG_BUILDTIME_MCOUNT_SORT) || mod) { > > sort(start, count, sizeof(*start), > > - ftrace_cmp_ips, NULL); > > + ftrace_cmp_ips, ftrace_swap_func); > > } else { > > test_is_sorted(start, count); > > } > -- Sincerely yours, Mike.