From: Cyril Hrubis <chrubis@suse.cz>
To: David Hildenbrand <david@redhat.com>
Cc: kernel test robot <oliver.sang@intel.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Ryan Roberts <ryan.roberts@arm.com>,
lkp@intel.com, Vasily Gorbik <gor@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Sven Schnelle <svens@linux.ibm.com>, Zi Yan <ziy@nvidia.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
oe-lkp@lists.linux.dev, Andrew Morton <akpm@linux-foundation.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
ltp@lists.linux.it, Janosch Frank <frankja@linux.ibm.com>
Subject: Re: [LTP] [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail
Date: Wed, 28 Aug 2024 14:23:58 +0200 [thread overview]
Message-ID: <Zs8W3nQszwhbSiT9@yuki.lan> (raw)
In-Reply-To: <c6fb5f16-59bb-47a5-a2dd-3c4207d73614@redhat.com>
Hi!
> I am not yet sure if we should simply allow either -EFAULT or -ENOENT for
> the "nothing mapped" case in the check (below).
>
> Alternatively, I agree, wee need to have this in the kernel so we can
> check for versions.
>
> What would be your preference?
If we are going to stick to ENOENT for page that wasn't faulted in the
kernel from now on we should stick to it in the test as well.
Also I think there is a third case that we do not cover either, what
happens when we pass an address that is not mapped at all, e.g. NULL? Do
we get EFAULT as well?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2024-08-28 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 4:44 [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail kernel test robot
2024-08-21 8:44 ` David Hildenbrand
2024-08-21 9:15 ` David Hildenbrand
2024-08-28 10:37 ` [LTP] " Cyril Hrubis
2024-08-28 10:51 ` David Hildenbrand
2024-08-28 12:23 ` Cyril Hrubis [this message]
2024-08-28 12:28 ` David Hildenbrand
2024-08-28 12:30 ` Cyril Hrubis
2024-08-29 13:49 ` David Hildenbrand
2024-08-29 14:31 ` Cyril Hrubis
2024-08-29 14:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs8W3nQszwhbSiT9@yuki.lan \
--to=chrubis@suse.cz \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=ltp@lists.linux.it \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=ryan.roberts@arm.com \
--cc=svens@linux.ibm.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).