From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D624C54FAA for ; Wed, 28 Aug 2024 13:00:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1635B6B0093; Wed, 28 Aug 2024 09:00:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 114146B0095; Wed, 28 Aug 2024 09:00:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 002226B0096; Wed, 28 Aug 2024 09:00:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6C746B0093 for ; Wed, 28 Aug 2024 09:00:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8CBC8AB913 for ; Wed, 28 Aug 2024 13:00:00 +0000 (UTC) X-FDA: 82501661760.06.833AD45 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf09.hostedemail.com (Postfix) with ESMTP id 38603140002 for ; Wed, 28 Aug 2024 12:59:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=softfail (imf09.hostedemail.com: 192.198.163.19 is neither permitted nor denied by domain of andy@kernel.org) smtp.mailfrom=andy@kernel.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724849954; a=rsa-sha256; cv=none; b=iqJkeTWypBbvD5fvkm9z3dbJBnkOKeeBOgtCAM3oDMPZ33Tq2KzxH1TFsJNXKANOw1eQCy CFDXnXohgM/b937Cq5yZh5pAHAs2kXNG+DKHJO+UfH0m2Ywa9J6EMx9YlP4LLODXzCGE1g v8HsAVdZEG1NEzB8jIfGfB1a7Kt/Z+w= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=softfail (imf09.hostedemail.com: 192.198.163.19 is neither permitted nor denied by domain of andy@kernel.org) smtp.mailfrom=andy@kernel.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724849954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8lea4YRscS+VYXaUL0LJyE/M8dyUzTQi2yXNwgCQDhc=; b=jhogvtGoWj+yhLJVkmbluCm9s3xEYv+G++sKB6p/c04JuKUsASOc4rLvLjNF/3OiFcf2Nl G093KTPX+Q0eg/ZX0INLaZxvxAj/fE9/eYo4FvAM/+JzhtoMtDINg3ZWwxZVF94LX5G5Ij kkEG1acuuQ5g96ZRXLmRyl8z4vi6WuI= X-CSE-ConnectionGUID: a+2VNiv4Rbyo78N1/KR6mw== X-CSE-MsgGUID: Ev2iAvEoTEyOnorEWh9NUg== X-IronPort-AV: E=McAfee;i="6700,10204,11178"; a="22958481" X-IronPort-AV: E=Sophos;i="6.10,182,1719903600"; d="scan'208";a="22958481" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 05:59:45 -0700 X-CSE-ConnectionGUID: cOay8UndTUuSV7nd1+KHCQ== X-CSE-MsgGUID: lLcf8IIZRiSMHnXNRER7JA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,182,1719903600"; d="scan'208";a="68104546" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 05:59:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sjIGx-00000002eHy-1NNZ; Wed, 28 Aug 2024 15:59:39 +0300 Date: Wed, 28 Aug 2024 15:59:38 +0300 From: Andy Shevchenko To: Andrew Morton Cc: Hongbo Li , kees@kernel.org, trondmy@kernel.org, anna@kernel.org, gregkh@linuxfoundation.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper Message-ID: References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-2-lihongbo22@huawei.com> <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 38603140002 X-Stat-Signature: pkkfqpndzjehnprrkw6g9wb5umaga48i X-Rspam-User: X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1724849997-882843 X-HE-Meta: U2FsdGVkX19T2W0KhcrJuV9a+XhUzxKAW8HAPeDBmMBTpCWMUyXkW0Z/F7j7AsYj+JkeTvXcCHSikFUlQPZPxOkqtDzlVPFrEn1GwG9vnFNj1LQxRKZDAg/pp6NGenqrkoASnk+8kZ8Y/xDCuDz8cp8tgCbz6oeTYLRasJG6BWLLLPSc10sZdU7KXEP1gCqHYMrL+ouum5Zh7DdzjW1VoIUo/eJU/lhzD4gXQY9GHj15YtqhREnzPTW6LUiN3oHNbFm4xkdfKR3TFwJeq7aDEcrKWBFyJfsBOrD1WEgJHRhsk9uyVmkuHZPD3Q2zIsCyXZZxBb7C6Tkl5L9yTxsL2S2ephej43veZxFu+/xa1I+9u70tdWwnHXOx6tXtvAJk+Dd0tP05uL0Ynb3Xjyq7lf8EJvRVA4y6RkwtpCM6t6uj4iiNbrUswPC/q2bWuDgahDauIdhImx1qc9k3aDCyGvPuZ5FZMnb3ZOShEXMyE/QDehg2PJrUaYayGUIxR39oAd3T5y4bmHmamh4fMKOHcFWrK/SrCezllHST99f0dzE/GzexMTEauUo9diyEDhJdAlCRE+k0Q4IPd28ArG982NoWnOyhQmX6sdf6bonc2cizDCd1+WzIF3P+gU9+UBI3+vI3cZQp4hkNriuv8ENz8FHzGanglUegEyJYZ8nfSpD8s+cJkoYIQJuHCYZMkV5PTPvng9cxJEQG+1ccHuzlZHH81S1VKswf4jP6HFBxs0WmdMLSHhO7/yKiVrsIP5Mv1WZi6MXN4YrDbFMG/A5F+37WalPBhdxIok3BVEepJWKyME65+XfvqGr7Bk5NcXhiuVz+LXityjzHBTDvFJseCGupjk24qytBAx73ED1mxVVSLixuh9wco+QRQKzbudlJhdmrnHJfGJEqEDAnfRniiwPDOqTeS3EkNv7Up7dIwZMrPG81ON2hOmOuL3vPFgARuUTpWuImlVFJmFQq2zs Pm5NXGQG dLvWneXW0k0KW3lk12TCPxtzuwdPlx4o1fjbwMoFeDK3iP5hh8okoBDCw4bAp6YWiab7dWnERflYcuxpW7LldH8NvpNYSMXFQVvZg2xlFnHi2mfb4xhECfpLMct0mx5b2g54L3kkd0Jcar2skMzIPmPkTOHYKQDWLf1FOOTPNCumo9jZ0dia+yx1O/xf7cwtF62Ab2cU2lBym2yrgO98mAwneRcqzw6Wg+THRHBrlsIxY6PGg5e3VjesQNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 04:42:18PM -0700, Andrew Morton wrote: > On Tue, 27 Aug 2024 10:45:15 +0800 Hongbo Li wrote: ... > > +#define str_false_true(v) str_true_false(!(v)) > This might result in copies of the strings "true" and "false" being > generated for every .c file which uses this function, resulting in > unnecessary bloat. > > It's possible that the compiler/linker can eliminate this duplication. > If not, I suggest that every function in string_choices.h be uninlined. >From this perspective this patch doesn't change anything. The function is inline and in the same compilation module the linker will optimise away the duplicates (note as well that this is kinda new feature, some relatively old GCC might not have this feature, but I'm not an expert in the area). -- With Best Regards, Andy Shevchenko