From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91708C5320E for ; Mon, 19 Aug 2024 10:10:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 074AE6B007B; Mon, 19 Aug 2024 06:10:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 022E96B0085; Mon, 19 Aug 2024 06:10:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2CDD6B0088; Mon, 19 Aug 2024 06:10:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C36D86B007B for ; Mon, 19 Aug 2024 06:10:15 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6079EA116D for ; Mon, 19 Aug 2024 10:10:15 +0000 (UTC) X-FDA: 82468574790.02.70F355C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 0F33E1A0020 for ; Mon, 19 Aug 2024 10:10:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=t4sKtkWJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724062155; a=rsa-sha256; cv=none; b=1un71VIlWEHCTxF40kf532v3MUEP5l8VTBs52Dgkqtg2ka9wV0Qa59/3Tdo+fReQPp3AaF 3I8423a8rJBBrOq9tD2zBEVCqaUE3cUXMtqeJEteDvTR4Bo6fhn8cC5qtgR8+8djFdwewV KdqbLxPAJWBMBqgfn91Vi6YfB1e/jm4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=t4sKtkWJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724062155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lm+KIT0gGEXFvtLHrDIAx/CyMsl0W8vH5ldUyBx+nJI=; b=NFtROOtsdPl3YHK1pDD1qe1u7K0KxjqsMudCer5qv7GApkhruNTdlUCVAJ7KyzlsatdAMC jFtrFtivBTA2EU2y9iA4mU7pt7zK+glLzkYuRvVMsPaR9BPGsOwJzCobYUzBtEkrkqvMdZ ThKUU5uHUQv1FbuSRpJYuWa25exqTA0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 963D8CE0A08; Mon, 19 Aug 2024 10:10:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2DADC4AF0C; Mon, 19 Aug 2024 10:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724062207; bh=MqrpAk0V4swle/LX6Ozj2eaNefXVewFamWFL4cNI//U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t4sKtkWJVVCgI2rS4IoPvGbNm65zpijEGUb87xPR92lTxJWadFrmYGp17FlT5BmMw Raoy/HAEGKk6MiWKgewOFVKgiJ2Cks7Lbo4X3E6B75qiQamcZFSjPoplIQUM3UnUkp H1Ws0m0vTihHLcXVVp81Y9rj+9UfHfnxT50hqT318+xGVFZ9VlfVqT0uh6uN41KJ7y oMjgxN2lcg1W3WjJkP6R1gvbtB4nOvxO7hg10DYA4/00n/I8q8wKtdd/Du9hjO7/Ma Px3EMt9mQEHUvD19cbuoHmbg2nwnntQpkhG88CuF/Z1kGVqVLcdkuirtDdavsBQItj LvZ3bGVz3R7KQ== Date: Mon, 19 Aug 2024 13:09:52 +0300 From: Mike Rapoport To: Elliot Berman Cc: Andrew Morton , Paolo Bonzini , Sean Christopherson , Fuad Tabba , David Hildenbrand , Patrick Roy , qperret@google.com, Ackerley Tng , linux-coco@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Subject: Re: [PATCH RFC 3/4] mm: guest_memfd: Add option to remove guest private memory from direct map Message-ID: References: <20240805-guest-memfd-lib-v1-0-e5a29a4ff5d7@quicinc.com> <20240805-guest-memfd-lib-v1-3-e5a29a4ff5d7@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240805-guest-memfd-lib-v1-3-e5a29a4ff5d7@quicinc.com> X-Rspamd-Queue-Id: 0F33E1A0020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6yaw7hizzbkfuxcm1m91jcpyen53hn84 X-HE-Tag: 1724062211-679622 X-HE-Meta: U2FsdGVkX18Wpa8Z1TNTgmO0xdOXKW86Pn+v6rAkRKU7+H4aHjRgcbtw3YmdKAzM9IrHX89o1+4njW3dFvRq6MH2wuh5F6jJD8mt4s6X0DBmJFOeu6y6/ULGTXbDUa0PV9jIcgMn4wa0n8YBROBQsl/e0ERneb4MBWsMBsv/ePKCYLYvcKLfJFYbsCTa4rh+bgvxUjwpjMdkYdpGorlQPfM/Af+Oge8Kfqybp2V551vTdfi+HAOEfHdAsMne2kMcXdD0akUvCO/alpUl+afILouk8KK7xuJk8F5hNLecARCFWXv9H9YKF7XyRfNwxwkZTE0mdWrJTOapZ5RNe7HGuI7X/Iu/I+oL06M4XLdtjXoLs9llaAO2/pnfKZSpoih8Kthw+RLo/plR0QfCt56U2CXytDd4psLIBPBhk4fsIGviGTzLemDSZ70enk/COJNFF2Q3hPJq4cJ2D0ru4RPOfS5DBSfW4ge3Q5AWPA6pNM4go6YoQwRRidkTYstIpyfCkwLdnD1BjysCqqj8vNnLoKPfikm3uQpOke9/JrHaVsiIzMWhcYbdU4Uaxoqy2txjaY1vu5hvGcD2pCuvBy4ybM5hOgKvWQbGoigp0lktQwE/6pelhImYIHdTk+cr53DY3ihmhrjcRZnk6Wycwq5rhE8IQRC1OhKR+GTby8PssAiUiLucdhpThTViGRes+hKEuowvlzopQeq2FvWC9aZMNYnfGsiuUS/xg4pdKqyLgAeCmxQeCL7iYNp89YHrvzkZ9oDMBj7JEZfImfBbYT170HLvGkmCTvL+ddpc87yS0QYcDWeE2pdpqGk0Fe4wVDAtwdb0Njh7ncj1rduB23xO1CpZmN082qaraa4KLsvEkheboONrSwaZWh6zls+XfoLHqgp/XeBSnjXg81iS6bRK3QkH+IbgrxwLfeKggb3BQ2HEszGF0aHLvbss6VFOWPzqVdbG7XWqKVgDqz8na4x C1ZVwktu CT4FmEXb5h00i7f0Bz8mNap4+0/EYM6RM5rwW9dT73ZOLEVNVsgYH5uMsJWfgaOoVTdGFt0vUUWvdkZAf0OK0Iyd2jsndb/XSFbkI5ANj61EFRYaUFVLS7V/aC3nslbS2jl9u9UT/k+6lVz1dYULSPD+sC8XiR+GUpv457iDlrMILP+9MCCIV5a9HjqO208bYjhc4bK8vilA+YsA52jtlgAOjmbeVQxi+9jbH1Lsn/pVSkcNWjH62LodIzcPeDjuBGPFvjaZtzIKWHLNbmtwQUfqmWdqK8UrqzJKnSLI9OoCXoHg6GNlqKN3ijaqW75PtkI5D7r0bvVtr5iqDlM37x8wacia1SxvWWUe6W0LUT9DIrlLooSkFulOak6+wkiHQzzOwz244M8FZ5JF4tpGsuQnKfDqXfIFa5r+lDBdpW2zQkk4zEGfOVxihCSkhTsFsQrI6cqoXV5MIVmIZbrvWIlK4Cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 05, 2024 at 11:34:49AM -0700, Elliot Berman wrote: > This patch was reworked from Patrick's patch: > https://lore.kernel.org/all/20240709132041.3625501-6-roypat@amazon.co.uk/ > > While guest_memfd is not available to be mapped by userspace, it is > still accessible through the kernel's direct map. This means that in > scenarios where guest-private memory is not hardware protected, it can > be speculatively read and its contents potentially leaked through > hardware side-channels. Removing guest-private memory from the direct > map, thus mitigates a large class of speculative execution issues > [1, Table 1]. > > Direct map removal do not reuse the `.prepare` machinery, since > `prepare` can be called multiple time, and it is the responsibility of > the preparation routine to not "prepare" the same folio twice [2]. Thus, > instead explicitly check if `filemap_grab_folio` allocated a new folio, > and remove the returned folio from the direct map only if this was the > case. > > The patch uses release_folio instead of free_folio to reinsert pages > back into the direct map as by the time free_folio is called, > folio->mapping can already be NULL. This means that a call to > folio_inode inside free_folio might deference a NULL pointer, leaving no > way to access the inode which stores the flags that allow determining > whether the page was removed from the direct map in the first place. > > [1]: https://download.vusec.net/papers/quarantine_raid23.pdf > > Cc: Patrick Roy > Signed-off-by: Elliot Berman > --- > include/linux/guest_memfd.h | 8 ++++++ > mm/guest_memfd.c | 65 ++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 72 insertions(+), 1 deletion(-) > > diff --git a/include/linux/guest_memfd.h b/include/linux/guest_memfd.h > index be56d9d53067..f9e4a27aed67 100644 > --- a/include/linux/guest_memfd.h > +++ b/include/linux/guest_memfd.h > @@ -25,6 +25,14 @@ struct guest_memfd_operations { > int (*release)(struct inode *inode); > }; > > +/** > + * @GUEST_MEMFD_FLAG_NO_DIRECT_MAP: When making folios inaccessible by host, also > + * remove them from the kernel's direct map. > + */ > +enum { please name this enum, otherwise kernel-doc wont' be happy > + GUEST_MEMFD_FLAG_NO_DIRECT_MAP = BIT(0), > +}; > + > /** > * @GUEST_MEMFD_GRAB_UPTODATE: Ensure pages are zeroed/up to date. > * If trusted hyp will do it, can ommit this flag > diff --git a/mm/guest_memfd.c b/mm/guest_memfd.c > index 580138b0f9d4..e9d8cab72b28 100644 > --- a/mm/guest_memfd.c > +++ b/mm/guest_memfd.c > @@ -7,9 +7,55 @@ > #include > #include > #include > +#include > + > +static inline int guest_memfd_folio_private(struct folio *folio) > +{ > + unsigned long nr_pages = folio_nr_pages(folio); > + unsigned long i; > + int r; > + > + for (i = 0; i < nr_pages; i++) { > + struct page *page = folio_page(folio, i); > + > + r = set_direct_map_invalid_noflush(page); > + if (r < 0) > + goto out_remap; > + } > + > + folio_set_private(folio); > + return 0; > +out_remap: > + for (; i > 0; i--) { > + struct page *page = folio_page(folio, i - 1); > + > + BUG_ON(set_direct_map_default_noflush(page)); > + } > + return r; > +} > + > +static inline void guest_memfd_folio_clear_private(struct folio *folio) > +{ > + unsigned long start = (unsigned long)folio_address(folio); > + unsigned long nr = folio_nr_pages(folio); > + unsigned long i; > + > + if (!folio_test_private(folio)) > + return; > + > + for (i = 0; i < nr; i++) { > + struct page *page = folio_page(folio, i); > + > + BUG_ON(set_direct_map_default_noflush(page)); > + } > + flush_tlb_kernel_range(start, start + folio_size(folio)); I think that TLB flush should come after removing pages from the direct map rather than after adding them back. > + > + folio_clear_private(folio); > +} > > struct folio *guest_memfd_grab_folio(struct file *file, pgoff_t index, u32 flags) > { > + unsigned long gmem_flags = (unsigned long)file->private_data; > struct inode *inode = file_inode(file); > struct guest_memfd_operations *ops = inode->i_private; > struct folio *folio; -- Sincerely yours, Mike.