From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 0/5] mm: finish three more folio conversion
Date: Mon, 19 Aug 2024 14:20:29 +0100 [thread overview]
Message-ID: <ZsNGnRTpKPbXthaY@casper.infradead.org> (raw)
In-Reply-To: <4ee78f2b-05e0-4f6a-99fd-73e6571e91d7@huawei.com>
On Mon, Aug 19, 2024 at 07:13:18PM +0800, Kefeng Wang wrote:
> On 2024/8/19 17:59, David Hildenbrand wrote:
> > On 18.08.24 22:33, Matthew Wilcox wrote:
> > > On Sat, Aug 17, 2024 at 05:51:17PM +0800, Kefeng Wang wrote:
> > > > Convert to use folios then remove find_subpage(), thp_nr_pages()
> > > > and PageTransHuge().
> > >
> > > This patch series is premature. None of these APIs are particularly
> > > advantageous to remove (they're inline functions, so cost nothing unless
> > > used).
> > I do enjoy seeing the removal of thp_nr_pages(), though :)
> >
>
> The thp_nr_pages() and PageTransHuge() removing are found when improve
> memory hotplug[1], also find_subpage() has issue[2], this is where patches
> come from, since there are only few callers, I think we can
> cleanup it earlier?
No, leave them alone until we get rid of readahead_batch() and friends.
next prev parent reply other threads:[~2024-08-19 13:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 9:51 [PATCH 0/5] mm: finish three more folio conversion Kefeng Wang
2024-08-17 9:51 ` [PATCH 1/5] mm: remove find_subpage() Kefeng Wang
2024-08-19 11:02 ` Kefeng Wang
2024-08-19 13:27 ` David Hildenbrand
2024-08-20 8:22 ` Kefeng Wang
2024-08-20 8:23 ` David Hildenbrand
2024-08-20 8:34 ` Kefeng Wang
2024-08-17 9:51 ` [PATCH 2/5] pagemap: use a folio in __readahead_batch() Kefeng Wang
2024-08-17 9:51 ` [PATCH 3/5] mm: remove thp_nr_pages() Kefeng Wang
2024-08-17 9:51 ` [PATCH 4/5] mm: khugepaged: pass a folio for set_huge_pmd() Kefeng Wang
2024-08-17 9:51 ` [PATCH 5/5] mm: remove PageTransHuge() Kefeng Wang
2024-08-18 20:33 ` [PATCH 0/5] mm: finish three more folio conversion Matthew Wilcox
2024-08-19 9:59 ` David Hildenbrand
2024-08-19 11:13 ` Kefeng Wang
2024-08-19 13:20 ` Matthew Wilcox [this message]
2024-08-20 8:41 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsNGnRTpKPbXthaY@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).