From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D025C5320E for ; Mon, 19 Aug 2024 13:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71B6F6B008A; Mon, 19 Aug 2024 09:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CB316B008C; Mon, 19 Aug 2024 09:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BA026B0092; Mon, 19 Aug 2024 09:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3EFBA6B008A for ; Mon, 19 Aug 2024 09:20:40 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 82A5981278 for ; Mon, 19 Aug 2024 13:20:39 +0000 (UTC) X-FDA: 82469054598.18.6005A5D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 0A68AA002B for ; Mon, 19 Aug 2024 13:20:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LmibKMhX; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724073580; a=rsa-sha256; cv=none; b=NZz6ZMZpJAXAdNU1JAZ2fNTKtoHKsf3ZYgOOQbIpqw3FD6poQD4LRkFMGQVFyWEB0a3RXU yBddncPCspKQAb7q7yw0a+IVGU91m5PZrdiMrlL0Tg0w0q/c66xGIthxbk7LoRC0+MTuEi zpLh7dfCCNSK6QnSh63XMEgwcbjZGt8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LmibKMhX; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724073580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oZnxe+6lqf3xc7gN755nYL8FPTDHwjHGpkzlOJOXqAg=; b=LrWDFfhs4b1NousXcKLe7xP2KFAuVLi+baYBeY+nYAln+wddJ+diiIiZZwsUS/zU5+Xysr 0ROY83Go+Y60TpA1hlAFz/eZNxWU0sDYxovUQFY2w8Tc43Z/6yPafO/YCpnJLcuZ8V2f+w 9kIUZhvpdg4PwJZGmEUBtpughqufJvo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=oZnxe+6lqf3xc7gN755nYL8FPTDHwjHGpkzlOJOXqAg=; b=LmibKMhXOeIcb9P7eW8KAoRz1J B2U/BLbh1pEImXNbDT0YBfpNNWT28B+5Og8RFttYpDTdptNekjqdYQFi4MtkaaciwbdQm75pn0CjZ Nb1mq4zIgpy0PFY7zGZ+9kB0LwUJzLDv0sOhqYKGLEuiB2Aph4ufCpjSbHXOKm7iUgAwuWgiHPVhM OFo6Boc8De2qJlmCJUutIHlxbIU90DnfzXFKwjyTU/7JA27V0ToehJZCUFWhpNnYpOeyn9qzsKZ0Q NjygxWp7AkUF/gZUjvHwKYEjYOrLB8jL5QRY0lgMaHAVFFhoc+5JdajGpmqvCqFT9DrgYRsf5QhMj oZWLIdxQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg2JB-00000006lgs-3IlI; Mon, 19 Aug 2024 13:20:29 +0000 Date: Mon, 19 Aug 2024 14:20:29 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: David Hildenbrand , Andrew Morton , Alexander Viro , Sidhartha Kumar , linux-mm@kvack.org Subject: Re: [PATCH 0/5] mm: finish three more folio conversion Message-ID: References: <20240817095122.2460977-1-wangkefeng.wang@huawei.com> <4ee78f2b-05e0-4f6a-99fd-73e6571e91d7@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4ee78f2b-05e0-4f6a-99fd-73e6571e91d7@huawei.com> X-Rspamd-Queue-Id: 0A68AA002B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 34pw6ef1je1pj4w8xxct84pscw6ji8si X-HE-Tag: 1724073636-781040 X-HE-Meta: U2FsdGVkX1+aDUwHPJylW7SKDEUJcJGX4wBZlh8yL0JMWUGeGmENGUTjLin1Ig6xWA6/BaMY+8k21onGsm7yrVnq9lASdEvG4/W34SYO2VBZMgv+8uYSYUoV7Of+4xbFsTsoBnKE1udmYtPMVywwTL3CAVb6XbqyM8GkQzploFVL6BarZkIww5zYEq280RcmCfAzdRQ2GgChbZZ/pOWPdB+KlYymVJsat78A3p1rkraB57LDl6SuZjujj6QWC5Ci8FxRsZYAzOyoDCU6JEDPVx/idUsFTEzbOBROjwScbKvET+y3Pnl+UvqUDuQ4axRQUWEiWkttyRFKWLD+oAQADWgNwds/SqyhPMVQ4+dxvoAkEd2Ru90TeG6VE4MpMgw1nmjNz/eVrx2eosnvEYtJl8ZLFmwKtb1oYvTgssDEbLCacwzV3qZ3fniD8c77MrhX0v7tfnaxfSaOspZn9Ecng4aLL9ErdRoWM6vm1qRQZzpAgdshCdvzQdTJSLoQfiGsAkIf9Tz7mscZSIvW5ZM22q440TbrF5X1FUSfij/lGKSVjaE7kI/4PD39tOgyIm/1fTlwYWfea3clU/xehwy5DWxVDVj03pV67PQ9nwNCLdD3v01u+PclDWw8X27Rlv3hrxXc+pQ+YD8NeUy2fPfpX+LulP1nXqjxXM9/tM4/3I/fsAH2Q033Mlir6x1cEaQt0tG2HqFrzCt+y52U/LF7fwMh2q0LtDKR81CAuDbbPxkg6d+YPQF6vFHXOhCtlb8KuPQjfNV1WKyxDsOqRjlAXbri8j7jeJytGu22QoVo62uAFFOewVSRo4mgjz+krVThalFMTRaBqYxF3e4YHW2M95YzGrRkXw7ZhJR74dyBJppW2PtMYzfRvESc2BYPc31Oh3cRbi73ejGdg8Gk4wA5xy/BIKeoYkXPFbBYAjsBDcT3MRqkuQi5QH1vqjdWtsx3/6ZakOLgADZF0JqqA15 eC8a65pU Cyni/w+mP//BIWTocLxLijE+euy6GuMGovgLUrYmRrCwo6LStj2EsnzdLy2K9yUmVKR6rDBMONNB51ofC1tKR2a2Ut2cqWIh5vKyeHOdWAqcBvCIgp+YHSQMO5zEoSrUSmKpItWig5ftQzjvucIlXJevXEW0xhUssy1Qklzmq3txXj94/Htrxc5vjXHbtOCusWsmHBVkyV8305AXxyiiD2Ueeefp+xbC9DOMr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 07:13:18PM +0800, Kefeng Wang wrote: > On 2024/8/19 17:59, David Hildenbrand wrote: > > On 18.08.24 22:33, Matthew Wilcox wrote: > > > On Sat, Aug 17, 2024 at 05:51:17PM +0800, Kefeng Wang wrote: > > > > Convert to use folios then remove find_subpage(), thp_nr_pages() > > > > and PageTransHuge(). > > > > > > This patch series is premature.  None of these APIs are particularly > > > advantageous to remove (they're inline functions, so cost nothing unless > > > used). > > I do enjoy seeing the removal of thp_nr_pages(), though :) > > > > The thp_nr_pages() and PageTransHuge() removing are found when improve > memory hotplug[1], also find_subpage() has issue[2], this is where patches > come from, since there are only few callers, I think we can > cleanup it earlier? No, leave them alone until we get rid of readahead_batch() and friends.