From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76521C3DA4A for ; Mon, 19 Aug 2024 13:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07C916B0088; Mon, 19 Aug 2024 09:45:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02CBF6B0089; Mon, 19 Aug 2024 09:45:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36016B008A; Mon, 19 Aug 2024 09:45:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C039A6B0088 for ; Mon, 19 Aug 2024 09:45:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5161A121259 for ; Mon, 19 Aug 2024 13:45:47 +0000 (UTC) X-FDA: 82469117934.01.A7B20CC Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf20.hostedemail.com (Postfix) with ESMTP id 4775B1C000B for ; Mon, 19 Aug 2024 13:45:44 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kgZNZOTv; spf=pass (imf20.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724075042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fD4i0svjCsU8SycKPnQ9n+u2qUcon0ngRKpMteb06XI=; b=5cZa1ZsjcNFTbOvTbgDuiwQdex0gsNJof0HVHLva8LwBM4WPlYTlq1Q1kxPLOzl3uJd1WH Amyf6lPvHzHvVewQ8j0nOCFc1+cln/iUxdpyhIKWBv8iTs9+wOiDZPMBTjD+RNn6WZXfQW NxG5cYvT4NfQTb6WphrOud4QlywpJXg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kgZNZOTv; spf=pass (imf20.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724075042; a=rsa-sha256; cv=none; b=lX5Ek9r1fzVQ/gkit6dyLyoZ7fvFKUspAkOcRsbc8CZK6c5+w13jTttK3uv3eu/GeQjDzm MPD66q6JbNDnxoYlz9oUN6sE9i48bdEcoDCmd598u0n6gX1RaB3rE5XXdvmglmBmuYkIvu mrAWaspVG9PyPC6cAgFLsEZEnYzRaVE= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2f1a7faa4d4so1235541fa.0 for ; Mon, 19 Aug 2024 06:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724075143; x=1724679943; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=fD4i0svjCsU8SycKPnQ9n+u2qUcon0ngRKpMteb06XI=; b=kgZNZOTvjr7mzb5QsCfGP2bdE1xbEtLacfnudnrPk4AMCVh7Twglfkdri9wusegnxk 7OMRw3US1NHk9nWpaUVk2pN8Jde7BMx25d9ZLwYa7ja9eSBdWXkM/59F6P7GS2Q0QA8d ZWBa0meltewZBJCaPATw5XEM5vuprfDYf5PaMm4gNXEJZax5mv2EWXasiABC9oGzUogm 4KztR/iqVFIzDiprWApMCY3GnnaRc5tvWGxv1ijsDHoMk50mG4eXTlS8yuxrigOYzzsR U7NOg6zn89pcWm8r+JxVI54qHzwS6Yw3F8/CU7D5mv2vQhQhm3qTjFcDNjagvtM039y9 lFaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724075143; x=1724679943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fD4i0svjCsU8SycKPnQ9n+u2qUcon0ngRKpMteb06XI=; b=UUR+XMKHZtqNXB8wH34bLGbBRsfcTLt5lkuBf/1RqN/ovaRjOX+eG0D8Vxx7JWg9Ig U9io6Xvrb/mZ5mMj91IwWjgCMzmfYnIT1AVUIW9pxkNLZPChXybYJQRMCamhBmMGepx/ dMC0pygEfqoi3Hx9zX8ogN3Uj0LSpUjQAsuwJjjrHvk6R2816Tr4ImwriaPuGe4xzTvN 0yinzlWql1fiKnKr7Dg9vx+PwtmllwlH0gexYMMN0o4ctj4D0Zl55QVO1pbXy1QPVBH+ F2EUL9fSl1h+ZdKcSlf1Hr4u9fRIKcsyWeRK1vHXCh+9XjaghLsYRqZ6H6e0UHZEexoq CTvQ== X-Forwarded-Encrypted: i=1; AJvYcCWHoL6q71lGR6nhmjneHeEl2Hpto2ma8oxqrOht9yiJyet3bNcmj95Qu/kT4UVuvD9tZUs6BtJQr2IvlmLiy5Zw0fU= X-Gm-Message-State: AOJu0YyCb4KZriiGB8YAVSAEGc1VQTJB3rVLVdC3P4olsCBmOjXvgcLM bzkw4wiPPWfcSqAhYS4kjMWwO0tIDBHN5jiM++F6kHF/jhVJs5e3 X-Google-Smtp-Source: AGHT+IENoxLryRMzpvEoN1Ur7jC9BkqOLVNKCh71aitZqunk84KecPpDS7BAcGGII/Ti03XDZc0ahQ== X-Received: by 2002:a05:651c:210f:b0:2ef:1c05:6907 with SMTP id 38308e7fff4ca-2f3bf05a5camr36452501fa.5.1724075142825; Mon, 19 Aug 2024 06:45:42 -0700 (PDT) Received: from pc636 (host-90-233-222-199.mobileonline.telia.com. [90.233.222.199]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f3b748db9fsm15475711fa.40.2024.08.19.06.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 06:45:42 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 19 Aug 2024 15:45:39 +0200 To: Hailong Liu Cc: Hailong Liu , Michal Hocko , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> <20240819125738.vbjlw3qbv2v2rj57@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4775B1C000B X-Stat-Signature: jnkmkjrndfff4tkmg3onr9hs7c1ppsqr X-Rspam-User: X-HE-Tag: 1724075144-137623 X-HE-Meta: U2FsdGVkX1/cZE/B8Cnkv9TK26Zn20SBLWJacD+IN90OS6EvOO7Bwt5FEkkHupFbdfh/YTD6iO3XMS3yOOr09iZYigL3X0Y8ZsItBoOOVevI4HqB52mG/vJQP7fbrICmXpr81QQ758Orz7Wt4lGIJy1cIkrsI/KNwpth+KxgwRTkDeiAJmlBAa3Ctxc+hOSmoZNvKa9IL4E4BMEmzEeUY0SR7U9lc6lpknKU2VNc3WbQOYQooD+ZxSWmFsbQ0lUs+9oTWuIc3qzF2ZRnp6+q2q3t3eegdJPsw+eO6uaI6w1rYo3EGdcVTJTZSLNGVEup9rBtoqeSIzdlscZWJrszW98cImTjh1EEXPE8tWNJmNSiORiYe32XEA9fczhSWqnaZWH56S7RHF0H4lfcSpG/Jp8Q/nP1yRajGI2XmaCV1yQIVs7h0xupDEUedQzGztZYmPyUINGc72T6zNPnuak8db2YS/vOi+hRYMsxD8kKzbfTtUYcJbolqOfWHAyBFX8XCfkjTDQ73mH+cA3061X/z8Va20Vj6J/EfNKdOUI3NDzNRoHHh3ocXtJwSbz8rLruzrxmYKt36D5aMlmBEW7eQdcTcKzC61oIMtSv8l7OBTKn5zBhv1Tgp4YaTwPwd1zYn3YNRU4cJiXfZv+06iIVrL1GhjXqKid4R3Lxofy5n5pqvXwjm+E78YFvMpaR0hks6to0YXsFqR30TBoO2bHfC7Aw1oeGVHVyiUEBAYsEl5a2O6SlEYobidni7nNww0wlseHVKymb/8C0MKdW0cKzqgdh+G1xdu/kjxP3ZRRt+0z6MVuD0WOzmQ9aLcXlnd3jalMMaQ+RR57B5BY41CHmAW8+8ohInUi0IXGjbdI/su+XRsdq+UogfIr2qSEhpnYBZTveBRXDTUBP1x4IDXzigKEerRK4x1t3mQ7QhWC/+aI7HdzuqFBehBx4kfH+nvWc3S2JEPSSnl13Cg+ELOR 3itrWHXi 6ALDxEEzce163Z0yAFZp2Y0rWW80yyCjlefTKgKy92m9WfbudfjgM7oxm+6k4zfg6ftb8hniM/xvJPdEyEz/mNgSJSERCvzjIS5ncroGkNyT2PLHpiIZs4YrTO55bBqTaqdk5+TFWySPy84OY6bcnecGJOPx4riWZDEqtIIhMc7vWXUQs05vNCpuJy8+y9KljXyQEMbLUjhEU0G3AM2F/xEkV4KjfYVTaJKGa1z+nd8A30o/Rz1tnRDZufUtUot3xnY124mAJ5vcCP7YPh3xA5lXpAv37k/KRNk19wbQXuXbTxBec80gyosKie4KRHmocc/iIxua8kjJGxkPQv+CE6/c/Vo+ZZpdVVg38xVH0C1Q28iyySafogmOuK2coyJDo4RiX36TOnOO1PjMn3mM6Nu/ztFItlzgrWKXuSlr+ODxco1EsJgK05g7GZ0x5GjutK4HlBRekqTJ9sAXnKbY/LR9WID6DReiVAjjb1uGZp83Ka81byWzMEVR6dXo2hHEGbdURiNeB7eu42EXGvTBIb90rbceHI5SwpiYrXzVx3OCYwpSfN++dSiksDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 03:38:51PM +0200, Uladzislau Rezki wrote: > On Mon, Aug 19, 2024 at 08:57:38PM +0800, Hailong Liu wrote: > > On Mon, 19. Aug 13:59, Uladzislau Rezki wrote: > > > On Fri, Aug 16, 2024 at 07:46:26PM +0800, Hailong Liu wrote: > > > > On Fri, 16. Aug 12:13, Uladzislau Rezki wrote: > > > > > On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > > > > > > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > > > > > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > > > > > > > > > > > Acked-by: Barry Song > > > > > > > > > > > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > > > > > > > > > > > fail: > > > > > > > > > > if (shift > PAGE_SHIFT) { > > > > > > > > > > shift = PAGE_SHIFT; > > > > > > > > > > align = real_align; > > > > > > > > > > size = real_size; > > > > > > > > > > goto again; > > > > > > > > > > } > > > > > > > > > > > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > > > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > > > > > > > > > > > Thanks for the fix. > > > > > > > > > > > > > > > > > > Acked-by: Michal Hocko > > > > > > > > > > > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > > > > > > to order-0 should be commented. > > > > > > > > > > > > > > It's been a week. Could someone please propose a fixup patch to add > > > > > > > this comment? > > > > > > > > > > > > Hi Andrew: > > > > > > > > > > > > Do you mean that I need to send a v2 patch with the the comments included? > > > > > > > > > > > It is better to post v2. > > > > Got it. > > > > > > > > > > > > > > But before, could you please comment on: > > > > > > > > > > in case of order-0, bulk path may easily fail and fallback to the single > > > > > page allocator. If an request is marked as NO_FAIL, i am talking about > > > > > order-0 request, your change breaks GFP_NOFAIL for !order. > > > > > > > > > > Am i missing something obvious? > > > > For order-0, alloc_pages(GFP_X | __GFP_NOFAIL, 0), buddy allocator will handle > > > > the flag correctly. IMO we don't need to handle the flag here. > > > > > > > Agree. As for comment, i meant to comment the below fallback: > > Michal send a craft that make nofail logic more clearer and I check the branch > > found Andrew already merged in -stable branch. So we can include these with a > > new patch. > > > Just to confirm. Will you send an extra patch with the comment? > Also, an idea to handle NOFAIL outside of vm_area_alloc_pages() looks sounds good to me. -- Uladzislau Rezki