From: Matthew Wilcox <willy@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev,
corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org,
rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com,
tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com,
ardb@kernel.org, david@redhat.com, vbabka@suse.cz,
mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev,
dave@stgolabs.net, liam.howlett@oracle.com,
pasha.tatashin@soleen.com, souravpanda@google.com,
keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com,
yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org,
iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com,
kaleshsingh@google.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, linux-modules@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH 5/5] alloc_tag: config to store page allocation tag refs in page flags
Date: Mon, 19 Aug 2024 20:34:45 +0100 [thread overview]
Message-ID: <ZsOeVSlToyhsyDGD@casper.infradead.org> (raw)
In-Reply-To: <20240819151512.2363698-6-surenb@google.com>
On Mon, Aug 19, 2024 at 08:15:11AM -0700, Suren Baghdasaryan wrote:
> @@ -91,7 +97,7 @@
> #endif
>
> #if ZONES_WIDTH + LRU_GEN_WIDTH + SECTIONS_WIDTH + NODES_WIDTH + \
> - KASAN_TAG_WIDTH + LAST_CPUPID_SHIFT <= BITS_PER_LONG - NR_PAGEFLAGS
> + KASAN_TAG_WIDTH + ALLOC_TAG_REF_WIDTH + LAST_CPUPID_SHIFT <= BITS_PER_LONG - NR_PAGEFLAGS
> #define LAST_CPUPID_WIDTH LAST_CPUPID_SHIFT
> #else
> #define LAST_CPUPID_WIDTH 0
So if ALLOC_TAG_REF_WIDTH is big enough, it's going to force last_cpupid
into struct page. That will misalign struct page and disable HVO --
with no warning!
next prev parent reply other threads:[~2024-08-19 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 15:15 [PATCH 0/5] page allocation tag compression Suren Baghdasaryan
2024-08-19 15:15 ` [PATCH 1/5] alloc_tag: load module tags into separate continuous memory Suren Baghdasaryan
2024-08-20 7:13 ` Mike Rapoport
2024-08-20 7:26 ` Suren Baghdasaryan
2024-08-20 11:10 ` Kent Overstreet
2024-08-20 15:31 ` Liam R. Howlett
2024-08-20 18:35 ` Suren Baghdasaryan
2024-08-19 15:15 ` [PATCH 2/5] alloc_tag: eliminate alloc_tag_ref_set Suren Baghdasaryan
2024-08-19 15:15 ` [PATCH 3/5] alloc_tag: introduce pgalloc_tag_ref to abstract page tag references Suren Baghdasaryan
2024-08-19 15:15 ` [PATCH 4/5] alloc_tag: make page allocation tag reference size configurable Suren Baghdasaryan
2024-08-19 15:15 ` [PATCH 5/5] alloc_tag: config to store page allocation tag refs in page flags Suren Baghdasaryan
2024-08-19 19:34 ` Matthew Wilcox [this message]
2024-08-19 20:39 ` Suren Baghdasaryan
2024-08-19 20:40 ` Matthew Wilcox
2024-08-20 1:46 ` Andrew Morton
2024-08-20 2:21 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsOeVSlToyhsyDGD@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dennis@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jhubbard@nvidia.com \
--cc=kaleshsingh@google.com \
--cc=keescook@chromium.org \
--cc=kent.overstreet@linux.dev \
--cc=kernel-team@android.com \
--cc=liam.howlett@oracle.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@google.com \
--cc=pasha.tatashin@soleen.com \
--cc=paulmck@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=vbabka@suse.cz \
--cc=vvvvvv@google.com \
--cc=xiongwei.song@windriver.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).