From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D90DC3DA4A for ; Mon, 19 Aug 2024 19:35:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A0026B0088; Mon, 19 Aug 2024 15:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8504C6B008A; Mon, 19 Aug 2024 15:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 717FC6B008C; Mon, 19 Aug 2024 15:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 54C866B0088 for ; Mon, 19 Aug 2024 15:35:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F08D914062B for ; Mon, 19 Aug 2024 19:35:20 +0000 (UTC) X-FDA: 82469998800.20.D749E29 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id A494280023 for ; Mon, 19 Aug 2024 19:35:18 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S+ehbQTT; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724096056; a=rsa-sha256; cv=none; b=YYLaIIDD5hoNFO59/0+74lJSKZQ3eCSqrxMZuAQMNtsDYugCryrhN5ihNleUl74SGJn/bC SUnjt90XUW+k80d9Xs9tRXxf5nQ94xaflrSOIro25yhKxgEakhqHCxcCFxtuFGAroYdfdM zSrTANDRMQT9ovgaYG8tcDw9dXi+pMc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S+ehbQTT; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724096056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GgkSbPAh5KOwEoij59vzgPrDRTBo+einBkTJg8LJEK4=; b=Xp3MW6nzo+hsGUnpcGru3Fd7/Bw86atooJ/zhMAubf6hemtm9IwodjnjGc5XsMeVrpVRDb +R4ZQ4o7ikzgQzOXftH3Uc9RdBOwcYs32i+btG+FTAZ01OJcyzcf+S9ovS/IvAeiwn+Jzy oCwKQkdhs0p/G/DoB8Xa3lHDejmCfaY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GgkSbPAh5KOwEoij59vzgPrDRTBo+einBkTJg8LJEK4=; b=S+ehbQTTfQwUW7uPpk8GapUl5B UO27g31htpfVF8q0tyK5h/zlnt2RYj7JCfRQUYM5OiyXwoEUmOge9o1JcD96tqAWweRBzatGnfKxH VN/YgyIk0y2cYf29wKLGiXYWuCpUb17YjC7ggGWRTyeUu+EDzYPxRDWbzKwAhXqpv3nv5WqGX5ESc DbrtlZEny2y0WZ/yHSwFo7U5w3IQYBc0fgxUWBJB7RNJp8CD5J43eaMuxjscMGXg5IP1nbIn0wiOk W7XM61Oz0TFCyF49R96gNVaj0RkF/D9/rMcqbxN7Pn8Fhj8yJKD0g1tNyjpwkBvX+mln0qY+xZi8N yc+2QiZQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg89N-000000076SA-4BDT; Mon, 19 Aug 2024 19:34:46 +0000 Date: Mon, 19 Aug 2024 20:34:45 +0100 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 5/5] alloc_tag: config to store page allocation tag refs in page flags Message-ID: References: <20240819151512.2363698-1-surenb@google.com> <20240819151512.2363698-6-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819151512.2363698-6-surenb@google.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A494280023 X-Stat-Signature: t49casuw4c8n47prnrk6og5id398pyny X-Rspam-User: X-HE-Tag: 1724096118-450939 X-HE-Meta: U2FsdGVkX1/c1VpQwYYygqVde04YV1d82yHZlDhqEqokqFeZ1bT1Du8wW8T2i1fzrSR37gHwiPsMW9ldbylr2D+qeFBTH09LI15SOvD0mT5zuZZ7ONayDuuAb0+i4QcHKvaLj1B4pnr67kZrJo0an8ILwtyAABboJFOKoM2EC41iaorIH2k4y6o1hoRAVbljYdlpwNCtupBiDDYPPhwV/11W6YfRDsU/O4YSQH/xWIC+LCg+hPwgyg6/nbK8v67owOeumECHUC86BVOyq/JvLOEPkrOFjWtUhdCp4AJ6KpHBmfhP7eNmehjyryVJKhNUkrkCbY18fMo/kkojXhKQEgswmY6NGTZx23ZE6eZhayJ7I2MVSw9xN2ipk3HZKNN7kTzY3eMqwVVls+3NOgIlTmwjTl+n3H4nuwxvbs1C5ZYlxFZ+LYuwrbjtn+Vmkq4Xhb9FZQN/PyL+5SGCTu8YRMXcJp8sIXPs/FMvhXaruzMm5REsNyoW4Y80sF4vKo86Kr/TZeV32jxmWsQ6OWxfLAk6O82LH/9ClDY3fjxoQPRYU5Ko2k+QBB6RAEThXo2PBkStYKei6zLp43QkvgwiJ2aSJtAJZ1sIu08iQDQ5jYevb2TFzi3qskWw2fWPkBcSKcckOx+uLhdDdBXI8Cz5XjtBitQ0u/2vo4gOqOgX/O3ppLFZbUvR9RnuNP1WhwrTm0lys+H73VtN5k0co4pMY+4pzD4/9VZiBH68Yn9NzZbNoRh1irpBNK+nBIWRAVBpbP4wMu9Yp+ak5hy8QcSZtOju5COVkguciRjACCqYXVpptupmfl0TA7h4gUOAb1xJZ2aGuQfPqveJXnAugf3R6tTzmAPH8u07plUOZ5IlX/lGPJ7x+RUe+ZCf0uGovXRZ1VJBd4mevPYWw7hshPx/pIRVkFutQGmnGwG8ZhcP78ix2Czr6mgRSVgrsSn+Nop/yj36kbz9RSasoQCsuJW BYuSVhAk UO7yu6o34cNvkYhLT9CcPBXzBFhL4KSsC2hrCI9NvQPVKkYB1x6bEhvdTCiDe4/y7vjuYr7ki1HIXf8FbykAkVokVILJzI7DECHWCA/Sh6pLAE3f1VBNXSFs0voKdvUXrQWGFaChxE4qjyk2t0CzwdmYDaHQ4Lv7hhjLtbXzB1VxnobbzLzUm49COjwQeOuZFiNb+Jq/cMHcSXulGm9VFTBRfFpWK0zUwTAfB4AHZhtKg43Ympq4yaQOQ2fk60GQSu7xg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000939, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 08:15:11AM -0700, Suren Baghdasaryan wrote: > @@ -91,7 +97,7 @@ > #endif > > #if ZONES_WIDTH + LRU_GEN_WIDTH + SECTIONS_WIDTH + NODES_WIDTH + \ > - KASAN_TAG_WIDTH + LAST_CPUPID_SHIFT <= BITS_PER_LONG - NR_PAGEFLAGS > + KASAN_TAG_WIDTH + ALLOC_TAG_REF_WIDTH + LAST_CPUPID_SHIFT <= BITS_PER_LONG - NR_PAGEFLAGS > #define LAST_CPUPID_WIDTH LAST_CPUPID_SHIFT > #else > #define LAST_CPUPID_WIDTH 0 So if ALLOC_TAG_REF_WIDTH is big enough, it's going to force last_cpupid into struct page. That will misalign struct page and disable HVO -- with no warning!