From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3819BC3DA4A for ; Tue, 20 Aug 2024 06:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C5C46B007B; Tue, 20 Aug 2024 02:44:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 874F26B0082; Tue, 20 Aug 2024 02:44:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73F2E6B0083; Tue, 20 Aug 2024 02:44:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 55E666B007B for ; Tue, 20 Aug 2024 02:44:48 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 001151A189C for ; Tue, 20 Aug 2024 06:44:47 +0000 (UTC) X-FDA: 82471685814.05.36471A3 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf01.hostedemail.com (Postfix) with ESMTP id 088EE40009 for ; Tue, 20 Aug 2024 06:44:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="NzV1A/wT"; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724136247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LVCGVjw3ZtFMoPtC0UoVVHS8e9hLIYB0gBh3PM6zXYA=; b=Av40HmAtEbcXx+T76YvwH0ZK/92B0dSjfDWGNuVSb6WGmyj2f+QvATzfYaSQu4MWXEjg2w vVAWO06I1R6wiw2V/5jlElYWbxIjtJI3TZtuWyLz1WwXY6Q35yHd5QXsx52/guACJsvPDM IW9E6t+3xDSnkFCPifhx34mBynHO1TY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="NzV1A/wT"; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724136247; a=rsa-sha256; cv=none; b=728m44rHkPQxOMYgaIyMok+jWaqauI5lVbTeZCrZgF6kMGsskDTQkTr15btUCl9om1hsc+ kFjlXghJ2WoCJbCnEeMfA0l3rVWwD4mN7x1vK9+Hp1z5DFyBQyQasCGEaG4iDW+r+wltdX ID3Jgavxm0I8wjxRzKPA+SqM0WvCodU= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2f15e48f35bso50551931fa.0 for ; Mon, 19 Aug 2024 23:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724136284; x=1724741084; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=LVCGVjw3ZtFMoPtC0UoVVHS8e9hLIYB0gBh3PM6zXYA=; b=NzV1A/wT8H2Du3CepAZSlp6yVDtW+97BtAisKHqZGW6/AtWt45HPHxuFhtfcSR55es w1j7vpJ/dyYLYkQCApE0SWCEPozFQaIS7uIZQGyMGR5GLdmgQtNIb6xHULJv0oxMneTN 28SUPGsE3j8iUkqcaMinv37yBKUGutbsLd+/cIY2E0dZdmKerkr0hINwFeo1N9rPFamG 6J09aaJQ9GnBribATCHU1jxZzc6G4GG7WuJvmrWg7PqMUmoXDnpURo/JStuVdHNKdrEv t4hyKdGFuEcPu0WOZ906EFP+IMLKJgtyIrqpuoNFQQ5tF66NlUdDU0mM6K0KZ9tEZAnb 0Jmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724136284; x=1724741084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LVCGVjw3ZtFMoPtC0UoVVHS8e9hLIYB0gBh3PM6zXYA=; b=uldpjXC53/SrTrvdKS78QQGqL8YlWt4CuvzvVcaY2Gdkdy66wnho6vesx42e/9b43g UrjQsWhbP6VpJjUDLK8t063mnTjPz9/arsvXL8h5KkQmdmIuatSUPYLuEc528RqbqM+l NuCQoAsDzQBWpKT5fV0C3nM1rJLVcx3OZDEw79BmfiO0/ivQwLKOgllG6ht2uSEplfDr s4/K3o4AJStRYXuWUzuo0w99z88/d75Na84vQC1eZt4K5KOpIIqElngYXvQ553yEd9Xq 6NOwQdW1cEoAMecEfTWZOOW2aOjfkVqUnrFs1ioGRiy0dHGDlo3b4K462F60LhkTrfIl XI0w== X-Forwarded-Encrypted: i=1; AJvYcCVYDQ8SA25k1vLNvFkCGVf3tTtXFsy/xS8khTXZFOOCO91S2OTLxjza+Af8mfjbS3m8OWvEtOZL9MnyLPTwXUihXyU= X-Gm-Message-State: AOJu0YztGHVwq90tb6eVhWyz0FEkfKsTNKfgW9wgcq4wEd9+mthjHZC3 vFDV6Nymlc6nAA/cghrwnPv6lospUJneqqWqv2J9dObTwmXre7m4 X-Google-Smtp-Source: AGHT+IF6YYOdv7wFwDBwLEMEH2iDgR11i2wgsnpvrCfHTnzcEQ6P+GC+cedztSOSPOfHE594QFATLQ== X-Received: by 2002:a2e:be8b:0:b0:2ef:2450:81f3 with SMTP id 38308e7fff4ca-2f3be57474fmr99319511fa.6.1724136283480; Mon, 19 Aug 2024 23:44:43 -0700 (PDT) Received: from pc636 (84-217-131-213.customers.ownit.se. [84.217.131.213]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f3c234cd03sm13359261fa.70.2024.08.19.23.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 23:44:43 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 20 Aug 2024 08:44:40 +0200 To: Hailong Liu Cc: Uladzislau Rezki , Michal Hocko , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> <20240819125738.vbjlw3qbv2v2rj57@oppo.com> <20240820015950.toqohtw7ofpembjg@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820015950.toqohtw7ofpembjg@oppo.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 088EE40009 X-Stat-Signature: e3sdmbzoxb1ia1ojqa4p6ddnzponxkgm X-HE-Tag: 1724136285-414174 X-HE-Meta: U2FsdGVkX19n9AjUTKHfSzfdX1HpUwLM9TG4AOBWw1v/Dn10lwlUx3bNDXrrpo3Av7xIl9c5QGsZyxwR8KryZHD2CXu4l5nye0qrV/di83RgisZ0k8kfZV1ZGp8EZ8HsnYQrkAwmjRw67qowh9R0CBj+akQTQreXOFcQiHB/VG6GAdsTSwRi/RhLLIVeTX+UUE2DZPoRoa9hRQimxIKSnGkbusAmR7XX4CTva9Yfnri/72+fjydiC17pg7JvYToSu9CL1LnzQX52m/QKCY/KFwdqHylkL04bREQKdhumjYHTdDhheKQzybN0XuWQsQ/qaDMeHlQGI68q0ybthXVqCOT/nX0+teDymezs7VouNr73Mse71BvGkWqYTcaJ4RJhnsgxgW+w47aMBQg6UsQZIwbm8ie0kjWDGOtg6Ava8RKGjXXFFFlT9ijlh+kM/5fA61TrHCQljaEOMug2voa0HiogKHQOINwpqkFTNNUPhFzvxJsd37xvN/KBjmS6eAi4+EwhVAN6iS/FYYDgu6jhT9kbOK8PEvEeVVr5LKZBnPrSEfpxLbsIcitKhtxrQ+tP/TTXQjHMkV2ZdfE1iC0C0+wDdl0EcxRZg8/no8jI247zrf5pvMa07sSvJf66knzzewMDiq+qZUgcJrUlpE6QUo5ivTQg2FDDxtlcNJCZ2Fgb+OUj9JVfmy+Z9COvUZcYCgIav+5WmJNfm0RE5AnhgzfnCeAGOPoyBru71/aiHPoetTc5O+V3Bvr7/y3SAs2d8JufpWWHGbXplJVFix+E5OzKW5xjxP8mbf8ft645uRRNaf9Rz0yqMe26F0F5r+RJ7KLNodGiP0EWhVvdiXBSOLqqt+bYEqQgA3BmnlZaKLfLX/8HwEY+ezQMtuamjN0M1XNBBPyWp8KfVGoEPiVNy9z4ey+4kMz1QzWlN4RWammQgzN9COj8BpUtUHvxDJVgQXtAcBqiC1g78MFLp0D 8Q6/uxn+ ScKHzIMioNkLcDA2ajengfS/halrcTvkgOWGhMFCCnJ/7t1hkeihXC1m95UstPKTJilwcNPQ3xDJD1TGshP2Y42o/ZORiRtTzm8xjj8g5Hl1jY5bW/QmnF9BtyTC0rR6J90qQ/2FH/Vmj/t7mlO34zROKzwpvWYmeW4S8cPjFjoVRKwva+WHpDg6MGYR4gFehkeOAwXpZyhLm2TAsLklq7RzFrhj0gWJkE8UKdOvX6A0dl2GI3aEl9eQ/72xWnTKnm5lpRLEL7bvpCObRBoFJnTuwXQJ40gph76pOflE7VLQqhIV+wE/VoXHbkxGoVsJfs1Xh+MEvhIHgBpZQXRQvsojcACCDColtcB7FX6mkfVNQjbHFRz1Z9XCLMqtlm+kpUe0foOTwoJ7uCX4fIKmQ5EKszA2Qj2kzGNVD9S2z0Coy6L8EvZvjZ77lvsEUwdJt2r18jQjvqi8q2b5ckOwuNwp4eyupo8qXs4NeEk3v/iZCLMumd6zrOUBRVNw8k3U5nMx2TbSMXqd0wPM5MqwwLAnGGA5Hs0I7egpIXf/rHccXSQ6xdh6GVUncSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 20, 2024 at 09:59:50AM +0800, Hailong Liu wrote: > On Mon, 19. Aug 15:38, Uladzislau Rezki wrote: > > On Mon, Aug 19, 2024 at 08:57:38PM +0800, Hailong Liu wrote: > > > On Mon, 19. Aug 13:59, Uladzislau Rezki wrote: > > > > On Fri, Aug 16, 2024 at 07:46:26PM +0800, Hailong Liu wrote: > > > > > On Fri, 16. Aug 12:13, Uladzislau Rezki wrote: > > > > > > On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > > > > > > > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > > > > > > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > > > > > > > > > > > > > Acked-by: Barry Song > > > > > > > > > > > > > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > > > > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > > > > > > > > > > > > > fail: > > > > > > > > > > > if (shift > PAGE_SHIFT) { > > > > > > > > > > > shift = PAGE_SHIFT; > > > > > > > > > > > align = real_align; > > > > > > > > > > > size = real_size; > > > > > > > > > > > goto again; > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > > > > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > > > > > > > > > > > > > Thanks for the fix. > > > > > > > > > > > > > > > > > > > > Acked-by: Michal Hocko > > > > > > > > > > > > > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > > > > > > > to order-0 should be commented. > > > > > > > > > > > > > > > > It's been a week. Could someone please propose a fixup patch to add > > > > > > > > this comment? > > > > > > > > > > > > > > Hi Andrew: > > > > > > > > > > > > > > Do you mean that I need to send a v2 patch with the the comments included? > > > > > > > > > > > > > It is better to post v2. > > > > > Got it. > > > > > > > > > > > > > > > > > But before, could you please comment on: > > > > > > > > > > > > in case of order-0, bulk path may easily fail and fallback to the single > > > > > > page allocator. If an request is marked as NO_FAIL, i am talking about > > > > > > order-0 request, your change breaks GFP_NOFAIL for !order. > > > > > > > > > > > > Am i missing something obvious? > > > > > For order-0, alloc_pages(GFP_X | __GFP_NOFAIL, 0), buddy allocator will handle > > > > > the flag correctly. IMO we don't need to handle the flag here. > > > > > > > > > Agree. As for comment, i meant to comment the below fallback: > > > Michal send a craft that make nofail logic more clearer and I check the branch > > > found Andrew already merged in -stable branch. So we can include these with a > > > new patch. > > > > > Just to confirm. Will you send an extra patch with the comment? > > > If this is not urgent, I can send this patch later this week. :) > This is for synchronization, so we both do not do a double work :) -- Uladzislau Rezki