From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626B2C52D6F for ; Wed, 21 Aug 2024 11:44:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F1F76B00E5; Wed, 21 Aug 2024 07:44:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A1E46B00E6; Wed, 21 Aug 2024 07:44:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 669BD6B00E7; Wed, 21 Aug 2024 07:44:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3FB876B00E5 for ; Wed, 21 Aug 2024 07:44:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A96CAA8323 for ; Wed, 21 Aug 2024 11:44:11 +0000 (UTC) X-FDA: 82476069102.16.D0F29BF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 0441712000B for ; Wed, 21 Aug 2024 11:44:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=soGsd5Za; spf=none (imf29.hostedemail.com: domain of BATV+5a17de65a486cdde784a+7668+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5a17de65a486cdde784a+7668+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724240571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G1NccRhi7/UxbXUXfvO5IP+/hVG27t4u56SnhsRtCy0=; b=R7UTxm+FmrhX4/EELYtePHSR+KkekOSPuf6+WW3kCXOnNR0g9y4YlvhG6cwE9aC2t1ya1U Obk/0MXbNmAXkcp9ov7qKItVdQOV3Gs77XMAwnv3YpcMJYQVJ6rKi/eehdSU9r9Co3ki/i ymLHyMtNcL8C8miePQ2XR21yojRPd7o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724240571; a=rsa-sha256; cv=none; b=qJ5AlRHR2i3yX9Abk2qLxSHhkaSmZqigMKv69Z2cS4UXbq9GfXb5+kq53YWeJ0hv+lNPZ4 GcymQPj508WN6NipvdQX2Lr8QgJwohlbx05LgeenqBVnwDiEohk01WhU/dHRUrfCmPQuFp fPDRqKPLsOvRDOcisd+s367W+ldrR08= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=soGsd5Za; spf=none (imf29.hostedemail.com: domain of BATV+5a17de65a486cdde784a+7668+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5a17de65a486cdde784a+7668+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=G1NccRhi7/UxbXUXfvO5IP+/hVG27t4u56SnhsRtCy0=; b=soGsd5ZaLfm9FSjnB5aMi6/WkQ pmMFWUo3lKcBJ32X09BwZxVo3CgANfs7wcJpX76m/O/zeG/UzM/QmZ9O2L0pKtzpApQhjbdDkF/8v GafDVUCF78szYZKI+TX/4hoXcqy5fNWPP+wopOIJrgxzwiNwzD+YbtsliXgKyh74hz64EasnV5KHU KI0xi0d29eYXuO+jpRSr5viNXLoDLU/PnUpl0H1lZdUvSV/L/EhWO1yJOM531hSyaG8PgPJO9Sww4 g0NAdYLOziuKOMFUZrBEz835bEbVZJEd875YLK9kw/h0/5mpNydLyWs4V5hDK0EVHsw8O5bnaf/lK 7i5rQnoA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgjkx-00000008kj6-1UZH; Wed, 21 Aug 2024 11:44:03 +0000 Date: Wed, 21 Aug 2024 04:44:03 -0700 From: Christoph Hellwig To: Michal Hocko Cc: Christoph Hellwig , Yafang Shao , Andrew Morton , viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Kent Overstreet Subject: Re: [PATCH] mm: document risk of PF_MEMALLOC_NORECLAIM Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 0441712000B X-Stat-Signature: khz9t71hnji64itmh8mt8wj6xixe3mg9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724240648-190850 X-HE-Meta: U2FsdGVkX1/D3Ab7/qBr/n/4lnaeUOr/LlmQngY4XwrX77CvVQ7FeLOuDRENcvoZPuMo10t0v7DzofglNNyO3Zcd+3Qbgc5xrFS5+/L7iv824PC/v14vnuzd7laMdIn8+0QR3XqXx89afzDhul+7Z9R58z7/CasIB43VsS9LglCgJg3mlzttalhUqICWoAvAtV7SFQsxEToHga0pKnaqIQiOt7oQ4nLsF0kTZNS75lIm1olh9HBEX/gCJ9pzgNOdeAaxVCDamc1JxMwKqkYbkhYujYD7VuDhOEfC3Wqt2NH3ZsvhjjvkKf3Attn6ZR1B9G/QevkzpRDBcjIbEa2rWMsNtJyouHosFQMelZJjoAbFzOvPVYSRDT5/l7MLXEcF4wDWgqh9dCK5AYMScHqaIyafqV36MrcCWp+fn4VgD9oQPSIV5OztBsrj5LzJjsG283T8ulHOCAHmhCx6DOuTtpg8onJkpUaqEmHB+9VF+8P4ddN+h52IkCOfBgi9lY2v6g/KR2DUpYnmGNXkDrlxb5I2akaErqlAWevoMXrqJVXMmkfAuqmULyyaazDu9twatQgwAWRAQNjlRxyS6+PE2SKaHaT3VolpM49XnaoWbLQa9medr18WXmGCYUnUHky2UKRQ174LAHCS+1UoUGZnwXSkK0POfgfIUJc+bA+HORSkmOJspzuYYWfc5k7p4LHTg9KT2leWPZl3iy7e1TjP3kkwv6VAQ2C73X6S71uzPgZEnH6U4+JDYlHBdROM4EYbbbOQQn4lym8Zap+erwi16owaVMSedkzMzQhI7rN77qGjvodWfhK9aZNBz8nBjJyVJeyVtOk9/wcZLc0sBVc6MbnNVn6yGhG2DnIOfwUgd5ere5xDRLov4PfyCw3kcakHOv7qz10400+TTL0HM9oPzWyjxuMoR8wzX00/TXK4gae+8poZZmReNuCT0MeHYyGh+GHU+RjK8DHsztziDtg 6wJNkIrw EPTnbXyHdPmdZbtMhIrw/qcMh6KF+NJ3OyLVD8pD+qB8ezAC60EAUaOPgb+csmns9I3TeKa05BEiW/OFP6cwVVPUmgp7jZenl82vhTYooSndWJL5ShPDhvLuc4zw7HhRjqm50OsODAsuvqA8lvz6rhVJuPL6CgAVqwHus1pi37TSTykj/vK3JRoMbmGB07fik1s0rpmOFyrrmpGh8CB58CvdUpGOKcUZrQXH9TkgnWlhDhCv+dqw49Lajznsr3/yxUvL3DCUnNPWVRCiI2zOuXj6EFtdVLGoTL0Hd2HDVNSpzyRloRcqFGqWTA9z7StJWacL7LuiD3kSWd1RkfybBFnPBL3jboYBuPIj8fx1aQ4jIdPjJXY1vyL636HFPkUXISI+D9xHpTSsZ/9ON2i30VumKbnJKrLURCZ6rNHYo84axSNKcWDZ/LUZWhpNrX70tT1Hh+qa6VwZfqz0q0TWgbWsaFRZOo3KHlZzzBM164HWUcS8e/FfsnUwpQD1i4XKULC4iegI7Qfh3VFntOXcdKDIkn0t4cER0oqLuugLIA9+FEfvrdVMhxJA16/lqSTtfHQGG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 10:54:37AM +0200, Michal Hocko wrote: > Yes, I think we should kill it before it spreads even more but I would > not like to make the existing user just broken. I have zero visibility > and understanding of the bcachefs code but from a quick look at __bch2_new_inode > it shouldn't be really terribly hard to push GFP_NOWAIT flag there > directly. > I don't understand that sentence. You're adding the gfp_t argument to it, which to mean counts as pushing it there directly. > It would require inode_init_always_gfp variant as well (to not > touch all existing callers that do not have any locking requirements but > I do not see any other nested allocations. inode_init_always only has 4 callers, so I'd just add the gfp_t argument. Otherwise this looks good modulo the fix your posted: Acked-by: Christoph Hellwig