From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ADD0C52D7C for ; Wed, 21 Aug 2024 19:10:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA2E26B00F1; Wed, 21 Aug 2024 15:10:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C296F6B00F2; Wed, 21 Aug 2024 15:10:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF1266B00F5; Wed, 21 Aug 2024 15:10:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 929AC6B00F1 for ; Wed, 21 Aug 2024 15:10:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 417811A1070 for ; Wed, 21 Aug 2024 19:10:53 +0000 (UTC) X-FDA: 82477194786.06.29F6939 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 243F6A000C for ; Wed, 21 Aug 2024 19:10:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hG+FoLKV; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724267410; a=rsa-sha256; cv=none; b=b4MOeCB8RGEzTLCy3PZ5SmdtCGaMmPT62G+jmi37jG2dfM2w0Wl+xxeKTq8DOaBkgKpXt/ OI9jiTvMXHrnToEglO1IaXNF3OT+KfSe64HgDAhrxn8sVynW1by0ZBqM/TWyuyDIocaAe0 jCusSbMnJdn1xbJfS/dp0FEQ8Vino14= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hG+FoLKV; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724267410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BAq367Lg1/3EfbDlw0i1dZv1l3nmGW6xuUPajxTPQeg=; b=NSxk2chiaWYJ2OQNBDZO46aLKmDY+q+VGpp+firg1yDQNu0l0/dXVRvOFsk/LrxMXyEE3l oE208J/il9vsmYDFwMurJkjeTz1bqh6YJqZawUSeIQuumqkCHxGPoywFsuZmpYvJm330x0 xUl0vszArBonW9uyhmRw4WMklX6yyKU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724267450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BAq367Lg1/3EfbDlw0i1dZv1l3nmGW6xuUPajxTPQeg=; b=hG+FoLKVuTIMvQov1W8xqodNd0cGHoOzuLOp2TnO6z1/gO7ibvtWRWY3Kqu+jQo1rpO9nV yJ755+oSRWH+ZBupu4wLh6OD9pJqrOP/T9WXEZmnlTV6veuhT2wwy7jX1mkWoyh4V86Sde KOq/1h9uxIn5PnLMpfc9SdFeAhuTO9A= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-xo506whfNa2_IREvppfskg-1; Wed, 21 Aug 2024 15:10:47 -0400 X-MC-Unique: xo506whfNa2_IREvppfskg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6bf6da864a6so81456096d6.3 for ; Wed, 21 Aug 2024 12:10:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724267447; x=1724872247; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BAq367Lg1/3EfbDlw0i1dZv1l3nmGW6xuUPajxTPQeg=; b=Phu2buY64kOn8huB1g4Dr7NKD5FfhQQWn2rFiJW5Tbq0m4Y+R5C2EI+/xMQdeJJDQt R/y6/uvOwq6LfT9+HKGg2fhL9m+JVUTbUsKqT1TBXUg92OZ+Bfc+yOoicLMG1SjgRWoO TIEaMHdZpJ3E+Q1tvTg/Ii5rCarXb3cAIX2H1boSIyuihIAhM7k57kWkfR1M0EyhGMsK DgHfUWeQzk9M1DGSVyU/jgzmOxPbi/fndzQMwsUX8NNWkMDOaPAjAwcXRpU6rRcSsIbU /cnQCTSP5/leVQKfxaZpDYfDsOv0VuexBaXyv4nsYfbn/z+Ctf7s1UNqF8H9M38ov+mJ wmAg== X-Gm-Message-State: AOJu0YyTSCBPm+oDmECV9i8svi0vi0MezsEgX34zyMSQZqPGwmLS5pkR yvYlzUGKG0Nq4WhgZWQuWmKhspuSQWUdghvUHLMJzCylITL0hF794O6A37N4qQikOSGB2J601M0 +u9pPdYbiFsaZjcb3IryHcvQwlCJZnvZ3Tcj/0BF06OnfgeVu X-Received: by 2002:a05:6214:4881:b0:6bf:7cc0:7283 with SMTP id 6a1803df08f44-6c155d5b159mr43529456d6.6.1724267447171; Wed, 21 Aug 2024 12:10:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0EFUeCwlBx0qAmDzBtd+l4FNnqw758KbLszeGCNNuUW9zuat7gLyeNsx6mlWpwsnSymqf3g== X-Received: by 2002:a05:6214:4881:b0:6bf:7cc0:7283 with SMTP id 6a1803df08f44-6c155d5b159mr43529176d6.6.1724267446788; Wed, 21 Aug 2024 12:10:46 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bf6fe1bb00sm64630186d6.55.2024.08.21.12.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 12:10:46 -0700 (PDT) Date: Wed, 21 Aug 2024 15:10:43 -0400 From: Peter Xu To: Sean Christopherson Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador , Jason Gunthorpe , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , David Hildenbrand , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 09/19] mm: New follow_pfnmap API Message-ID: References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-10-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 1qu4bdt67h1eckrtxuxyz3xmsozyd1ni X-Rspamd-Queue-Id: 243F6A000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724267450-310957 X-HE-Meta: U2FsdGVkX19I7nXsNPX+qfm3hBHWmbH1jH6Z0769H719rv2UF4m6+r+fyMNyIxN0hH1As3A7U3v/bGWtN2xXPYUBOVpavpBvcc1ZwGA66RdZUielx6TJApQcoRtTqt+5uRMcahO5kircWOZrIRqB5A8heXxqspRnzV2Vnggoy490DfTje4l3OVyT/Iu04jTpjyaa0Tto7UNSss05lyWFLU3/zWSLIB0IiysszdsODpnc4IIz0QkPgPfbXN9j/DcpXhNvH5Ip3oMWJVrdXK5oBylBCUNTn+aK84hoI5MrsddyWGNoKWDgk5CoLk2h+C+vg7MntiFgJhOr3mP288RXLFYU/AjZG8jovp8t87uBJ53ZfziWns0MMdJezSHsejWi0fkDzAFZw6WUd6XKi2q6Ywgx7gk+lSo8cR+Xv8CRUhP61ExYNbUadtfAtVQCIBpXNf7A6JtaCN2ttAZUmI+SNe7cptvGzBepj2aKWteGmKGxKnCpEIvBYrhDDvisnwykaQ5cjIQgHFAQmcB5VQrpRQGrmfWnnqiiVTafsYzm/13IOajeH8C197XKUaywrQu20vUvcw/f6VULayC/W6y9xASRdEWOUZNyoK3BrOFAJvBwk8OdqZrvFQiZk/n/xeRl594lCmYsnlyIk6DNerDDpUy7CTYf0HaU/jFlWelYeQunULv+JSdr5tIgD4+qxY1mFxk3u+LYQautrfhkcHRu7WEe1JINfCX7JjKQZFchO8/L0lgqcxBEzFMHgPtdoFzD1kx/ctwyv9C1rH+wh23c10AwEDzatO20OUi+sSyoI4e8W90I38y7KXE5z5vkdlOBF4Iq14EF1mB7qgmUuEyrvIDoF9oGKZDseLrleGbHIXDA32GyPZau4MVuIWjM4omKWbWN6LOTakEKnDmDH9ljDo798yT1cRqZ+WjlFLJOwxp/A61AVxPX8f1UWeo/78BnrP7ZlBKPJUHNdUcNGnO waSpf97b L2ammGvy7HnYjud5uzkiOy6B9h4GyGgDLev+RvWfth1/H3bZwsaxCICeZvJHVS1G7YMIp9/aH5QKHOFJgBL11oHMgmDoprHvfzdZG4SBfBBGN3hAdn82ZwS0jnga2cUlX4kjFhAvATmphRHGnHnEx9oyVlMivrCf8AWh0TO02VNlizOSCXTFNlgy03iXSuZlDcxFEAw+O5XydTEKVO2tE0NREkYf1P3bQAgv/3RCUp6JcEeMFQ38iz565/GyIKXkr381DLLdVgVL2OQ7KfR/97Dg0AbT3eM6zCEeBnUk3qxsudhs/3x6tmEW5gm/Zk2IlecVgZ9qpwwPFHW68cCcQxv9jWUxK3Q2itp5gJ4bdwVVLUlgzaAGFSremvWWiKK9jcYY1P0V1Gonw0do= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 04:12:24PM -0700, Sean Christopherson wrote: > On Fri, Aug 09, 2024, Peter Xu wrote: > > Introduce a pair of APIs to follow pfn mappings to get entry information. > > It's very similar to what follow_pte() does before, but different in that > > it recognizes huge pfn mappings. > > ... > > > +int follow_pfnmap_start(struct follow_pfnmap_args *args); > > +void follow_pfnmap_end(struct follow_pfnmap_args *args); > > I find the start+end() terminology to be unintuitive. E.g. I had to look at the > implementation to understand why KVM invoke fixup_user_fault() if follow_pfnmap_start() > failed. > > What about follow_pfnmap_and_lock()? And then maybe follow_pfnmap_unlock()? > Though that second one reads a little weird. If to go with the _lock() I tend to drop "and" to follow_pfnmap_[un]lock(). However looks like David preferred me keeping the name, so we don't reach a quorum yet. I'm happy to change the name as long as we have enough votes.. > > > + * Return: zero on success, -ve otherwise. > > ve? This one came from the old follow_pte() and I kept it. I only knew this after search: a short way to write "negative" (while positive is "+ve"). Doesn't look like something productive.. I'll spell it out in the next version. > > > +int follow_pfnmap_start(struct follow_pfnmap_args *args) > > +{ > > + struct vm_area_struct *vma = args->vma; > > + unsigned long address = args->address; > > + struct mm_struct *mm = vma->vm_mm; > > + spinlock_t *lock; > > + pgd_t *pgdp; > > + p4d_t *p4dp, p4d; > > + pud_t *pudp, pud; > > + pmd_t *pmdp, pmd; > > + pte_t *ptep, pte; > > + > > + pfnmap_lockdep_assert(vma); > > + > > + if (unlikely(address < vma->vm_start || address >= vma->vm_end)) > > + goto out; > > + > > + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) > > + goto out; > > Why use goto intead of simply? > > return -EINVAL; > > That's relevant because I think the cases where no PxE is found should return > -ENOENT, not -EINVAL. E.g. if the caller doesn't precheck, then it can bail > immediately on EINVAL, but know that it's worth trying to fault-in the pfn on > ENOENT. I tend to avoid changing the retval in this series to make the goal of this patchset simple. One issue is I _think_ there's one ioctl() that will rely on this retval: acrn_dev_ioctl -> acrn_vm_memseg_map -> acrn_vm_ram_map -> follow_pfnmap_start So we may want to try check with people to not break it.. Thanks, -- Peter Xu