From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B491C3DA4A for ; Thu, 22 Aug 2024 06:36:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2F246B0114; Thu, 22 Aug 2024 02:36:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDE8C6B0117; Thu, 22 Aug 2024 02:36:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7F8F6B0119; Thu, 22 Aug 2024 02:36:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A7F836B0114 for ; Thu, 22 Aug 2024 02:36:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2C0A816136D for ; Thu, 22 Aug 2024 06:36:21 +0000 (UTC) X-FDA: 82478922162.21.8BE4D6D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 832F020007 for ; Thu, 22 Aug 2024 06:36:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XO+fDA94; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724308514; a=rsa-sha256; cv=none; b=c3ycBZGTyYDKJo9KwDXFONSz2jNx42jRtUxl7zT5fsMvKbfmjLopR/zityk6oyMw1iU5jk UKp1OxCsrbaiP4vK5ZS9ZA3lRLbQPGDLlOTN/l1xH6tm/NdPe41T9U9Ge2GuRgqoQApm8n xSXjt3nBIS6oLMc32ATBQkZaJOAsgNU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XO+fDA94; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724308514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VJgOW0ZygHE79ideUxiyls7o3JuXQJ4tAsmhI265dkA=; b=iaSRfcM39VPfFE7lr00Y6FFirHJB42g8P2KQRR2BNVs1KD5HeJWAeRIb1814j/Syp28NuW ZDOZrxykY7whCZ+TzKn4fk4eR9shToECPchi4vYAb5FQ54WSC7PcSJJyRITWDupohlkxWV 8AX7wJzKco6/qvGXGj49xe+ew1nYLmk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VJgOW0ZygHE79ideUxiyls7o3JuXQJ4tAsmhI265dkA=; b=XO+fDA94jWzmKNQbLS/3vCp5pL tXp0oDjNc17eDu6WCWx0YsrQCDbPb1vNIllqfuef7fKhmny98jYObBPExfUFxosuJeb8ydbbLcXVD sHQW5cppsy+OxnmjW0Xf8jzFNhQUmme+2/wjxESmadIBaX37OnTqt/JxNdHIxftmSDDHAxi6c0HWy XQZfrkOKu8VbY5t15641LEwY7yvJktRiNdHmMaQmgH5HrVTi5TN2JcoQHKX0WRIglgvcRUaHohLjJ qHrFEGWF0jFnaHvpAdEMm9raT5KL+XbGAEV7Tgj9JZuYN5rvQmgC6+G0ci7EuA/QwyOu8rKrAbJht wDs5Rq9Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh1Qf-0000000BdIf-3dAW; Thu, 22 Aug 2024 06:36:17 +0000 Date: Wed, 21 Aug 2024 23:36:17 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 7/7] block: implement async secure erase Message-ID: References: <5ee52b6cc60fb3d4ecc3d689a3b30eabf4359dba.1724297388.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ee52b6cc60fb3d4ecc3d689a3b30eabf4359dba.1724297388.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 832F020007 X-Stat-Signature: gfh7obo8rtknbp76gsdxxysmf5i4bmkm X-Rspam-User: X-HE-Tag: 1724308579-453860 X-HE-Meta: U2FsdGVkX1+szLx0Jgz0nHalP2nWCCA1CJl+pYBEqzmdpY01VYXwZRXsYVWzZtwLFuBwhMOis89OSrEV9aGEk1yj6Q5Gd6MXFHIaNR44uYKbiT6To1G4UNIjnRJQ2ecBPYBvjIEMH84msZ/pMcXytumbmoct8FVmSKbcyVKaJNrK/sLg2rEcdOZ8Fg69vT3FzBDJwqgYM3vVf3xbsB9JHrvHinEbO+eS/iR+84r64OgG5fdLYdS82SUqfQDO/KBdUufgsIPs4X0fRHQIw6nh+yuRrU2MBPvjc89wnnPu5x4Sq1tOsbdN9Sl6zaDT/P80vFElzUh5t5qIFdJ0FW/AJ4OBBGUb8ZjXg16XmGjff3a2fN4bkNRQHmZyezgH2ViMA5dOmG53KuCM/w7zWWXBf79zibZdi4WL+9Gd9psIFjNDsYg879vrJJUXxcvj93eeS8JP4DPlTCVZiRz5xLRHkkyLNW1920NXI4SwBm6y9bnaOn1yOH513YA03gCkUtKNWiWgyreUcu5IUJwmjhSCln9aJ2eJBgZIPkGhJw9VPnc/sgU6AYn8z6/ocVZgEEZU/U0D3zW7w5hDQbrnKbFh9OUc5d7h/0NNG1lGdSiqQuusMv2U9UwPxTWAfdgwOM3WF6lWz5gs9sKW60No2gPS3FciB0I5v+CwZZOcHAUAPn+YzmiCyEJLJ3pBvIptI/3UYftSAs2ScoHdwaBwMCaw/F8Mg5x9FpKvfD9HTwT00VZARyKA4ExDyCREneYdnmSzH4HbUmbBclsIwnk24zg1OHGg5uTAEkpjgjZIBrHP++aoLeeqDBRQIvlGvBaomU4gtYAInVX0G7OhpWOkJazRQkCKYYhSBsu8RoCi1AAfWEHHCRbXAOHJTzFGnGFYgflpbR5osjMASZpk2F1ghOJR1Pyt5ZWL3NRz8zvtLaC6h/6bFfhE8IgeQZymex2dapEklduUre4CfPzJUPv/GGE a5v9m8Kb CMYuclhg3IHi5buRzZ7e252zEd2J9GDPRcETW9i1BhW3sML9sQQgf1cLFkMcdwceGApI5Fq+4s4yw92OZu7TuPdJ1lbl7gNRxCtywWOzzsWlZYnJczcpSv4TSCNgQnO3+e3ko+6m6lopKL6gk8aXXOd1uXP95Zua8g7iqoVMFsJyq7S6FDxEnx5/evoXlm/g9rb6wlUsFK2k+tVPuhC2v44BJWmui6iEcA9lt8hZXHpTsNH+sBzyz26YTif1JQC7uqhaRgBx3/4t7apHshU4T+3WRAQ+piCRa3L27efmJ29xKkC9fCKNpVAa7gONALwI1y+/Lv3Y74YIeENrWlXEuXZBlCVERktouHHMQyzt6oVMRvThBFPhMeMfBcNRZtyiFOZCSh38q7q1fs0fePv33oov65U6Oj6H9XfAsfA+evTyUtg500rk9fxJ2jpd3I92yYyRwTSnzRlMKNVxLiIBBlRIxCXm+7JASUwPLj9xbXsy60vWzaRMsK+I8XWLovKL9pZVXb24p7aUfCdf8HI7d1wSMzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 04:35:57AM +0100, Pavel Begunkov wrote: > Add yet another io_uring cmd implementing async secure erases. > It has same page cache races as async discards and write zeroes and > reuses the common paths in general. How did you test this? Asking because my interruption fix for secure discard is still pending because I could not find a test environment for it. And also because for a "secure" [1] erase proper invalidation of the page cache actually matters, as otherwise you can still leak data to the device. [2] LBA based "secure" erase can't actually be secure on any storage device that can write out of place. Which is all of flash, but also modern HDDs when encountering error. It's a really bad interface we should never have have started to support.